[CFT][CFR] Resurrect handling of VersionAddendum in OpenSSH

[Eygene Ryabinkin]

Good day.

I had created patches for OpenSSH to resurrect handling of
VersionAddendum and, additionally, enable/disable advertisements
for HPN feature in sshd version banner. des@, bz@ and brooks@
are aware of this patch, Bjoern even reviewed the first version
of the patch, but the second one isn't yet reviewed.

Can anyone who uses SSH test this patch and report their findings
to the respective PR. Also, code reviews are welcome too.

Thanks!


PR: http://www.freebsd.org/cgi/query-pr.cgi?pr=163843

Patches:
* 8-STABLE,
http://codelabs.ru/fbsd/patches/openssh/OpenSSH-fix-VersionAddendum-handling-8-STABLE.diff
* 9-STABLE,
http://codelabs.ru/fbsd/patches/openssh/OpenSSH-fix-VersionAddendum-handling-9-STABLE.diff
* 10-CURRENT,
http://codelabs.ru/fbsd/patches/openssh/OpenSSH-fix-VersionAddendum-handling.diff

Instructions:
{{{
cd /usr/src
fetch -o ssh-addendum.diff http://codelabs.ru/fbsd/patches/openssh/OpenSSH-fix-VersionAddendum-handling.diff
patch -p1 < ssh-addendum.diff
cd secure/lib/libssh
make && make install
cd ../../usr.sbin/sshd
make && make install && service sshd restart
cd ../..//usr.bin/ssh
make && make install
}}}
--
Eygene Ryabinkin ,,,^..^,,,
[ Life's unfair - but root password helps! | codelabs.ru ]
[ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ]

[Eygene Ryabinkin]

Sat, May 26, 2012 at 02:34:20PM +0400, Eygene Ryabinkin wrote:
> Can anyone who uses SSH test this patch and report their findings
> to the respective PR. Also, code reviews are welcome too.

I head been blessed by des@ to commit the code into -CURRENT
and I did so,
http://svnweb.freebsd.org/base?view=revision&revision=236139
so people who run HEAD will automatically receive this fix
starting from now.