Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
getting feedback on previous posts?
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Dale Hagglund  
View profile  
 More options Jan 16 2012, 12:16 pm
From: Dale Hagglund <dale.haggl...@gmail.com>
Date: Mon, 16 Jan 2012 09:16:54 -0800 (PST)
Local: Mon, Jan 16 2012 12:16 pm
Subject: getting feedback on previous posts?

Hi everybody.  Now that 1.1.1's out, I thought I'd ask about the fate of
some changes I posted late last year.

Around Christmas, I posted (both to the list and as a pull request) a small
set of changes I've accumulated since I've been using magit more seriously
for about a two months now.  Unfortunately (at least from my perspective) I
haven't gotten any feedback, so I wondered if I inadvertently submitted the
changes in a way that doesn't work well for the list or the pull request
reviewers.  Would, for example, it be better for people if I posted the
changes separately?  (They are essentially independent.)  In the
intervening weeks, I've found a few bugs / regressions in one of the
changesets, so I need to repost at least that anyway.

Any feedback would be much appreciated.

Thanks,

Dale.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Yann Hodique  
View profile  
 More options Jan 16 2012, 12:41 pm
From: Yann Hodique <yann.hodi...@gmail.com>
Date: Mon, 16 Jan 2012 18:41:41 +0100
Local: Mon, Jan 16 2012 12:41 pm
Subject: Re: getting feedback on previous posts?

>>>>> "Dale" == Dale Hagglund <dale.haggl...@gmail.com> writes:
> Hi everybody.  Now that 1.1.1's out, I thought I'd ask about the fate of
> some changes I posted late last year.
> Around Christmas, I posted (both to the list and as a pull request) a small
> set of changes I've accumulated since I've been using magit more seriously
> for about a two months now.  Unfortunately (at least from my perspective) I
> haven't gotten any feedback, so I wondered if I inadvertently submitted the
> changes in a way that doesn't work well for the list or the pull request
> reviewers.  Would, for example, it be better for people if I posted the
> changes separately?  (They are essentially independent.)  In the
> intervening weeks, I've found a few bugs / regressions in one of the
> changesets, so I need to repost at least that anyway.
> Any feedback would be much appreciated.

Hi Dale,

sorry for the lack of feedback. During the last weeks I've been trying
to deal with the backlog we have, with mitigated success :) (not too bad
on pull requests, not too good on issues).
Anyway I must confess that having an identified issue in your request
made it fall down the priority list :)

Also, as you note (and this is a pretty general remark here), mixing
various changes in a single pull request tends to delay treatment
further, as the review is less "focused". I could (and do sometimes)
cherry-pick changes, but when I'm doing so, I'd rather be sure the other
ones are to be discarded. Otherwise I'm wasting everybody's time with
useless history rewriting.

Bottom line, shorter pull requests will get faster merge/feedback :)

Anyhow, I plan having a look at your code in the coming days.

Thanks,

Yann.

--
I must rule with eye and claw -- as the hawk among lesser birds.

  -- DUKE PAULUS ATREIDES, The Atreides Assertion


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »