Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
lucky.linux.kernel
+ new post
About this group
Subscribe to this group
This is a Usenet group - learn more
Message from discussion seperator error in __mask_snprintf_len
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Andrew Morton  
View profile  
 More options Jan 15 2004, 8:09 pm
Newsgroups: lucky.linux.kernel
From: Andrew Morton <a...@osdl.org>
Date: Fri, 16 Jan 2004 01:09:26 +0000 (UTC)
Local: Thurs, Jan 15 2004 8:09 pm
Subject: Re: seperator error in __mask_snprintf_len
Print | View thread | Show original | Report this message | Find messages by this author

Paul Jackson <p...@sgi.com> wrote:

> Andrew wrote:
> > Gad.

> Could you elaborate a bit on this critique, Andrew?

The code seems very complex for such a conceptually simple problem.

And doubts remain whether it is correct on particular wordsize/endianness
machines.

It seems that there is a layering violation in which this code is poking
around inside representations which should known only to the particular
architecture.  Hence, if we can find a way to provide this function using
existing architecture API's (test_bit) then everything is solved.

If this code needs some arch-provided support function then so be it.
That's better than adding a tangle of ifdefs in generic code.

> Did I provide too many comments?

You can never provide too many comments!

Anyway, please wake me up again when you and Joe have finished.  (I agree
that making that function take a number of bits is better than taking a
number of bytes btw).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google