Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
[PATCH] Re: SYSVOL ACLs and GPOs
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  Messages 26 - 33 of 33 - Collapse all  -  Translate all to Translated (View all originals) < Older 
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Andrew Bartlett  
View profile  
 More options Nov 4 2012, 9:20 pm
Newsgroups: linux.samba
From: Andrew Bartlett <abart...@samba.org>
Date: Mon, 05 Nov 2012 03:20:01 +0100
Local: Sun, Nov 4 2012 9:20 pm
Subject: [Samba] [PATCH] Re: SYSVOL ACLs and GPOs

It is certainly very helpful to have this happen with samba-tool.  Can
you remind me the history of this domain, is it the upgrade I was trying
to suggest you do, or a fresh provision?

If you can tell me what provision command-line you run, if it was
provisioned with an older version, which branch and git revision that
was and what branch and git revision as you running now?

I've tried to replicate this in 'make test' but failed (the tests pass).
The patch for that is attached for review.

Thanks,

Andrew Bartlett

--
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

  0001-selfltest-check-that-samba-tool-gpo-works-for-basic-.patch
4K Download

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Andrew Bartlett  
View profile  
 More options Nov 5 2012, 4:10 pm
Newsgroups: linux.samba
From: Andrew Bartlett <abart...@samba.org>
Date: Mon, 05 Nov 2012 22:10:02 +0100
Local: Mon, Nov 5 2012 4:10 pm
Subject: Re: [Samba] [PATCH] Re: SYSVOL ACLs and GPOs

I'll fix those up and push it.

It's the only test we have at the moment for our server-side support
(being able to add the GPO, with a valid acl and owner etc).

Indeed, that was why I added it, because it was suggested this tool
showed up the issues we have been having (it didn't).

Thanks,

Andrew Bartlett

--
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Jelmer Vernooij  
View profile  
 More options Nov 5 2012, 8:40 pm
Newsgroups: linux.samba
From: Jelmer Vernooij <jel...@samba.org>
Date: Tue, 06 Nov 2012 02:40:02 +0100
Local: Mon, Nov 5 2012 8:40 pm
Subject: Re: [Samba] [PATCH] Re: SYSVOL ACLs and GPOs

Thanks. Yay for more tests; please find some minor notes below:

^^^ temporary :-)

> +        super(GpoCmdTestCase, self).setUp()
> +        (result, out, err) = self.runsubcmd("gpo", "create", self.gpo_name, "-H", "ldap://%s" % os.environ["SERVER"], "-U%s%%%s" % (os.environ["USERNAME"], os.environ["PASSWORD"]))
> +        self.gpo_guid = "{%s}" % out.split("{")[1].split("}")[0]
> +
> +        self.assertCmdSuccess(result, "Ensuring gpo created successfully")
> +
> +    def tearDown(self):
> +        """remote the tempoary GPO to work with"""

^^^ remove, temporary :-)

> +        (result, out, err) = self.runsubcmd("gpo", "del", self.gpo_guid, "-H", "ldap://%s" % os.environ["SERVER"], "-U%s%%%s" % (os.environ["USERNAME"], os.environ["PASSWORD"]))
> +        self.assertCmdSuccess(result, "Ensuring gpo deleted successfully")
> +        super(GpoCmdTestCase, self).tearDown()
> +
> +
> diff --git a/source4/selftest/tests.py b/source4/selftest/tests.py
> index ca5bdd3..61540d0 100755
> --- a/source4/selftest/tests.py
> +++ b/source4/selftest/tests.py
> @@ -405,6 +405,8 @@ planpythontestsuite("dc:local", "samba.tests.dcerpc.bare")
>  planpythontestsuite("dc:local", "samba.tests.dcerpc.unix")
>  planpythontestsuite("dc:local", "samba.tests.dcerpc.srvsvc")
>  planpythontestsuite("dc:local", "samba.tests.samba_tool.timecmd")
> +planpythontestsuite("dc:local", "samba.tests.samba_tool.gpo")
> +planpythontestsuite("plugin_s4_dc:local", "samba.tests.samba_tool.gpo")

Do we really need to run these tests against both environments? These
tests ought to be testing that the samba-tool gpo subcommand works
well, not our server side GPO support.

As far as I know the gpo subcommands don't have any different
behaviour for these two environments.

>  planpythontestsuite("dc:local", "samba.tests.samba_tool.processes")
>  planpythontestsuite("dc:local", "samba.tests.samba_tool.user")
>  planpythontestsuite("dc:local", "samba.tests.samba_tool.group")

Cheers,

Jelmer
--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Jelmer Vernooij  
View profile  
 More options Nov 5 2012, 8:40 pm
Newsgroups: linux.samba
From: Jelmer Vernooij <jel...@samba.org>
Date: Tue, 06 Nov 2012 02:40:02 +0100
Local: Mon, Nov 5 2012 8:40 pm
Subject: Re: [Samba] [PATCH] Re: SYSVOL ACLs and GPOs

If we really want to run these tests against both environments, for
lack of any more appropriate tests, it would be nice to add a comment
saying so.

Cheers,

Jelmer

  signature.asc
< 1K Download

--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Alex Matthews  
View profile  
 More options Nov 6 2012, 6:50 am
Newsgroups: linux.samba
From: Alex Matthews <qoole.sa...@lillimoth.com>
Date: Tue, 06 Nov 2012 12:50:02 +0100
Local: Tues, Nov 6 2012 6:50 am
Subject: Re: [Samba] [PATCH] Re: SYSVOL ACLs and GPOs
On 05/11/2012 02:10, Andrew Bartlett wrote:

> It is certainly very helpful to have this happen with samba-tool.  Can
> you remind me the history of this domain, is it the upgrade I was trying
> to suggest you do, or a fresh provision?

> If you can tell me what provision command-line you run, if it was
> provisioned with an older version, which branch and git revision that
> was and what branch and git revision as you running now?

> I've tried to replicate this in 'make test' but failed (the tests pass).
> The patch for that is attached for review.

> Thanks,

> Andrew Bartlett

Ok, I think we've got a bit lost in issues here, so I'll start from the
very beginning (I've heard it's a very good place to start).

I have set up two domains:

home.lillimoth.com - a test domain set up on virtual machines at home.
This domain has been provisioned from scratch.
internal.stmaryscollege.co.uk - a production domain at my work place.
This domain was migrated from a samba 3 domain.

My issue is that when I run gpmc (the group policy management console)
on a windows machine (XP or 7) and selected a gpo to edit I get the message:

"The permissions for this GPO in the SYSVOL folder are inconsistent with
those in Active Directory.
It is recommended that these permissions be consistent.
To change the SYSVOL permissions to those in Active Directory, click
OK." - Please see: http://support.microsoft.com/kb/828760

This occurs on both domains.
Clicking 'ok' to the popup should correct the ACLs on the files/folders
it believes are incorrect.
Please note that before clicking 'ok' sysvolcheck passes with no errors
however after clicking it would fail with the following error:

"ERROR(<class 'samba.provision.ProvisioningError'>): uncaught exception
- ProvisioningError: VFS ACL on GPO directory
/usr/local/samba/var/locks/sysvol/home.lillimoth.com/Policies/{31B2F340-016 D-11D2-945F-00C04FB984F9}
O:DAG:DUD:(A;OICI;0x001f01ff;;;DA)(A;OICI;0x001200a9;;;ED)(A;OICI;0x001200a 9;;;AU)(A;OICI;0x001f01ff;;;DA)(A;;0x001200a9;;;DA)(A;;0x001200a9;;;EA)(A;; 0x001200a9;;;SY)(A;OICIIO;0x001f01ff;;;CO)(A;OICIIO;WO;;;CG)(A;OICIIO;0x001 f01ff;;;EA)(A;OICIIO;0x001f01ff;;;SY)
does not match expected value
O:DAG:DUD:P(A;OICI;0x001f01ff;;;DA)(A;OICI;0x001f01ff;;;EA)(A;OICIIO;0x001f 01ff;;;CO)(A;OICI;0x001f01ff;;;DA)(A;OICI;0x001f01ff;;;SY)(A;OICI;0x001200a 9;;;AU)(A;OICI;0x001200a9;;;ED)S:AI(OU;CIIDSA;WP;f30e3bbe-9ff0-11d1-b603-00 00f80367c1;bf967aa5-0de6-11d0-a285-00aa003049e2;WD)(OU;CIIDSA;WP;f30e3bbf-9 ff0-11d1-b603-0000f80367c1;bf967aa5-0de6-11d0-a285-00aa003049e2;WD)
from GPO object"

This suggests that the gpmc did change the ACLs however when reselecting
the same GPO it pops up with the same message again!
Both servers have the correct mount options (user_xattr,acl) and acls
work when set manually.

I did some research into what the ACLs should be on the sysvol share and
came up with these: http://pastebin.com/sSURWrDf which were taken from a
WS2003 machine.

I have not yet attempted to set these on my S4 server but will try that
tonight.

The issue seems to revolve around:
     Incorrect initial ACLs on the sysvol share and its subfolders.
     The inability of the GPMC to correct the issue. Suggesting that
there is some issue setting ACLs on the sysvol share from a windows client.

There we a couple of issues with samba-tool creating GPOs but I will run
through those in an email later this evening when I have had chance to
test them on my test domain.

Thanks,

Alex

--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Alex Matthews  
View profile  
 More options Nov 6 2012, 3:50 pm
Newsgroups: linux.samba
From: Alex Matthews <qoole.sa...@lillimoth.com>
Date: Tue, 06 Nov 2012 21:50:01 +0100
Local: Tues, Nov 6 2012 3:50 pm
Subject: Re: [Samba] [PATCH] Re: SYSVOL ACLs and GPOs
On 06/11/2012 11:43, Alex Matthews wrote:

I have just attempted to set the ACL on the sysvol directory using
samba-tool ntacl set and got the following message:

/usr/local/samba/var/locks# ../../bin/samba-tool ntacl set
"D:AI(A;ID;0x1200a9;;;AU)(A;OICIIOID;GXGR;;;AU)(A;ID;0x1200a9;;;SO)(A;OICII OID;GXGR;;;SO)(A;ID;FA;;;BA)(A;OICIIOID;GA;;;BA)(A;ID;FA;;;SY)(A;OICIIOID;G A;;;SY)(A;OICIIOID;GA;;;CO)"
sysvol -d 2
lpcfg_load: refreshing parameters from /usr/local/samba/etc/smb.conf
rlimit_max: increasing rlimit_max (1024) to minimum Windows limit (16384)
Processing section "[netlogon]"
Processing section "[sysvol]"
Unknown flag - FA in FA
Badly formatted SDDL
'AI(A;ID;0x1200a9;;;AU)(A;OICIIOID;GXGR;;;AU)(A;ID;0x1200a9;;;SO)(A;OICIIOI D;GXGR;;;SO)(A;ID;FA;;;BA)(A;OICIIOID;GA;;;BA)(A;ID;FA;;;SY)(A;OICIIOID;GA; ;;SY)(A;OICIIOID;GA;;;CO)'
ERROR(<type 'exceptions.TypeError'>): uncaught exception - Unable to
parse SDDL
   File
"/usr/local/samba/lib/python2.7/site-packages/samba/netcmd/__init__.py",
line 175, in _run
     return self.run(*args, **kwargs)
   File
"/usr/local/samba/lib/python2.7/site-packages/samba/netcmd/ntacl.py",
line 90, in run
     setntacl(lp, file, acl, str(domain_sid), xattr_backend, eadb_file,
use_ntvfs=use_ntvfs)
   File "/usr/local/samba/lib/python2.7/site-packages/samba/ntacls.py",
line 89, in setntacl
     sd = security.descriptor.from_sddl(sddl, sid)

FA is listed on the Microsoft ACE String page as FILE_ALL_ACCESS
(http://msdn.microsoft.com/en-gb/library/windows/desktop/aa374928(v=vs...
<http://msdn.microsoft.com/en-gb/library/windows/desktop/aa374928%28v=...>)

Is it correct that the sddl parser cannot parse FA?

Thanks,

Alex
--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Discussion subject changed to "SYSVOL ACLs and GPOs" by Andrew Bartlett
Andrew Bartlett  
View profile  
 More options Nov 10 2012, 9:20 pm
Newsgroups: linux.samba
From: Andrew Bartlett <abart...@samba.org>
Date: Sun, 11 Nov 2012 03:20:01 +0100
Local: Sat, Nov 10 2012 9:20 pm
Subject: Re: [Samba] SYSVOL ACLs and GPOs

Jeremy,

You said earlier in the thread that you were going to look into this.
I'll continue to try and find angles on this, but did you get anywhere
with sorting out Alex's issues?

Thanks,

Andrew Bartlett

--
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Olivier BILHAUT  
View profile  
 More options Nov 21 2012, 3:40 am
Newsgroups: linux.samba
From: Olivier BILHAUT <o.bilh...@fondation-misericorde.fr>
Date: Wed, 21 Nov 2012 09:40:03 +0100
Local: Wed, Nov 21 2012 3:40 am
Subject: Re: [Samba] SYSVOL ACLs and GPOs
Hi Andrew, Hi Alex, Hi all.

We're really pleased to announce that in this release (S4 rc5), the
sysvolreset command works fine and returns no errors.

The clients download their GPO fine, and the sysvolcheck return no error
as well !

So our problems with SYSVOL ACL are closed for the moment.

Thanks for your efforts.

-----------------------
***     OB
***     Service Informatique
***     Fondation de la Miséricorde

Le 26/10/2012 11:48, Andrew Bartlett a écrit :

--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages < Older 
« Back to Discussions « Newer topic     Older topic »