[PATCH 0/3] staging: r8187se: Miscellaneous cleanups

Larry Finger

unread,

Feb 14, 2010, 11:00:02 PM2/14/10

to

This series of patches comprise further cleanups of the staging driver.

1. Remove dead routine from r8180_core.c.

2. Remove two private variables that have a fixed value.

3. Remove dead code from r8185b_init.c.

Signed-off-by: Larry Finger <Larry....@lwfinger.net>
---

Patch 1:

r8180_core.c | 37 -------------------------------------
1 file changed, 37 deletions(-)

Patch 2:

Patch 3:

r8185b_init.c | 633 ----------------------------------------------------------
1 file changed, 2 insertions(+), 631 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Larry Finger

unread,

Feb 15, 2010, 10:20:02 AM2/15/10

to

Greg KH

unread,

Feb 18, 2010, 11:20:02 AM2/18/10

to

On Mon, Feb 15, 2010 at 09:10:08AM -0600, Larry Finger wrote:
> This series of patches comprise further cleanups of the staging driver.
>
> 1. Remove dead routine from r8180_core.c.
>
> 2. Remove two private variables that have a fixed value.
>
> 3. Remove dead code from r8185b_init.c.
>
> Signed-off-by: Larry Finger <Larry....@lwfinger.net>

Ick, I just applied your first versions of these patches. What was the
difference here? Care to look at the next linux-next tree and see if I
missed anything?

sorry about that.

greg k-h

Larry Finger

unread,

Feb 18, 2010, 12:10:03 PM2/18/10

to

On 02/18/2010 10:03 AM, Greg KH wrote:
> On Mon, Feb 15, 2010 at 09:10:08AM -0600, Larry Finger wrote:
>
> Ick, I just applied your first versions of these patches. What was the
> difference here? Care to look at the next linux-next tree and see if I
> missed anything?
>
> sorry about that.

The only difference was that I fixed the line-wrap problem that you noted in
your previous Emails. I had found them and resubmitted. There were no content
changes in the patches and the tree appears to be OK.

Thanks for the heads-up and sorry for the trouble, Those damned long lines from
the Realtek driver are a pain.

FYI, the rewritten driver has received a beacon, and the first few parts have
been submitted to John Linville.

Larry

Greg KH

unread,

Feb 18, 2010, 12:20:02 PM2/18/10

to

On Thu, Feb 18, 2010 at 11:01:36AM -0600, Larry Finger wrote:
> On 02/18/2010 10:03 AM, Greg KH wrote:
> > On Mon, Feb 15, 2010 at 09:10:08AM -0600, Larry Finger wrote:
> >
> > Ick, I just applied your first versions of these patches. What was the
> > difference here? Care to look at the next linux-next tree and see if I
> > missed anything?
> >
> > sorry about that.
>
> The only difference was that I fixed the line-wrap problem that you noted in
> your previous Emails. I had found them and resubmitted. There were no content
> changes in the patches and the tree appears to be OK.
>
> Thanks for the heads-up and sorry for the trouble, Those damned long lines from
> the Realtek driver are a pain.

Yes they are :)

> FYI, the rewritten driver has received a beacon, and the first few parts have
> been submitted to John Linville.

Wonderful, that's great to hear, hopefully we can delete this driver
soon.

thanks,

greg k-h