Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[patch] vlynq: fix another resource size off by 1 error

0 views
Skip to first unread message

Dan Carpenter

unread,
Jan 13, 2014, 3:20:01 AM1/13/14
to
We fixed the call to request_mem_region() patch
3354f73 ('drivers/vlynq/vlynq.c: fix resource size off by 1 error').
But we need to fix the call the release_mem_region() as well.

Signed-off-by: Dan Carpenter <dan.ca...@oracle.com>
---
Resending so that that Andrew can take it.

diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
index 7b07135..c0227f9 100644
--- a/drivers/vlynq/vlynq.c
+++ b/drivers/vlynq/vlynq.c
@@ -762,7 +762,8 @@ static int vlynq_remove(struct platform_device *pdev)

device_unregister(&dev->dev);
iounmap(dev->local);
- release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start);
+ release_mem_region(dev->regs_start,
+ dev->regs_end - dev->regs_start + 1);

kfree(dev);

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Dan Carpenter

unread,
Nov 11, 2013, 6:50:01 AM11/11/13
to
We still need to apply this fix.

regards,
dan carpenter

On Fri, Aug 23, 2013 at 11:19:49AM +0300, Dan Carpenter wrote:
> We fixed the call to request_mem_region() patch
> 3354f73 ('drivers/vlynq/vlynq.c: fix resource size off by 1 error').
> But we need to fix the call the release_mem_region() as well.
>
> Signed-off-by: Dan Carpenter <dan.ca...@oracle.com>
> ---
> Static checker stuff.
>
> diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
> index 7b07135..c0227f9 100644
> --- a/drivers/vlynq/vlynq.c
> +++ b/drivers/vlynq/vlynq.c
> @@ -762,7 +762,8 @@ static int vlynq_remove(struct platform_device *pdev)
>
> device_unregister(&dev->dev);
> iounmap(dev->local);
> - release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start);
> + release_mem_region(dev->regs_start,
> + dev->regs_end - dev->regs_start + 1);
>
> kfree(dev);
>
--

Florian Fainelli

unread,
Jan 12, 2014, 2:50:02 PM1/12/14
to
Le lundi 11 novembre 2013, 14:48:27 Dan Carpenter a �crit :
> We still need to apply this fix.

Sorry for this late answer, vlynq changes usually go through AKPM's tree as I
don't maintain one due to the low number of changes in this code.
--
Florian

Dan Carpenter

unread,
Jan 13, 2014, 3:50:01 AM1/13/14
to
We fixed the call to request_mem_region() patch
3354f73 ('drivers/vlynq/vlynq.c: fix resource size off by 1 error').
But we need to fix the call the release_mem_region() as well.

Signed-off-by: Dan Carpenter <dan.ca...@oracle.com>
---
Resending (again) with Andrew's email corrected.

Hi, Andrew, Florian says this has to go through your tree. I assume
that means he has Acked it. :)

diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
index 7b07135..c0227f9 100644
--- a/drivers/vlynq/vlynq.c
+++ b/drivers/vlynq/vlynq.c
@@ -762,7 +762,8 @@ static int vlynq_remove(struct platform_device *pdev)

device_unregister(&dev->dev);
iounmap(dev->local);
- release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start);
+ release_mem_region(dev->regs_start,
+ dev->regs_end - dev->regs_start + 1);

kfree(dev);

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
0 new messages