Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH -mmotm] cgroup: fix typo in error handling in cgroup_write_event_control()

0 views
Skip to first unread message

Kirill A. Shutemov

unread,
Feb 24, 2010, 8:40:02 AM2/24/10
to
Actually, we want to fput() cfile, if cfile is not NULL.

Signed-off-by: Kirill A. Shutemov <kir...@shutemov.name>
---
kernel/cgroup.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index d142524..049ce0d 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -3117,7 +3117,7 @@ static int cgroup_write_event_control(struct cgroup *cgrp, struct cftype *cft,
return 0;

fail:
- if (!cfile)
+ if (cfile)
fput(cfile);

if (event && event->eventfd && !IS_ERR(event->eventfd))
--
1.6.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Paul Menage

unread,
Feb 24, 2010, 11:10:03 AM2/24/10
to
On Wed, Feb 24, 2010 at 5:31 AM, Kirill A. Shutemov
<kir...@shutemov.name> wrote:
> Actually, we want to fput() cfile, if cfile is not NULL.
>
> Signed-off-by: Kirill A. Shutemov <kir...@shutemov.name>

Thanks.

Acked-by: Paul Menage <men...@google.com>

0 new messages