Some simple Checkpatch.pl cleanup
Andrea Gelmini
here's some simple Checkpatch.pl cleanup.
They apply and compile on latest Linus' git tree¹ as well
as on next-20100226.
Thanks a lot for your work,
Andrea
--------------------------
¹ 06a79b82b2a3e4bebb9a20638ca208c780e9e507
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/um/drivers/stdio_console.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/um/drivers/stdio_console.h b/arch/um/drivers/stdio_console.h
index 6d8275f..587cd2d 100644
--- a/arch/um/drivers/stdio_console.h
+++ b/arch/um/drivers/stdio_console.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2000 Jeff Dike (jd...@karaya.com)
* Licensed under the GPL
*/
@@ -8,4 +8,3 @@
extern void save_console_flags(void);
#endif
-
--
1.7.0.90.g251a4
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
sound/oss/coproc.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/oss/coproc.h b/sound/oss/coproc.h
index 7306346..7bec21b 100644
--- a/sound/oss/coproc.h
+++ b/sound/oss/coproc.h
@@ -4,7 +4,7 @@
*/
/*
- * Coprocessor access types
+ * Coprocessor access types
*/
#define COPR_CUSTOM 0x0001 /* Custom applications */
#define COPR_MIDI 0x0002 /* MIDI (MPU-401) emulation */
--
1.7.0.90.g251a4
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/um/sys-ia64/sysdep/sigcontext.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/um/sys-ia64/sysdep/sigcontext.h b/arch/um/sys-ia64/sysdep/sigcontext.h
index 76b4316..f3caa4c 100644
--- a/arch/um/sys-ia64/sysdep/sigcontext.h
+++ b/arch/um/sys-ia64/sysdep/sigcontext.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2000 Jeff Dike (jd...@karaya.com)
* Licensed under the GPL
*/
@@ -7,4 +7,3 @@
#define __SYSDEP_IA64_SIGCONTEXT_H
#endif
-
--
1.7.0.90.g251a4
Andrea Gelmini
fs/befs/btree.h:12: ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
fs/befs/btree.h | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/befs/btree.h b/fs/befs/btree.h
index 92e781e..9c85aea 100644
--- a/fs/befs/btree.h
+++ b/fs/befs/btree.h
@@ -1,6 +1,6 @@
/*
* btree.h
- *
+ *
*/
@@ -9,5 +9,4 @@ int befs_btree_find(struct super_block *sb, befs_data_stream * ds,
int befs_btree_read(struct super_block *sb, befs_data_stream * ds,
loff_t key_no, size_t bufsize, char *keybuf,
- size_t * keysize, befs_off_t * value);
-
+ size_t *keysize, befs_off_t *value);
--
1.7.0.90.g251a4
Andrea Gelmini
arch/parisc/include/asm/current.h:12: ERROR: trailing whitespace
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/parisc/include/asm/current.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/parisc/include/asm/current.h b/arch/parisc/include/asm/current.h
index 0fb9338..4cbf4ad 100644
--- a/arch/parisc/include/asm/current.h
+++ b/arch/parisc/include/asm/current.h
@@ -5,11 +5,11 @@
struct task_struct;
-static inline struct task_struct * get_current(void)
+static inline struct task_struct *get_current(void)
{
return current_thread_info()->task;
}
-
+
#define current get_current()
#endif /* !(_PARISC_CURRENT_H) */
--
1.7.0.90.g251a4
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/um/drivers/pcap_user.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/um/drivers/pcap_user.h b/arch/um/drivers/pcap_user.h
index d8ba615..6ff1c46 100644
--- a/arch/um/drivers/pcap_user.h
+++ b/arch/um/drivers/pcap_user.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2002 Jeff Dike (jd...@karaya.com)
* Licensed under the GPL
*/
@@ -18,4 +18,3 @@ struct pcap_data {
extern const struct net_user_info pcap_user_info;
extern int pcap_user_read(int fd, void *buf, int len, struct pcap_data *pri);
-
--
1.7.0.90.g251a4
Andrea Gelmini
arch/um/sys-ppc/shared/sysdep/skas_ptrace.h:11: ERROR: code indent should use tabs where possible
arch/um/sys-ppc/shared/sysdep/skas_ptrace.h:15: ERROR: code indent should use tabs where possible
arch/um/sys-ppc/shared/sysdep/skas_ptrace.h:16: ERROR: code indent should use tabs where possible
arch/um/sys-ppc/shared/sysdep/skas_ptrace.h:17: ERROR: code indent should use tabs where possible
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/um/sys-ppc/shared/sysdep/skas_ptrace.h | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/um/sys-ppc/shared/sysdep/skas_ptrace.h b/arch/um/sys-ppc/shared/sysdep/skas_ptrace.h
index d9fbbac..f26f93b 100644
--- a/arch/um/sys-ppc/shared/sysdep/skas_ptrace.h
+++ b/arch/um/sys-ppc/shared/sysdep/skas_ptrace.h
@@ -7,14 +7,14 @@
#define __SYSDEP_PPC_SKAS_PTRACE_H
struct ptrace_faultinfo {
- int is_write;
- unsigned long addr;
+ int is_write;
+ unsigned long addr;
};
struct ptrace_ldt {
- int func;
- void *ptr;
- unsigned long bytecount;
+ int func;
+ void *ptr;
+ unsigned long bytecount;
};
#define PTRACE_LDT 54
--
1.7.0.90.g251a4
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
include/linux/mtd/mtdram.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/mtd/mtdram.h b/include/linux/mtd/mtdram.h
index 04fdc07..6889131 100644
--- a/include/linux/mtd/mtdram.h
+++ b/include/linux/mtd/mtdram.h
@@ -3,6 +3,6 @@
#include <linux/mtd/mtd.h>
int mtdram_init_device(struct mtd_info *mtd, void *mapped_address,
- unsigned long size, char *name);
+ unsigned long size, char *name);
#endif /* __MTD_MTDRAM_H__ */
--
1.7.0.90.g251a4
Andrea Gelmini
arch/um/sys-i386/shared/sysdep/skas_ptrace.h:11: ERROR: code indent should use tabs where possible
arch/um/sys-i386/shared/sysdep/skas_ptrace.h:15: ERROR: code indent should use tabs where possible
arch/um/sys-i386/shared/sysdep/skas_ptrace.h:16: ERROR: code indent should use tabs where possible
arch/um/sys-i386/shared/sysdep/skas_ptrace.h:17: ERROR: code indent should use tabs where possible
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/um/sys-i386/shared/sysdep/skas_ptrace.h | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/um/sys-i386/shared/sysdep/skas_ptrace.h b/arch/um/sys-i386/shared/sysdep/skas_ptrace.h
index e27b8a7..0f6cebb 100644
--- a/arch/um/sys-i386/shared/sysdep/skas_ptrace.h
+++ b/arch/um/sys-i386/shared/sysdep/skas_ptrace.h
@@ -7,14 +7,14 @@
#define __SYSDEP_I386_SKAS_PTRACE_H
struct ptrace_faultinfo {
- int is_write;
- unsigned long addr;
+ int is_write;
+ unsigned long addr;
};
struct ptrace_ldt {
- int func;
- void *ptr;
- unsigned long bytecount;
+ int func;
+ void *ptr;
+ unsigned long bytecount;
};
#define PTRACE_LDT 54
--
1.7.0.90.g251a4
--
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
.../linux/netfilter/nf_conntrack_tuple_common.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/include/linux/netfilter/nf_conntrack_tuple_common.h b/include/linux/netfilter/nf_conntrack_tuple_common.h
index 8e145f0..2ea22b0 100644
--- a/include/linux/netfilter/nf_conntrack_tuple_common.h
+++ b/include/linux/netfilter/nf_conntrack_tuple_common.h
@@ -1,8 +1,7 @@
#ifndef _NF_CONNTRACK_TUPLE_COMMON_H
#define _NF_CONNTRACK_TUPLE_COMMON_H
-enum ip_conntrack_dir
-{
+enum ip_conntrack_dir {
IP_CT_DIR_ORIGINAL,
IP_CT_DIR_REPLY,
IP_CT_DIR_MAX
--
1.7.0.90.g251a4
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
drivers/isdn/hardware/eicon/os_4bri.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/hardware/eicon/os_4bri.h b/drivers/isdn/hardware/eicon/os_4bri.h
index 665f0af..7225327 100644
--- a/drivers/isdn/hardware/eicon/os_4bri.h
+++ b/drivers/isdn/hardware/eicon/os_4bri.h
@@ -3,6 +3,6 @@
#ifndef __DIVA_OS_4_BRI_H__
#define __DIVA_OS_4_BRI_H__
-int diva_4bri_init_card(diva_os_xdi_adapter_t * a);
+int diva_4bri_init_card(diva_os_xdi_adapter_t *a);
#endif
--
1.7.0.90.g251a4
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/um/include/asm/irq_vectors.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/um/include/asm/irq_vectors.h b/arch/um/include/asm/irq_vectors.h
index 272a81e..05cb834 100644
--- a/arch/um/include/asm/irq_vectors.h
+++ b/arch/um/include/asm/irq_vectors.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2002 Jeff Dike (jd...@karaya.com)
* Licensed under the GPL
*/
@@ -7,4 +7,3 @@
#define __UM_IRQ_VECTORS_H
#endif
-
--
1.7.0.90.g251a4
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/x86/kvm/kvm_timer.h | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kvm/kvm_timer.h b/arch/x86/kvm/kvm_timer.h
index 55c7524..64bc6ea 100644
--- a/arch/x86/kvm/kvm_timer.h
+++ b/arch/x86/kvm/kvm_timer.h
@@ -10,9 +10,7 @@ struct kvm_timer {
};
struct kvm_timer_ops {
- bool (*is_periodic)(struct kvm_timer *);
+ bool (*is_periodic)(struct kvm_timer *);
};
-
enum hrtimer_restart kvm_timer_fn(struct hrtimer *data);
-
--
1.7.0.90.g251a4
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
drivers/isdn/hardware/eicon/os_bri.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/hardware/eicon/os_bri.h b/drivers/isdn/hardware/eicon/os_bri.h
index a54f0ce..02e7456 100644
--- a/drivers/isdn/hardware/eicon/os_bri.h
+++ b/drivers/isdn/hardware/eicon/os_bri.h
@@ -3,6 +3,6 @@
#ifndef __DIVA_OS_BRI_REV_1_H__
#define __DIVA_OS_BRI_REV_1_H__
-int diva_bri_init_card(diva_os_xdi_adapter_t * a);
+int diva_bri_init_card(diva_os_xdi_adapter_t *a);
#endif
--
1.7.0.90.g251a4
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
include/asm-generic/kdebug.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/asm-generic/kdebug.h b/include/asm-generic/kdebug.h
index 11e57b6..832be39 100644
--- a/include/asm-generic/kdebug.h
+++ b/include/asm-generic/kdebug.h
@@ -3,7 +3,7 @@
enum die_val {
DIE_UNUSED,
- DIE_OOPS=1
+ DIE_OOPS = 1
};
#endif /* _ASM_GENERIC_KDEBUG_H */
--
1.7.0.90.g251a4
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/um/sys-i386/shared/sysdep/vm-flags.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/um/sys-i386/shared/sysdep/vm-flags.h b/arch/um/sys-i386/shared/sysdep/vm-flags.h
index e0d24c5..881afd7 100644
--- a/arch/um/sys-i386/shared/sysdep/vm-flags.h
+++ b/arch/um/sys-i386/shared/sysdep/vm-flags.h
@@ -8,7 +8,7 @@
#define VM_DATA_DEFAULT_FLAGS \
(VM_READ | VM_WRITE | \
- ((current->personality & READ_IMPLIES_EXEC) ? VM_EXEC : 0 ) | \
+ ((current->personality & READ_IMPLIES_EXEC) ? VM_EXEC : 0) | \
VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)
#endif
--
1.7.0.90.g251a4
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
fs/befs/inode.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/fs/befs/inode.h b/fs/befs/inode.h
index 9dc7fd9..1dcefba 100644
--- a/fs/befs/inode.h
+++ b/fs/befs/inode.h
@@ -1,8 +1,7 @@
/*
* inode.h
- *
+ *
*/
int befs_check_inode(struct super_block *sb, befs_inode * raw_inode,
befs_blocknr_t inode);
-
--
1.7.0.90.g251a4
Andrea Gelmini
arch/cris/include/asm/current.h:10: ERROR: code indent should use tabs where possible
arch/cris/include/asm/current.h:12: ERROR: trailing whitespace
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/cris/include/asm/current.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/cris/include/asm/current.h b/arch/cris/include/asm/current.h
index 5f5c0ef..e846834 100644
--- a/arch/cris/include/asm/current.h
+++ b/arch/cris/include/asm/current.h
@@ -5,11 +5,11 @@
struct task_struct;
-static inline struct task_struct * get_current(void)
+static inline struct task_struct *get_current(void)
{
- return current_thread_info()->task;
+ return current_thread_info()->task;
}
-
+
#define current get_current()
#endif /* !(_CRIS_CURRENT_H) */
--
1.7.0.90.g251a4
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/arm/mach-sa1100/include/mach/timex.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-sa1100/include/mach/timex.h b/arch/arm/mach-sa1100/include/mach/timex.h
index 7a5d017..7dc68ec 100644
--- a/arch/arm/mach-sa1100/include/mach/timex.h
+++ b/arch/arm/mach-sa1100/include/mach/timex.h
@@ -3,7 +3,7 @@
*
* SA1100 architecture timex specifications
*
- * Copyright (C) 1998
+ * Copyright (C) 1998
*/
/*
--
1.7.0.90.g251a4
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
drivers/md/linear.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/md/linear.h b/drivers/md/linear.h
index 0ce29b6..3860fd8 100644
--- a/drivers/md/linear.h
+++ b/drivers/md/linear.h
@@ -8,8 +8,7 @@ struct dev_info {
typedef struct dev_info dev_info_t;
-struct linear_private_data
-{
+struct linear_private_data {
sector_t array_sectors;
dev_info_t disks[0];
struct rcu_head rcu;
--
1.7.0.90.g251a4
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/um/sys-ia64/sysdep/ptrace.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/um/sys-ia64/sysdep/ptrace.h b/arch/um/sys-ia64/sysdep/ptrace.h
index 0f0f4e6..8e85f09 100644
--- a/arch/um/sys-ia64/sysdep/ptrace.h
+++ b/arch/um/sys-ia64/sysdep/ptrace.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2000 Jeff Dike (jd...@karaya.com)
* Licensed under the GPL
*/
@@ -13,4 +13,3 @@ struct sys_pt_regs {
#define EMPTY_REGS { 0 }
#endif
-
--
1.7.0.90.g251a4
Andrea Gelmini
arch/um/sys-ia64/sysdep/skas_ptrace.h:11: ERROR: code indent should use tabs where possible
arch/um/sys-ia64/sysdep/skas_ptrace.h:15: ERROR: code indent should use tabs where possible
arch/um/sys-ia64/sysdep/skas_ptrace.h:16: ERROR: code indent should use tabs where possible
arch/um/sys-ia64/sysdep/skas_ptrace.h:17: ERROR: code indent should use tabs where possible
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/um/sys-ia64/sysdep/skas_ptrace.h | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/um/sys-ia64/sysdep/skas_ptrace.h b/arch/um/sys-ia64/sysdep/skas_ptrace.h
index 25a38e7..b49be9e 100644
--- a/arch/um/sys-ia64/sysdep/skas_ptrace.h
+++ b/arch/um/sys-ia64/sysdep/skas_ptrace.h
@@ -7,14 +7,14 @@
#define __SYSDEP_IA64_SKAS_PTRACE_H
struct ptrace_faultinfo {
- int is_write;
- unsigned long addr;
+ int is_write;
+ unsigned long addr;
};
struct ptrace_ldt {
- int func;
- void *ptr;
- unsigned long bytecount;
+ int func;
+ void *ptr;
+ unsigned long bytecount;
};
#define PTRACE_LDT 54
--
1.7.0.90.g251a4
--
Andrea Gelmini
arch/h8300/include/asm/tlb.h:2: ERROR: trailing whitespace
arch/h8300/include/asm/tlb.h:10: ERROR: trailing whitespace
arch/h8300/include/asm/tlb.h:11: ERROR: trailing whitespace
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/h8300/include/asm/tlb.h | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/h8300/include/asm/tlb.h b/arch/h8300/include/asm/tlb.h
index 3dea80a..54e30d4 100644
--- a/arch/h8300/include/asm/tlb.h
+++ b/arch/h8300/include/asm/tlb.h
@@ -1,5 +1,5 @@
-/*
- include/asm-h8300/tlb.h
+/*
+ include/asm-h8300/tlb.h
*/
#ifndef __H8300_TLB_H__
@@ -7,8 +7,8 @@
#define tlb_flush(tlb) do { } while(0)
-/*
- include/asm-h8300/tlb.h
+/*
+ include/asm-h8300/tlb.h
*/
#ifndef __H8300_TLB_H__
--
1.7.0.90.g251a4
Andrea Gelmini
arch/cris/include/arch-v10/arch/thread_info.h:8: ERROR: spaces required around that ':' (ctx:VxV)
arch/cris/include/arch-v10/arch/thread_info.h:9: ERROR: code indent should use tabs where possible
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/cris/include/arch-v10/arch/thread_info.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/cris/include/arch-v10/arch/thread_info.h b/arch/cris/include/arch-v10/arch/thread_info.h
index 218f415..218ceb8 100644
--- a/arch/cris/include/arch-v10/arch/thread_info.h
+++ b/arch/cris/include/arch-v10/arch/thread_info.h
@@ -5,8 +5,8 @@
static inline struct thread_info *current_thread_info(void)
{
struct thread_info *ti;
- __asm__("and.d $sp,%0; ":"=r" (ti) : "0" (~8191UL));
- return ti;
+ __asm__("and.d $sp,%0; " : "=r" (ti) : "0" (~8191UL));
+ return ti;
}
#endif
--
1.7.0.90.g251a4
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
drivers/isdn/hardware/eicon/os_pri.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/hardware/eicon/os_pri.h b/drivers/isdn/hardware/eicon/os_pri.h
index a7c42f9..537c74d 100644
--- a/drivers/isdn/hardware/eicon/os_pri.h
+++ b/drivers/isdn/hardware/eicon/os_pri.h
@@ -3,6 +3,6 @@
#ifndef __DIVA_OS_PRI_REV_1_H__
#define __DIVA_OS_PRI_REV_1_H__
-int diva_pri_init_card(diva_os_xdi_adapter_t * a);
+int diva_pri_init_card(diva_os_xdi_adapter_t *a);
#endif
--
1.7.0.90.g251a4
Andrea Gelmini
arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h:11: ERROR: code indent should use tabs where possible
arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h:15: ERROR: code indent should use tabs where possible
arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h:16: ERROR: code indent should use tabs where possible
arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h:17: ERROR: code indent should use tabs where possible
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h b/arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h
index 95db4be..40fa1cb 100644
--- a/arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h
+++ b/arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h
@@ -7,14 +7,14 @@
#define __SYSDEP_X86_64_SKAS_PTRACE_H
struct ptrace_faultinfo {
- int is_write;
- unsigned long addr;
+ int is_write;
+ unsigned long addr;
};
struct ptrace_ldt {
- int func;
- void *ptr;
- unsigned long bytecount;
+ int func;
+ void *ptr;
+ unsigned long bytecount;
};
#define PTRACE_LDT 54
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/um/drivers/ssl.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/um/drivers/ssl.h b/arch/um/drivers/ssl.h
index 314d177..de82843 100644
--- a/arch/um/drivers/ssl.h
+++ b/arch/um/drivers/ssl.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2000 Jeff Dike (jd...@karaya.com)
* Licensed under the GPL
*/
@@ -10,4 +10,3 @@ extern int ssl_read(int fd, int line);
extern void ssl_receive_char(int line, char ch);
#endif
-
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/um/include/shared/sysrq.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/um/include/shared/sysrq.h b/arch/um/include/shared/sysrq.h
index c8d332b..19181a9 100644
--- a/arch/um/include/shared/sysrq.h
+++ b/arch/um/include/shared/sysrq.h
@@ -2,6 +2,6 @@
#define __UM_SYSRQ_H
struct task_struct;
-extern void show_trace(struct task_struct* task, unsigned long *stack);
+extern void show_trace(struct task_struct *task, unsigned long *stack);
#endif
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/mips/lib/libgcc.h | 3 +--
arch/sh/lib/libgcc.h | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/mips/lib/libgcc.h b/arch/mips/lib/libgcc.h
index 3f19d1c..05909d5 100644
--- a/arch/mips/lib/libgcc.h
+++ b/arch/mips/lib/libgcc.h
@@ -17,8 +17,7 @@ struct DWstruct {
#error I feel sick.
#endif
-typedef union
-{
+typedef union {
struct DWstruct s;
long long ll;
} DWunion;
diff --git a/arch/sh/lib/libgcc.h b/arch/sh/lib/libgcc.h
index 3f19d1c..05909d5 100644
--- a/arch/sh/lib/libgcc.h
+++ b/arch/sh/lib/libgcc.h
@@ -17,8 +17,7 @@ struct DWstruct {
#error I feel sick.
#endif
-typedef union
-{
+typedef union {
struct DWstruct s;
long long ll;
} DWunion;
Andrea Gelmini
include/linux/raw.h:6: ERROR: space prohibited before that close parenthesis ')'
include/linux/raw.h:7: ERROR: space prohibited after that open parenthesis '('
include/linux/raw.h:7: ERROR: space prohibited before that close parenthesis ')'
include/linux/raw.h:9: ERROR: trailing whitespace
include/linux/raw.h:10: ERROR: open brace '{' following struct go on the same line
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
include/linux/raw.h | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/include/linux/raw.h b/include/linux/raw.h
index 62d543e..01d635b 100644
--- a/include/linux/raw.h
+++ b/include/linux/raw.h
@@ -3,11 +3,10 @@
#include <linux/types.h>
-#define RAW_SETBIND _IO( 0xac, 0 )
-#define RAW_GETBIND _IO( 0xac, 1 )
+#define RAW_SETBIND _IO(0xac, 0)
+#define RAW_GETBIND _IO(0xac, 1)
-struct raw_config_request
-{
+struct raw_config_request {
int raw_minor;
__u64 block_major;
__u64 block_minor;
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
include/net/x25device.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/net/x25device.h b/include/net/x25device.h
index 1415bcf..246a17b 100644
--- a/include/net/x25device.h
+++ b/include/net/x25device.h
@@ -10,7 +10,7 @@ static inline __be16 x25_type_trans(struct sk_buff *skb, struct net_device *dev)
skb->dev = dev;
skb_reset_mac_header(skb);
skb->pkt_type = PACKET_HOST;
-
+
return htons(ETH_P_X25);
}
#endif
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/um/include/shared/ubd_user.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/um/include/shared/ubd_user.h b/arch/um/include/shared/ubd_user.h
index 3845051..9198fa3 100644
--- a/arch/um/include/shared/ubd_user.h
+++ b/arch/um/include/shared/ubd_user.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2000 Jeff Dike (jd...@karaya.com)
* Copyright (C) 2001 RidgeRun, Inc (glo...@ridgerun.com)
* Licensed under the GPL
@@ -13,4 +13,3 @@ extern int io_thread(void *arg);
extern int kernel_fd;
#endif
-
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/cris/include/arch-v10/arch/pgtable.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/cris/include/arch-v10/arch/pgtable.h b/arch/cris/include/arch-v10/arch/pgtable.h
index 2a2576d..1975118 100644
--- a/arch/cris/include/arch-v10/arch/pgtable.h
+++ b/arch/cris/include/arch-v10/arch/pgtable.h
@@ -2,7 +2,7 @@
#define _CRIS_ARCH_PGTABLE_H
/*
- * Kernels own virtual memory area.
+ * Kernels own virtual memory area.
*/
#ifdef CONFIG_CRIS_LOW_MAP
@@ -14,4 +14,3 @@
#endif
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/cris/include/asm/unaligned.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/cris/include/asm/unaligned.h b/arch/cris/include/asm/unaligned.h
index 7b3f3fe..b0fc89d 100644
--- a/arch/cris/include/asm/unaligned.h
+++ b/arch/cris/include/asm/unaligned.h
@@ -2,7 +2,7 @@
#define _ASM_CRIS_UNALIGNED_H
/*
- * CRIS can do unaligned accesses itself.
+ * CRIS can do unaligned accesses itself.
*/
#include <linux/unaligned/access_ok.h>
#include <linux/unaligned/generic.h>
Andrea Gelmini
include/linux/tc_act/tc_ipt.h:19: ERROR: code indent should use tabs where possible
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
include/linux/tc_act/tc_ipt.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/include/linux/tc_act/tc_ipt.h b/include/linux/tc_act/tc_ipt.h
index a233556..1140188 100644
--- a/include/linux/tc_act/tc_ipt.h
+++ b/include/linux/tc_act/tc_ipt.h
@@ -16,5 +16,4 @@ enum {
__TCA_IPT_MAX
};
#define TCA_IPT_MAX (__TCA_IPT_MAX - 1)
-
#endif
Andrea Gelmini
drivers/isdn/i4l/isdn_concap.h:11: ERROR: "foo * bar" should be "foo *bar"
drivers/isdn/i4l/isdn_concap.h:11: ERROR: space prohibited after that open parenthesis '('
drivers/isdn/i4l/isdn_concap.h:11: ERROR: space prohibited before that close parenthesis ')'
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
drivers/isdn/i4l/isdn_concap.h | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/isdn/i4l/isdn_concap.h b/drivers/isdn/i4l/isdn_concap.h
index 6ac7e04..cd7e3ba 100644
--- a/drivers/isdn/i4l/isdn_concap.h
+++ b/drivers/isdn/i4l/isdn_concap.h
@@ -8,6 +8,4 @@
*/
extern struct concap_device_ops isdn_concap_reliable_dl_dops;
-extern struct concap_proto * isdn_concap_new( int );
-
-
+extern struct concap_proto *isdn_concap_new(int);
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/um/os-Linux/sys-x86_64/prctl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/um/os-Linux/sys-x86_64/prctl.c b/arch/um/os-Linux/sys-x86_64/prctl.c
index 9d34edd..79c278a 100644
--- a/arch/um/os-Linux/sys-x86_64/prctl.c
+++ b/arch/um/os-Linux/sys-x86_64/prctl.c
@@ -8,5 +8,5 @@
int os_arch_prctl(int pid, int code, unsigned long *addr)
{
- return ptrace(PTRACE_ARCH_PRCTL, pid, (unsigned long) addr, code);
+ return ptrace(PTRACE_ARCH_PRCTL, pid, (unsigned long) addr, code);
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
include/linux/uts.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/uts.h b/include/linux/uts.h
index 73eb1ed..2ad5582 100644
--- a/include/linux/uts.h
+++ b/include/linux/uts.h
@@ -2,7 +2,7 @@
#define _LINUX_UTS_H
/*
- * Defines for what uname() should return
+ * Defines for what uname() should return
*/
#ifndef UTS_SYSNAME
#define UTS_SYSNAME "Linux"
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/um/sys-i386/asm/archparam.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/um/sys-i386/asm/archparam.h b/arch/um/sys-i386/asm/archparam.h
index 2a18a88..32f7253 100644
--- a/arch/um/sys-i386/asm/archparam.h
+++ b/arch/um/sys-i386/asm/archparam.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2000 - 2003 Jeff Dike (jd...@addtoit.com)
* Licensed under the GPL
*/
@@ -13,4 +13,3 @@
#endif
#endif
-
Andrea Gelmini
include/linux/tc_act/tc_defact.h:9: ERROR: code indent should use tabs where possible
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
include/linux/tc_act/tc_defact.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/tc_act/tc_defact.h b/include/linux/tc_act/tc_defact.h
index 6f65d07..17dddb4 100644
--- a/include/linux/tc_act/tc_defact.h
+++ b/include/linux/tc_act/tc_defact.h
@@ -6,7 +6,7 @@
struct tc_defact {
tc_gen;
};
-
+
enum {
TCA_DEF_UNSPEC,
TCA_DEF_TM,
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/um/sys-ia64/sysdep/syscalls.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/um/sys-ia64/sysdep/syscalls.h b/arch/um/sys-ia64/sysdep/syscalls.h
index 5f6700c..e6f6994 100644
--- a/arch/um/sys-ia64/sysdep/syscalls.h
+++ b/arch/um/sys-ia64/sysdep/syscalls.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2000 Jeff Dike (jd...@karaya.com)
* Licensed under the GPL
*/
Andrea Gelmini
arch/h8300/include/asm/md.h:5: ERROR: trailing whitespace
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/h8300/include/asm/md.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/h8300/include/asm/md.h b/arch/h8300/include/asm/md.h
index 1b7300e..d2f78f2 100644
--- a/arch/h8300/include/asm/md.h
+++ b/arch/h8300/include/asm/md.h
@@ -1,8 +1,8 @@
/*
- * md.h: High speed xor_block operation for RAID4/5
+ * md.h: High speed xor_block operation for RAID4/5
*
*/
-
+
#ifndef __ASM_MD_H
#define __ASM_MD_H
Andrea Gelmini
arch/h8300/include/asm/target_time.h:4: ERROR: code indent should use tabs where possible
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/h8300/include/asm/target_time.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/h8300/include/asm/target_time.h b/arch/h8300/include/asm/target_time.h
index 9f2a9aa..043d9a0 100644
--- a/arch/h8300/include/asm/target_time.h
+++ b/arch/h8300/include/asm/target_time.h
@@ -1,4 +1,4 @@
extern int platform_timer_setup(void (*timer_int)(int, void *, struct pt_regs *));
extern void platform_timer_eoi(void);
-extern void platform_gettod(unsigned int *year, unsigned int *mon, unsigned int *day,
- unsigned int *hour, unsigned int *min, unsigned int *sec);
+extern void platform_gettod(unsigned int *year, unsigned int *mon, unsigned int *day,
+ unsigned int *hour, unsigned int *min, unsigned int *sec);
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/um/include/shared/irq_kern.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/um/include/shared/irq_kern.h b/arch/um/include/shared/irq_kern.h
index b05d22f..f5855e1 100644
--- a/arch/um/include/shared/irq_kern.h
+++ b/arch/um/include/shared/irq_kern.h
@@ -11,8 +11,7 @@
extern int um_request_irq(unsigned int irq, int fd, int type,
irq_handler_t handler,
- unsigned long irqflags, const char * devname,
+ unsigned long irqflags, const char *devname,
void *dev_id);
#endif
-
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/um/include/shared/sigio.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/um/include/shared/sigio.h b/arch/um/include/shared/sigio.h
index 434f1a9..8af4c67 100644
--- a/arch/um/include/shared/sigio.h
+++ b/arch/um/include/shared/sigio.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2002 Jeff Dike (jd...@karaya.com)
* Licensed under the GPL
*/
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/powerpc/sysdev/cpm2_pic.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/sysdev/cpm2_pic.h b/arch/powerpc/sysdev/cpm2_pic.h
index 30e5828..2c5f70c 100644
--- a/arch/powerpc/sysdev/cpm2_pic.h
+++ b/arch/powerpc/sysdev/cpm2_pic.h
@@ -3,6 +3,6 @@
extern unsigned int cpm2_get_irq(void);
-extern void cpm2_pic_init(struct device_node*);
+extern void cpm2_pic_init(struct device_node *);
#endif /* _PPC_KERNEL_CPM2_H */
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/arm/plat-omap/include/plat/blizzard.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-omap/include/plat/blizzard.h b/arch/arm/plat-omap/include/plat/blizzard.h
index 8d160f1..56e7f2e 100644
--- a/arch/arm/plat-omap/include/plat/blizzard.h
+++ b/arch/arm/plat-omap/include/plat/blizzard.h
@@ -6,7 +6,7 @@ struct blizzard_platform_data {
void (*power_down)(struct device *dev);
unsigned long (*get_clock_rate)(struct device *dev);
- unsigned te_connected : 1;
+ unsigned te_connected:1;
};
#endif
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
sound/usb/caiaq/midi.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/usb/caiaq/midi.h b/sound/usb/caiaq/midi.h
index 9d16db0..380f984 100644
--- a/sound/usb/caiaq/midi.h
+++ b/sound/usb/caiaq/midi.h
@@ -3,6 +3,6 @@
int snd_usb_caiaq_midi_init(struct snd_usb_caiaqdev *dev);
void snd_usb_caiaq_midi_handle_input(struct snd_usb_caiaqdev *dev, int port, const char *buf, int len);
-void snd_usb_caiaq_midi_output_done(struct urb* urb);
+void snd_usb_caiaq_midi_output_done(struct urb *urb);
#endif /* CAIAQ_MIDI_H */
Andrea Gelmini
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
drivers/s390/cio/blacklist.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/s390/cio/blacklist.h b/drivers/s390/cio/blacklist.h
index 95e25c1..4a78e64 100644
--- a/drivers/s390/cio/blacklist.h
+++ b/drivers/s390/cio/blacklist.h
@@ -1,6 +1,6 @@
#ifndef S390_BLACKLIST_H
#define S390_BLACKLIST_H
-extern int is_blacklisted (int ssid, int devno);
+extern int is_blacklisted(int ssid, int devno);
#endif
Andrea Gelmini
arch/cris/include/asm/irq.h:8: ERROR: trailing whitespace
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/cris/include/asm/irq.h | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/cris/include/asm/irq.h b/arch/cris/include/asm/irq.h
index ce0fcf5..9e9f231 100644
--- a/arch/cris/include/asm/irq.h
+++ b/arch/cris/include/asm/irq.h
@@ -4,10 +4,8 @@
#include <arch/irq.h>
static inline int irq_canonicalize(int irq)
-{
- return irq;
+{
+ return irq;
}
#endif /* _ASM_IRQ_H */
-
-
Andrea Gelmini
arch/parisc/include/asm/parport.h:11: WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
---
arch/parisc/include/asm/parport.h | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/parisc/include/asm/parport.h b/arch/parisc/include/asm/parport.h
index 00d9cc3..5cbf98b 100644
--- a/arch/parisc/include/asm/parport.h
+++ b/arch/parisc/include/asm/parport.h
@@ -1,4 +1,4 @@
-/*
+/*
*
* parport.h: ia32-compatible parport initialisation
*
@@ -8,8 +8,7 @@
#define _ASM_PARPORT_H 1
-static int __devinit parport_pc_find_nonpci_ports (int autoirq, int autodma)
-{
+static int __devinit parport_pc_find_nonpci_ports (int autoirq, int autodma) {
/* nothing ! */
return 0;
Jeff Dike
> arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h:10: ERROR: code indent should use tabs where possible
> arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h:11: ERROR: code indent should use tabs where possible
Don't you have anything better to do with your time?
Jeff
Thibaut VARENE
<andrea....@gelma.net> wrote:
> arch/parisc/include/asm/parport.h:1: ERROR: trailing whitespace
> arch/parisc/include/asm/parport.h:11: WARNING: space prohibited between function name and open parenthesis '('
>
> Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
> ---
> arch/parisc/include/asm/parport.h | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/parisc/include/asm/parport.h b/arch/parisc/include/asm/parport.h
> index 00d9cc3..5cbf98b 100644
> --- a/arch/parisc/include/asm/parport.h
> +++ b/arch/parisc/include/asm/parport.h
> @@ -8,8 +8,7 @@
> #define _ASM_PARPORT_H 1
>
>
> -static int __devinit parport_pc_find_nonpci_ports (int autoirq, int autodma)
> -{
> +static int __devinit parport_pc_find_nonpci_ports (int autoirq, int autodma) {
This looks very much in contradiction with CodingStyle, since
parport_pc_find_nonpci_ports() is a function, and it's not a fix for
the quoted "WARNING". I'm guessing this wasn't intended the way it is.
HTH
T-Bone
--
Thibaut VARENE
http://www.parisc-linux.org/~varenet/
Neil Brown
Andrea Gelmini <andrea....@gelma.net> wrote:
> drivers/md/linear.h:12: ERROR: open brace '{' following struct go on the same line
Thanks, but no thanks.
This just doesn't need cleaning up.
NeilBrown
>
> Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
> ---
> drivers/md/linear.h | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/md/linear.h b/drivers/md/linear.h
> index 0ce29b6..3860fd8 100644
> --- a/drivers/md/linear.h
> +++ b/drivers/md/linear.h
> @@ -8,8 +8,7 @@ struct dev_info {
>
> typedef struct dev_info dev_info_t;
>
> -struct linear_private_data
> -{
> +struct linear_private_data {
> sector_t array_sectors;
> dev_info_t disks[0];
> struct rcu_head rcu;
David Miller
Date: Sat, 27 Feb 2010 17:51:08 +0100
> include/linux/raw.h:6: ERROR: space prohibited after that open parenthesis '('
> include/linux/raw.h:6: ERROR: space prohibited before that close parenthesis ')'
> include/linux/raw.h:7: ERROR: space prohibited after that open parenthesis '('
> include/linux/raw.h:7: ERROR: space prohibited before that close parenthesis ')'
> include/linux/raw.h:9: ERROR: trailing whitespace
> include/linux/raw.h:10: ERROR: open brace '{' following struct go on the same line
>
> Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
Acked-by: David S. Miller <da...@davemloft.net>
David Miller
Date: Sat, 27 Feb 2010 17:51:27 +0100
> drivers/isdn/hardware/eicon/os_bri.h:6: ERROR: "foo * bar" should be "foo *bar"
David Miller
Date: Sat, 27 Feb 2010 17:51:18 +0100
> include/linux/tc_act/tc_ipt.h:19: ERROR: trailing whitespace
> include/linux/tc_act/tc_ipt.h:19: ERROR: code indent should use tabs where possible
>
> Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
Acked-by: David S. Miller <da...@davemloft.net>
David Miller
Date: Sat, 27 Feb 2010 17:51:12 +0100
> include/linux/tc_act/tc_defact.h:9: ERROR: trailing whitespace
> include/linux/tc_act/tc_defact.h:9: ERROR: code indent should use tabs where possible
>
> Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
Acked-by: David S. Miller <da...@davemloft.net>
David Miller
Date: Sat, 27 Feb 2010 17:51:32 +0100
> drivers/isdn/i4l/isdn_concap.h:1: WARNING: CVS style keyword markers, these will _not_ be updated
> drivers/isdn/i4l/isdn_concap.h:11: ERROR: "foo * bar" should be "foo *bar"
> drivers/isdn/i4l/isdn_concap.h:11: ERROR: space prohibited after that open parenthesis '('
> drivers/isdn/i4l/isdn_concap.h:11: ERROR: space prohibited before that close parenthesis ')'
>
> Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
Acked-by: David S. Miller <da...@davemloft.net>
David Miller
Date: Sat, 27 Feb 2010 17:51:28 +0100
> drivers/isdn/hardware/eicon/os_pri.h:6: ERROR: "foo * bar" should be "foo *bar"
David Miller
Date: Sat, 27 Feb 2010 17:51:21 +0100
> include/linux/netfilter/nf_conntrack_tuple_common.h:5: ERROR: open brace '{' following enum go on the same line
David Miller
Date: Sat, 27 Feb 2010 17:51:11 +0100
> include/net/x25device.h:13: ERROR: trailing whitespace
David Miller
Date: Sat, 27 Feb 2010 17:51:26 +0100
> drivers/isdn/hardware/eicon/os_4bri.h:6: ERROR: "foo * bar" should be "foo *bar"
Daniel Mack
> sound/usb/caiaq/midi.h:6: ERROR: "foo* bar" should be "foo *bar"
>
> Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
Acked-by: Daniel Mack <dan...@caiaq.de>
Andrea Gelmini
Hi Thubaut,
thanks a lot for you answer.
> This looks very much in contradiction with CodingStyle, since
> parport_pc_find_nonpci_ports() is a function, and it's not a fix for
> the quoted "WARNING". I'm guessing this wasn't intended the way it is.
My fault. I'll look at checkpatch.pl regexp to resolve false positive
(I've found a few other regressions).
Thanks again,
Andrea
Andrea Gelmini
Hi Jeff,
and thanks for your reply.
> Don't you have anything better to do with your time?
It's a dirty job, but somebody has to do it...
Enlighted by Greg's talk at FOSDEM¹ I sent him some patches (nothing
more than boring things for a real programmer, but a good solitaire
alternative for a rookie like me).
These patches are just a try to see if there are other subtree
maintainers interested in stuff like this.
Ciao,
Andrea
----------------------------
¹ http://bit.ly/9d3Ql3
Jeff Dike
> 2010/2/27 Jeff Dike <jd...@addtoit.com>:
> Hi Jeff,
> and thanks for your reply.
>
> > Don't you have anything better to do with your time?
>
> It's a dirty job, but somebody has to do it...
To be a bit more serious, the UML tree was once a seething mass of
checkpatch violations. I cleaned up a lot of it while making other
changes in the area. This sort of thing I think is reasonably
worthwhile, but dumping in a whole lot of checkpatch changes doesn't
help anything and it just pollutes the change history.
Jeff
Al Viro
> Hi Jeff,
> and thanks for your reply.
>
> > Don't you have anything better to do with your time?
>
> It's a dirty job, but somebody has to do it...
> more than boring things for a real programmer, but a good solitaire
> alternative for a rookie like me).
>
> These patches are just a try to see if there are other subtree
> maintainers interested in stuff like this.
Note to gregkh: the next time you give a talk like that, consider including
"spamming l-k with sixty-odd solitaire sessions^W^Wwhitespace-removal patches
can lead to considerable annoyance"...
andrew hendry
Paul Mundt
> arch/mips/lib/libgcc.h:21: ERROR: open brace '{' following union go on the same line
>
> Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
> ---
> arch/mips/lib/libgcc.h | 3 +--
> arch/sh/lib/libgcc.h | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
I'll apply the sh part by itself, and I suppose Ralf will do the same for
MIPS. I'm a bit confused as to why these were lumped together when 65 out
of 66 oneliner patches made no use of ad-hoc grouping.
Greg KH
> On Sun, Feb 28, 2010 at 03:06:21PM +0100, Andrea Gelmini wrote:
> > 2010/2/27 Jeff Dike <jd...@addtoit.com>:
> > Hi Jeff,
> > and thanks for your reply.
> >
> > > Don't you have anything better to do with your time?
> >
> > It's a dirty job, but somebody has to do it...
> > Enlighted by Greg's talk at FOSDEM?? I sent him some patches (nothing
> > more than boring things for a real programmer, but a good solitaire
> > alternative for a rookie like me).
> >
> > These patches are just a try to see if there are other subtree
> > maintainers interested in stuff like this.
>
> Note to gregkh: the next time you give a talk like that, consider including
> "spamming l-k with sixty-odd solitaire sessions^W^Wwhitespace-removal patches
> can lead to considerable annoyance"...
Heh, I did explicitly state that this should be done on the staging
tree only. This developer took it apon themselves to try a different
subsystem, which is fine, why would we want to turn away free help :)
thanks,
greg k-h
Marcelo Tosatti
> arch/x86/kvm/kvm_timer.h:13: ERROR: code indent should use tabs where possible> arch/x86/kvm/kvm_timer.h | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
Applied, thanks.
Andrea Gelmini
Hi Paul,
thanks for your reply.
> I'll apply the sh part by itself, and I suppose Ralf will do the same for
> MIPS. I'm a bit confused as to why these were lumped together when 65 out
> of 66 oneliner patches made no use of ad-hoc grouping.
After the experience with GregKH, I was looking for others maintainer
interested in code cleanup. So I sent some patches over random files.
If you care, I can checkpatch.pl all mips subtree and send you patches (if any).
Thanks a lot for your work,
Andrea
Andrea Gelmini
Hi Jeff,
and thanks for your reply.
> checkpatch violations. I cleaned up a lot of it while making other
> changes in the area. This sort of thing I think is reasonably
> worthwhile, but dumping in a whole lot of checkpatch changes doesn't
> help anything and it just pollutes the change history.
Yep, I talked about side effects (i.e git-blame) with Alessandro (Rubini).
If you think it could be useuful I can check all the subtree. Send
you patches (if any).
You can merge piece of them as soon as you modify files with real
patches, so you
don't have to do the boring business. I don't care to have credits
about 'em, and it's not
a problem if you will not use them.
Thanks a lot,
Andrea
Andrea Gelmini
Hi Viro,
thanks a lot for your reply.
> Note to gregkh: the next time you give a talk like that, consider including
> "spamming l-k with sixty-odd solitaire sessions^W^Wwhitespace-removal patches
> can lead to considerable annoyance"...
As you can see in the video, Greg talked about - just and only -
Staging Drivers.
It's all my fault if someone is bored with my patches.
Thanks a lot for your work,
Andrea
Andrea Gelmini
Hi Marcelo,
thanks a lot for your reply.
> Applied, thanks.
Thanks a lot.
If you care I can check all the KVM files.
Thanks again,
Andrea
Kumar Gala
On Feb 27, 2010, at 10:51 AM, Andrea Gelmini wrote:
> arch/powerpc/sysdev/cpm2_pic.h:6: ERROR: "(foo*)" should be "(foo *)"
>
> Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
> ---
> arch/powerpc/sysdev/cpm2_pic.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
applied to next
- k
Patrick McHardy
> From: Andrea Gelmini <andrea....@gelma.net>
> Date: Sat, 27 Feb 2010 17:51:21 +0100
>
>> include/linux/netfilter/nf_conntrack_tuple_common.h:5: ERROR: open brace '{' following enum go on the same line
>>
>> Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
>
> Acked-by: David S. Miller <da...@davemloft.net>
>
Applied, thanks.
Ralf Baechle
> From: Andrea Gelmini <andrea....@gelma.net>
> To: linux-...@vger.kernel.org
> Cc: Andrea Gelmini <andrea....@gelma.net>,
> Ralf Baechle <ra...@linux-mips.org>,
> Paul Mundt <let...@linux-sh.org>, linux...@linux-mips.org,
> linu...@vger.kernel.org
> Subject: [PATCH 42/66] arch/mips/lib/libgcc.h: Checkpatch cleanup
>
> arch/mips/lib/libgcc.h:21: ERROR: open brace '{' following union go on the same line
>
> Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
> ---
> arch/mips/lib/libgcc.h | 3 +--
> arch/sh/lib/libgcc.h | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
I've applied the MIPS portion of the patch, thanks.
Ralf
Ralf Baechle
> 2010/3/1 Paul Mundt <let...@linux-sh.org>:
> Hi Paul,
> thanks for your reply.
>
> > I'll apply the sh part by itself, and I suppose Ralf will do the same for
> > MIPS. I'm a bit confused as to why these were lumped together when 65 out
> > of 66 oneliner patches made no use of ad-hoc grouping.
>
> After the experience with GregKH, I was looking for others maintainer
> interested in code cleanup. So I sent some patches over random files.
> If you care, I can checkpatch.pl all mips subtree and send you patches (if any).
Feel free to - but remember that the coding style document is a guideline
not something to be followed unconditionally.
Ralf
Artem Bityutskiy
> include/linux/mtd/mtdram.h:6: ERROR: code indent should use tabs where possible
>
> Signed-off-by: Andrea Gelmini <andrea....@gelma.net>
Pushed to l2-mtd-2.6.git / master
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)