Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

Re: cxgb4i submission

1 view
Skip to first unread message

David Miller

unread,
Apr 8, 2010, 8:20:02 AM4/8/10
to
From: Rakesh Ranjan <rak...@chelsio.com>
Date: Thu, 8 Apr 2010 17:44:12 +0530

> This driver depends upon cxgb4 driver, posted recently on netdev and
> now part of net-next repo.

It went into the net-2.6 repo, not net-next-2.6

And it is even in Linus's tree now.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Rakesh Ranjan

unread,
Apr 8, 2010, 8:50:01 AM4/8/10
to
On 04/08/2010 05:48 PM, David Miller wrote:
> From: Rakesh Ranjan <rak...@chelsio.com>
> Date: Thu, 8 Apr 2010 17:44:12 +0530
>
>> This driver depends upon cxgb4 driver, posted recently on netdev and
>> now part of net-next repo.
>
> It went into the net-2.6 repo, not net-next-2.6
>
> And it is even in Linus's tree now.

Hi Dave,

Thanks for updates, somehow I missed that part.

Regards
Rakesh Ranjan


signature.asc

Mike Christie

unread,
Apr 8, 2010, 3:20:02 PM4/8/10
to
On 04/08/2010 07:14 AM, Rakesh Ranjan wrote:
> From: Rakesh Ranjan<rak...@chelsio.com>
>
>
> Signed-off-by: Rakesh Ranjan<rak...@chelsio.com>
> ---
> drivers/scsi/cxgb4i/cxgb4i_iscsi.c | 715 ++++++++++++++++++++++++++++++++++++
> drivers/scsi/cxgb4i/cxgb4i_pdu.c | 475 ++++++++++++++++++++++++
> drivers/scsi/cxgb4i/cxgb4i_pdu.h | 61 +++
> 3 files changed, 1251 insertions(+), 0 deletions(-)
> create mode 100644 drivers/scsi/cxgb4i/cxgb4i_iscsi.c
> create mode 100644 drivers/scsi/cxgb4i/cxgb4i_pdu.c
> create mode 100644 drivers/scsi/cxgb4i/cxgb4i_pdu.h
>

The code in these files looks like the code is the cxgb3i iscsi and pdu
code. Can you just make a common cxgb3i iscsi/pdu layer and add some
callouts?

Something similar to what qla2xxx or lpfc has done to support multiple
cards. In their case they have common fc and driver stuff and then
callouts for hw specifics?

Mike Christie

unread,
Apr 13, 2010, 4:50:02 PM4/13/10
to
On 04/08/2010 07:14 AM, Rakesh Ranjan wrote:
> +static inline int cxgb4i_ddp_gl_map(struct pci_dev *pdev,
> + struct cxgb4i_gather_list *gl)
> +{
> + int i;
> +
> + for (i = 0; i< gl->nelem; i++) {
> + gl->phys_addr[i] = pci_map_page(pdev, gl->pages[i], 0,
> + PAGE_SIZE,

Hey Rakesh,

I guess we are trying to move away from the pci mapping functions move
to the dma ones. On your next submission, could you fix those up too?

Karen Xie

unread,
Apr 13, 2010, 5:50:02 PM4/13/10
to
Hi, Mike,

Yes, will do that for the next submission.

Thanks,
Karen

0 new messages