Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] leds: s3c24xx: Fix build failure

6 views
Skip to first unread message

Tushar Behera

unread,
Dec 30, 2013, 9:20:02 AM12/30/13
to
Fixes following build error.
drivers/leds/leds-s3c24xx.c: In function ‘s3c24xx_led_probe’:
drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
function ‘s3c_gpio_setpull’ [-Werror=implicit-function-declaration]

Signed-off-by: Tushar Behera <tushar...@linaro.org>
---
Tested at next-20131224.

drivers/leds/leds-s3c24xx.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/leds/leds-s3c24xx.c b/drivers/leds/leds-s3c24xx.c
index 76483fb..87cf215 100644
--- a/drivers/leds/leds-s3c24xx.c
+++ b/drivers/leds/leds-s3c24xx.c
@@ -21,6 +21,7 @@

#include <mach/hardware.h>
#include <mach/regs-gpio.h>
+#include <plat/gpio-cfg.h>
#include <linux/platform_data/leds-s3c24xx.h>

/* our context */
--
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Bryan Wu

unread,
Jan 2, 2014, 10:50:02 PM1/2/14
to
On Mon, Dec 30, 2013 at 1:09 AM, Tushar Behera <tushar...@linaro.org> wrote:
> Fixes following build error.
> drivers/leds/leds-s3c24xx.c: In function �s3c24xx_led_probe�:
> drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
> function �s3c_gpio_setpull� [-Werror=implicit-function-declaration]
>

I don't see any building error with s3c2410_defconfig. Actually this
<plat/gpio-cfg.h> is included in
arch/arm/mach-s3c24xx/include/mach/gpio.h which is in
arch/arm/include/asm/gpio.h, then <linux/gpio.h>

Thanks,
-Bryan

Tushar Behera

unread,
Jan 3, 2014, 5:10:01 AM1/3/14
to
On 3 January 2014 04:12, Bryan Wu <cool...@gmail.com> wrote:
> On Mon, Dec 30, 2013 at 1:09 AM, Tushar Behera <tushar...@linaro.org> wrote:
>> Fixes following build error.
>> drivers/leds/leds-s3c24xx.c: In function ‘s3c24xx_led_probe’:
>> drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
>> function ‘s3c_gpio_setpull’ [-Werror=implicit-function-declaration]
>>
>
> I don't see any building error with s3c2410_defconfig. Actually this
> <plat/gpio-cfg.h> is included in
> arch/arm/mach-s3c24xx/include/mach/gpio.h which is in
> arch/arm/include/asm/gpio.h, then <linux/gpio.h>
>

This requires that CONFIG_NEED_MACH_GPIO_H is defined. Following
commit has removed this option for s3c24xx platform.

c67d0f29262b ("ARM: s3c24xx: get rid of custom <mach/gpio.h>").

--
Tushar Behera

Tushar Behera

unread,
Jan 3, 2014, 5:40:01 AM1/3/14
to
Commit c67d0f29262b ("ARM: s3c24xx: get rid of custom <mach/gpio.h>")
removed the usage of mach/gpio.h file, but we need to include
plat/gpio-cfg.h to avoid following build error.

Fixes following build error.
drivers/leds/leds-s3c24xx.c: In function ‘s3c24xx_led_probe’:
drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
function ‘s3c_gpio_setpull’ [-Werror=implicit-function-declaration]

Signed-off-by: Tushar Behera <tushar...@linaro.org>
---
Changes for V2:
* Updated commit message

Bryan,

I should have been more explicit regarding this patch. This patch fixes
build error on linux-next after the above patch was merged.

Bryan Wu

unread,
Jan 3, 2014, 6:30:02 AM1/3/14
to
On Thu, Jan 2, 2014 at 9:25 PM, Tushar Behera <tushar...@linaro.org> wrote:
> Commit c67d0f29262b ("ARM: s3c24xx: get rid of custom <mach/gpio.h>")
> removed the usage of mach/gpio.h file, but we need to include
> plat/gpio-cfg.h to avoid following build error.
>
> Fixes following build error.
> drivers/leds/leds-s3c24xx.c: In function �s3c24xx_led_probe�:
> drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
> function �s3c_gpio_setpull� [-Werror=implicit-function-declaration]
>

I think this patch should go with Linus's patchset.

-Bryan

Linus Walleij

unread,
Jan 7, 2014, 5:50:01 PM1/7/14
to
On Fri, Jan 3, 2014 at 7:19 AM, Bryan Wu <cool...@gmail.com> wrote:
> On Thu, Jan 2, 2014 at 9:25 PM, Tushar Behera <tushar...@linaro.org> wrote:
>> Commit c67d0f29262b ("ARM: s3c24xx: get rid of custom <mach/gpio.h>")
>> removed the usage of mach/gpio.h file, but we need to include
>> plat/gpio-cfg.h to avoid following build error.
>>
>> Fixes following build error.
>> drivers/leds/leds-s3c24xx.c: In function �s3c24xx_led_probe�:
>> drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
>> function �s3c_gpio_setpull� [-Werror=implicit-function-declaration]
>>
>
> I think this patch should go with Linus's patchset.

Patch applied to the GPIO tree. I added your ACK Bryan since
that seems to be implied above ...

Yours,
Linus Walleij

Bryan Wu

unread,
Jan 7, 2014, 5:50:03 PM1/7/14
to
On Tue, Jan 7, 2014 at 9:41 AM, Linus Walleij <linus....@linaro.org> wrote:
> On Fri, Jan 3, 2014 at 7:19 AM, Bryan Wu <cool...@gmail.com> wrote:
>> On Thu, Jan 2, 2014 at 9:25 PM, Tushar Behera <tushar...@linaro.org> wrote:
>>> Commit c67d0f29262b ("ARM: s3c24xx: get rid of custom <mach/gpio.h>")
>>> removed the usage of mach/gpio.h file, but we need to include
>>> plat/gpio-cfg.h to avoid following build error.
>>>
>>> Fixes following build error.
>>> drivers/leds/leds-s3c24xx.c: In function �s3c24xx_led_probe�:
>>> drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
>>> function �s3c_gpio_setpull� [-Werror=implicit-function-declaration]
>>>
>>
>> I think this patch should go with Linus's patchset.
>
> Patch applied to the GPIO tree. I added your ACK Bryan since
> that seems to be implied above ...
>
Sure, thanks.
-Bryan
0 new messages