Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[RESEND PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO

2 views
Skip to first unread message

Tim Kryger

unread,
Jan 7, 2014, 2:00:03 PM1/7/14
to
The board schematic states that the "SD_CARD_DET_N gets pulled to GND
when card is inserted" so the polarity has been updated to active low.

Polarity is now specified with a GPIO define instead of a magic number.

Signed-off-by: Tim Kryger <tim.k...@linaro.org>
Reviewed-by: Matt Porter <matt....@linaro.org>
---
arch/arm/boot/dts/bcm28155-ap.dts | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts
index 08e47c2..27dd110 100644
--- a/arch/arm/boot/dts/bcm28155-ap.dts
+++ b/arch/arm/boot/dts/bcm28155-ap.dts
@@ -13,6 +13,8 @@

/dts-v1/;

+#include <dt-bindings/gpio/gpio.h>
+
#include "bcm11351.dtsi"

/ {
@@ -40,7 +42,7 @@

sdio4: sdio@3f1b0000 {
max-frequency = <48000000>;
- cd-gpios = <&gpio 14 0>;
+ cd-gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
status = "okay";
};
};
--
1.8.0.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Christian Daudt

unread,
Jan 8, 2014, 6:40:02 PM1/8/14
to
Tim,
Does bcm11351-brt not also suffer from the same bug? If it does can
you pls update the patch to also fix it?

Thanks,
csd

Tim Kryger

unread,
Jan 8, 2014, 7:30:02 PM1/8/14
to
The BRT and AP boards are similar so it may have the same problem but
I don't have a BRT and wouldn't be able to test any changes to its DTS
file.

-Tim

Christian Daudt

unread,
Jan 8, 2014, 8:00:02 PM1/8/14
to
[sorry for the resend for those that get it twice]
Agreed - it's time that dts file go away. In this case:
Acked-by: Christian Daudt <b...@fixthebug.org>

Olof - can you pls pull in this patch. This is the bugfix that was
discussed in irc earlier today.

thanks,
csd

Tim Kryger

unread,
Jan 24, 2014, 1:50:01 PM1/24/14
to
Christian,

I'm not sure Olof saw your reply. Olof and Kevin are now on CC.

Thanks,
Tim Kryger

Olof Johansson

unread,
Jan 31, 2014, 6:20:01 PM1/31/14
to
Nope, applied now. Had to touch it up a bit since we're missing some of the
patches that this was based on for 3.14, but the cd-gpios property is fixed.


-Olof
0 new messages