Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] cxgb3: fix hot plug removal crash

2 views
Skip to first unread message

Divy Le Ray

unread,
Mar 3, 2010, 3:00:02 PM3/3/10
to
From: Divy Le Ray <di...@chelsio.com>

queue restart tasklets need to be stopped after napi handlers are stopped
since the latter can restart them. So stop them after stopping napi.

Signed-off-by: Divy Le Ray <di...@chelsio.com>
---

drivers/net/cxgb3/cxgb3_main.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)


diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c
index 6fd968a..cecdec1 100644
--- a/drivers/net/cxgb3/cxgb3_main.c
+++ b/drivers/net/cxgb3/cxgb3_main.c
@@ -1280,6 +1280,7 @@ static void cxgb_down(struct adapter *adapter)

free_irq_resources(adapter);
quiesce_rx(adapter);
+ t3_sge_stop(adapter);
flush_workqueue(cxgb3_wq); /* wait for external IRQ handler */
}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

David Miller

unread,
Mar 4, 2010, 3:40:01 AM3/4/10
to
From: Divy Le Ray <di...@chelsio.com>
Date: Wed, 03 Mar 2010 11:49:47 -0800

> From: Divy Le Ray <di...@chelsio.com>
>
> queue restart tasklets need to be stopped after napi handlers are stopped
> since the latter can restart them. So stop them after stopping napi.
>
> Signed-off-by: Divy Le Ray <di...@chelsio.com>

Applied.

0 new messages