Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

Re: [PATCH 58/62] msi-laptop: Support some MSI 3G netbook that is need load SCM

0 views
Skip to first unread message

Joey Lee

unread,
Mar 4, 2010, 12:10:01 PM3/4/10
to
Hi Matthew,

於 三，2010-03-03 於 13:45 +0000，Matthew Garrett 提到：
> On Tue, Mar 02, 2010 at 09:52:12PM -0700, Joey Lee wrote:
>
> > I developed this driver on 2.6.31 kernel, and I found this key code is
> > in 2.6.33 kernel and later.
> > There have one and only one scancode to control 3 devices when end user
> > press fn+f11 key on MSI N034.
> > Currently, we setup this mapping in HAL key and mapping it to KEY_WLAN.
>
> Ah! The key comes through the keyboard controller? In that case, yeah,
> just map it to KEY_RFKILL in hal isntead of KEY_WLAN. Everything should
> work fine then. If rfkill-input is configured, it'll kill all the
> radios. If userland claims it instead, it can cycle through with
> whatever policy is desired.
>

Thank's for your review and suggestion.
Per discuss for msi-laptop patchset, I will submit a bit patch for the
following change:
- remove threeg sysfs interface.
- add KEY_RFKILL keymapping to msi-laptop.

Does it make sense? or I still miss something important?


Thank's
Joey Lee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Joey Lee

unread,
Mar 5, 2010, 1:20:02 AM3/5/10
to
Hi Matthew,

於 四，2010-03-04 於 17:09 +0000，Matthew Garrett 提到：


> On Thu, Mar 04, 2010 at 10:07:53AM -0700, Joey Lee wrote:
> > Thank's for your review and suggestion.
> > Per discuss for msi-laptop patchset, I will submit a bit patch for the
> > following change:
> > - remove threeg sysfs interface.
> > - add KEY_RFKILL keymapping to msi-laptop.
>

> If the key event comes through the keyboard controller, there's no need
> to add the mapping to msi-laptop. Doing it through udev or hal is fine.
>

Thank's fully undertood, now, will send patch for remove threeg sysfs
interface.

Joey Lee

unread,
Mar 9, 2010, 7:50:02 AM3/9/10
to
Hi Greg,

Please kindly review the attached patch for removed the non-standard
interface "threeg" in msi-laptop driver.

Thank's a lot!
Joey Lee

於 五，2010-03-05 於 06:10 +0000，joeyli(Joey Lee) 提到：

0006-Removed-non-standard-interface-threeg.patch

Matthew Garrett

unread,
Mar 9, 2010, 4:20:02 PM3/9/10
to
On Tue, Mar 09, 2010 at 01:01:50PM -0800, Greg KH wrote:

> On Tue, Mar 09, 2010 at 05:42:58AM -0700, Joey Lee wrote:
> > Hi Greg,
> >
> > Please kindly review the attached patch for removed the non-standard
> > interface "threeg" in msi-laptop driver.
>
> Looks good to me.
>
> Matthew, are you going to be taking patches like this now?

I am.

> If so, feel free to add:
> Acked-by: Greg Kroah-Hartman <gre...@suse.de>
> to the patch.

Will do.

Thanks,
--
Matthew Garrett | mj...@srcf.ucam.org

Greg KH

unread,
Mar 9, 2010, 4:20:02 PM3/9/10
to
On Tue, Mar 09, 2010 at 05:42:58AM -0700, Joey Lee wrote:
> Hi Greg,
>
> Please kindly review the attached patch for removed the non-standard
> interface "threeg" in msi-laptop driver.

Looks good to me.

Matthew, are you going to be taking patches like this now?

If so, feel free to add:


Acked-by: Greg Kroah-Hartman <gre...@suse.de>
to the patch.

If not, please let me know.

thanks,

greg k-h

0 new messages