Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] Staging: android: fix parentheses coding style issue in alarm-dev.c

0 views
Skip to first unread message

Michał Kwiatkowski

unread,
Jan 14, 2014, 4:30:02 PM1/14/14
to
From: Michal Kwiatkowski <michaelf...@geekingspree.com>

This is a patch to the alarm-dev.c file that removes parentheses which
should not appear in return statement. This error was found by the
checkpatch.pl tool.

Signed-off-by: Michał Kwiatkowski <michaelf...@geekingspree.com>
---
drivers/staging/android/alarm-dev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/android/alarm-dev.c b/drivers/staging/android/alarm-dev.c
index 647694f..96b2f53 100644
--- a/drivers/staging/android/alarm-dev.c
+++ b/drivers/staging/android/alarm-dev.c
@@ -68,8 +68,8 @@ static struct devalarm alarms[ANDROID_ALARM_TYPE_COUNT];
*/
static int is_wakeup(enum android_alarm_type type)
{
- return (type == ANDROID_ALARM_RTC_WAKEUP ||
- type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP);
+ return type == ANDROID_ALARM_RTC_WAKEUP ||
+ type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP;
}


--
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Levente Kurusa

unread,
Jan 14, 2014, 4:50:02 PM1/14/14
to
Hello,

2014/1/14 Michaďż˝ Kwiatkowski <michaelf...@geekingspree.com>:
> From: Michal Kwiatkowski <michaelf...@geekingspree.com>
>
> This is a patch to the alarm-dev.c file that removes parentheses which
> should not appear in return statement. This error was found by the
> checkpatch.pl tool.
>
> Signed-off-by: Michaďż˝ Kwiatkowski <michaelf...@geekingspree.com>
> --

This is like the third patch in this two week period that does the
exact same with more or less success, and I recall one getting applied
(I might be wrong). Anyway, this one finally looks good! :-)

--
Regards,
Levente Kurusa

Greg Kroah-Hartman

unread,
Jan 14, 2014, 5:00:03 PM1/14/14
to
On Tue, Jan 14, 2014 at 10:43:04PM +0100, Levente Kurusa wrote:
> Hello,
>
> 2014/1/14 Michał Kwiatkowski <michaelf...@geekingspree.com>:
> > From: Michal Kwiatkowski <michaelf...@geekingspree.com>
> >
> > This is a patch to the alarm-dev.c file that removes parentheses which
> > should not appear in return statement. This error was found by the
> > checkpatch.pl tool.
> >
> > Signed-off-by: Michał Kwiatkowski <michaelf...@geekingspree.com>
> > --
>
> This is like the third patch in this two week period that does the
> exact same with more or less success, and I recall one getting applied
> (I might be wrong). Anyway, this one finally looks good! :-)

You are right, it doesn't apply, Michal should have received my
rejection notice from my patch-bot already saying this.

thanks,

greg k-h

Michał Kwiatkowski

unread,
Jan 15, 2014, 5:40:02 PM1/15/14
to
This is a patch to the alarm-dev.c file that removes parentheses which
should not appear in return statement. This error was found by the
checkpatch.pl tool.

Signed-off-by: Michał Kwiatkowski <michaelf...@geekingspree.com>
---
drivers/staging/android/alarm-dev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/android/alarm-dev.c b/drivers/staging/android/alarm-dev.c
index 647694f..96b2f53 100644
--- a/drivers/staging/android/alarm-dev.c
+++ b/drivers/staging/android/alarm-dev.c
@@ -68,8 +68,8 @@ static struct devalarm alarms[ANDROID_ALARM_TYPE_COUNT];
*/
static int is_wakeup(enum android_alarm_type type)
{
- return (type == ANDROID_ALARM_RTC_WAKEUP ||
- type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP);
+ return type == ANDROID_ALARM_RTC_WAKEUP ||
+ type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP;
}


--
1.7.9.5

Levente Kurusa

unread,
Jan 16, 2014, 1:00:02 PM1/16/14
to
Hello,

On 01/16/2014 12:32 AM, Michał Kwiatkowski wrote:
> This is a patch to the alarm-dev.c file that removes parentheses which
> should not appear in return statement. This error was found by the
> checkpatch.pl tool.
>
> Signed-off-by: Michał Kwiatkowski <michaelf...@geekingspree.com>
> [...]
> +++ b/drivers/staging/android/alarm-dev.c
> @@ -68,8 +68,8 @@ static struct devalarm alarms[ANDROID_ALARM_TYPE_COUNT];
> */
> static int is_wakeup(enum android_alarm_type type)
> {
> - return (type == ANDROID_ALARM_RTC_WAKEUP ||
> - type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP);
> + return type == ANDROID_ALARM_RTC_WAKEUP ||
> + type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP;
> }

This is the fourth patch that does the exact same, an other similar patch
was already applied, hence this one will not apply. Please base your patches
on -next or the staging.git tree.

--
Regards,
Levente Kurusa
0 new messages