Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH net-next 06/20] net: igbvf: slight optimization of addr compare

4 views
Skip to first unread message

Ding Tianhong

unread,
Dec 27, 2013, 2:00:02 AM12/27/13
to
Use possibly more efficient ether_addr_equal
to instead of memcmp.

Cc: Jeff Kirsher <jeffrey....@intel.com>
Cc: Jesse Brandeburg <jesse.br...@intel.com>
Cc: Carolyn Wyborny <carolyn...@intel.com>
Cc: Don Skidmore <donald.c...@intel.com>
Signed-off-by: Ding Tianhong <dingti...@huawei.com>
---
drivers/net/ethernet/intel/igbvf/netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c
index 04bf22e..675435f 100644
--- a/drivers/net/ethernet/intel/igbvf/netdev.c
+++ b/drivers/net/ethernet/intel/igbvf/netdev.c
@@ -1745,7 +1745,7 @@ static int igbvf_set_mac(struct net_device *netdev, void *p)

hw->mac.ops.rar_set(hw, hw->mac.addr, 0);

- if (memcmp(addr->sa_data, hw->mac.addr, 6))
+ if (!ether_addr_equal(addr->sa_data, hw->mac.addr))
return -EADDRNOTAVAIL;

memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len);
--
1.8.0


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Jeff Kirsher

unread,
Dec 27, 2013, 4:50:01 AM12/27/13
to
On Fri, 2013-12-27 at 14:48 +0800, Ding Tianhong wrote:
> Use possibly more efficient ether_addr_equal
> to instead of memcmp.
>
> Cc: Jeff Kirsher <jeffrey....@intel.com>
> Cc: Jesse Brandeburg <jesse.br...@intel.com>
> Cc: Carolyn Wyborny <carolyn...@intel.com>
> Cc: Don Skidmore <donald.c...@intel.com>
> Signed-off-by: Ding Tianhong <dingti...@huawei.com>
> ---
> drivers/net/ethernet/intel/igbvf/netdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks Ding, I have added this patch to my queue.
signature.asc

Ding Tianhong

unread,
Dec 28, 2013, 1:30:01 AM12/28/13
to
Use possibly more efficient ether_addr_equal
to instead of memcmp.

Cc: Jeff Kirsher <jeffrey....@intel.com>
Cc: Jesse Brandeburg <jesse.br...@intel.com>
Cc: Carolyn Wyborny <carolyn...@intel.com>
Cc: Don Skidmore <donald.c...@intel.com>
Signed-off-by: Ding Tianhong <dingti...@huawei.com>
---
drivers/net/ethernet/intel/igbvf/netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Jeff Kirsher

unread,
Dec 28, 2013, 8:20:02 AM12/28/13
to
On Sat, 2013-12-28 at 14:17 +0800, Ding Tianhong wrote:
> Use possibly more efficient ether_addr_equal
> to instead of memcmp.
>
> Cc: Jeff Kirsher <jeffrey....@intel.com>
> Cc: Jesse Brandeburg <jesse.br...@intel.com>
> Cc: Carolyn Wyborny <carolyn...@intel.com>
> Cc: Don Skidmore <donald.c...@intel.com>
> Signed-off-by: Ding Tianhong <dingti...@huawei.com>
> ---
> drivers/net/ethernet/intel/igbvf/netdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks Ding, I will update the patch in my queue with this updated
version.
signature.asc

Ding Tianhong

unread,
Dec 30, 2013, 2:50:02 AM12/30/13
to
Use possibly more efficient ether_addr_equal
to instead of memcmp.

Cc: Jeff Kirsher <jeffrey....@intel.com>
Cc: Jesse Brandeburg <jesse.br...@intel.com>
Cc: Carolyn Wyborny <carolyn...@intel.com>
Cc: Don Skidmore <donald.c...@intel.com>
Signed-off-by: Ding Tianhong <dingti...@huawei.com>
---
drivers/net/ethernet/intel/igbvf/netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Brown, Aaron F

unread,
Jan 10, 2014, 10:40:01 PM1/10/14
to
> From: netdev...@vger.kernel.org [mailto:netdev...@vger.kernel.org]
> On Behalf Of Ding Tianhong
> Sent: Friday, December 27, 2013 10:17 PM
> To: Kirsher, Jeffrey T; Brandeburg, Jesse; Wyborny, Carolyn; Skidmore,
> Donald C; David S. Miller; Netdev; linux-...@vger.kernel.org
> Subject: [PATCH net-next v2 06/20] net: igbvf: slight optimization of addr
> compare
>
> Use possibly more efficient ether_addr_equal to instead of memcmp.
>
> Cc: Jeff Kirsher <jeffrey....@intel.com>
> Cc: Jesse Brandeburg <jesse.br...@intel.com>
> Cc: Carolyn Wyborny <carolyn...@intel.com>
> Cc: Don Skidmore <donald.c...@intel.com>
> Signed-off-by: Ding Tianhong <dingti...@huawei.com>

Signed-off-by: Aaron Brown <aaron....@intel.com>
Tested by: Aaron Brown <aaron....@intel.com>

> ---
> drivers/net/ethernet/intel/igbvf/netdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c
> b/drivers/net/ethernet/intel/igbvf/netdev.c
> index 04bf22e..675435f 100644
> --- a/drivers/net/ethernet/intel/igbvf/netdev.c
> +++ b/drivers/net/ethernet/intel/igbvf/netdev.c
> @@ -1745,7 +1745,7 @@ static int igbvf_set_mac(struct net_device *netdev,
> void *p)
>
> hw->mac.ops.rar_set(hw, hw->mac.addr, 0);
>
> - if (memcmp(addr->sa_data, hw->mac.addr, 6))
> + if (!ether_addr_equal(addr->sa_data, hw->mac.addr))
> return -EADDRNOTAVAIL;
>
> memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len);
> --
> 1.8.0
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
0 new messages