Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss
[PATCH -next] mtd: nuc900_nand: remove redundant return value check of platform_get_resource()
0 views
Skip to first unread message
Wei Yongjun
Jan 7, 2014, 8:40:03 AM1/7/14
to
From: Wei Yongjun <yongj...@trendmicro.com.cn>
Remove unneeded error handling on the result of a call
to platform_get_resource() when the value is passed to
devm_ioremap_resource().
Signed-off-by: Wei Yongjun <yongj...@trendmicro.com.cn>
---
drivers/mtd/nand/nuc900_nand.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/mtd/nand/nuc900_nand.c b/drivers/mtd/nand/nuc900_nand.c
index 661fd14..9ee09a8 100644
--- a/drivers/mtd/nand/nuc900_nand.c
+++ b/drivers/mtd/nand/nuc900_nand.c
@@ -268,9 +268,6 @@ static int nuc900_nand_probe(struct platform_device *pdev)
chip->ecc.mode = NAND_ECC_SOFT;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return -ENXIO;
-
nuc900_nand->reg = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(nuc900_nand->reg))
return PTR_ERR(nuc900_nand->reg);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Remove unneeded error handling on the result of a call
to platform_get_resource() when the value is passed to
devm_ioremap_resource().
Signed-off-by: Wei Yongjun <yongj...@trendmicro.com.cn>
---
drivers/mtd/nand/nuc900_nand.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/mtd/nand/nuc900_nand.c b/drivers/mtd/nand/nuc900_nand.c
index 661fd14..9ee09a8 100644
--- a/drivers/mtd/nand/nuc900_nand.c
+++ b/drivers/mtd/nand/nuc900_nand.c
@@ -268,9 +268,6 @@ static int nuc900_nand_probe(struct platform_device *pdev)
chip->ecc.mode = NAND_ECC_SOFT;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return -ENXIO;
-
nuc900_nand->reg = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(nuc900_nand->reg))
return PTR_ERR(nuc900_nand->reg);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Jingoo Han
Jan 7, 2014, 7:00:02 PM1/7/14
to
On Tuesday, January 07, 2014 10:39 PM, Wei Yongjun wrote:
>
> From: Wei Yongjun <yongj...@trendmicro.com.cn>
>
> Remove unneeded error handling on the result of a call
> to platform_get_resource() when the value is passed to
> devm_ioremap_resource().
>
> Signed-off-by: Wei Yongjun <yongj...@trendmicro.com.cn>
Reviewed-by: Jingoo Han <jg1...@samsung.com>
>
> From: Wei Yongjun <yongj...@trendmicro.com.cn>
>
> Remove unneeded error handling on the result of a call
> to platform_get_resource() when the value is passed to
> devm_ioremap_resource().
>
> Signed-off-by: Wei Yongjun <yongj...@trendmicro.com.cn>
Best regards,
Jingoo Han
Brian Norris
Jan 20, 2014, 2:40:01 PM1/20/14
to
On Wed, Jan 08, 2014 at 08:58:49AM +0900, Jingoo Han wrote:
> On Tuesday, January 07, 2014 10:39 PM, Wei Yongjun wrote:
> >
> > From: Wei Yongjun <yongj...@trendmicro.com.cn>
> >
> > Remove unneeded error handling on the result of a call
> > to platform_get_resource() when the value is passed to
> > devm_ioremap_resource().
> >
> > Signed-off-by: Wei Yongjun <yongj...@trendmicro.com.cn>
>
> Reviewed-by: Jingoo Han <jg1...@samsung.com>
Pushed to l2-mtd.git. Thanks!
> On Tuesday, January 07, 2014 10:39 PM, Wei Yongjun wrote:
> >
> > From: Wei Yongjun <yongj...@trendmicro.com.cn>
> >
> > Remove unneeded error handling on the result of a call
> > to platform_get_resource() when the value is passed to
> > devm_ioremap_resource().
> >
> > Signed-off-by: Wei Yongjun <yongj...@trendmicro.com.cn>
>
> Reviewed-by: Jingoo Han <jg1...@samsung.com>
Brian
0 new messages