Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] OPTPROBES: Don't default to y in Kconfig

0 views
Skip to first unread message

Dieter Ries

unread,
Mar 8, 2010, 6:20:03 PM3/8/10
to
CONFIG_OPTPROBES should not default to y while still being flagged
EXPERIMENTAL.

Signed-off-by: Dieter Ries <ma...@dieterries.net>
---
arch/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/Kconfig b/arch/Kconfig
index e5eb133..57710f7 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -43,7 +43,7 @@ config KPROBES

config OPTPROBES
bool "Kprobes jump optimization support (EXPERIMENTAL)"
- default y
+ default n
depends on KPROBES
depends on !PREEMPT
depends on HAVE_OPTPROBES
--
1.7.0.rc0.76.g43960

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Masami Hiramatsu

unread,
Mar 9, 2010, 11:00:04 AM3/9/10
to
Dieter Ries wrote:
> CONFIG_OPTPROBES should not default to y while still being flagged
> EXPERIMENTAL.

Hm, OK, indeed it still needs some more user tests.

Acked-by: Masami Hiramatsu <mhir...@redhat.com>

>
> Signed-off-by: Dieter Ries <ma...@dieterries.net>
> ---
> arch/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/Kconfig b/arch/Kconfig
> index e5eb133..57710f7 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -43,7 +43,7 @@ config KPROBES
>
> config OPTPROBES
> bool "Kprobes jump optimization support (EXPERIMENTAL)"
> - default y
> + default n
> depends on KPROBES
> depends on !PREEMPT
> depends on HAVE_OPTPROBES

--
Masami Hiramatsu
e-mail: mhir...@redhat.com

Ingo Molnar

unread,
Mar 11, 2010, 8:20:03 AM3/11/10
to

* Masami Hiramatsu <mhir...@redhat.com> wrote:

> Dieter Ries wrote:
> > CONFIG_OPTPROBES should not default to y while still being flagged
> > EXPERIMENTAL.
>
> Hm, OK, indeed it still needs some more user tests.
>
> Acked-by: Masami Hiramatsu <mhir...@redhat.com>

Well, since this is a prime time optimization i'd rather see the Kconfig value
eliminated and the optimization to become unconditional. (if it doesnt work
somewhere then it should be fixed)

Ingo

Masami Hiramatsu

unread,
Mar 11, 2010, 5:30:02 PM3/11/10
to
Ingo Molnar wrote:
>
> * Masami Hiramatsu <mhir...@redhat.com> wrote:
>
>> Dieter Ries wrote:
>>> CONFIG_OPTPROBES should not default to y while still being flagged
>>> EXPERIMENTAL.
>>
>> Hm, OK, indeed it still needs some more user tests.
>>
>> Acked-by: Masami Hiramatsu <mhir...@redhat.com>
>
> Well, since this is a prime time optimization i'd rather see the Kconfig value
> eliminated and the optimization to become unconditional. (if it doesnt work
> somewhere then it should be fixed)

OK, that will be good for finding bugs. :)

Thank you,

--
Masami Hiramatsu
e-mail: mhir...@redhat.com

0 new messages