Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.

Dismiss

[PATCH] perf kmem: Increase "Hit" column length

0 views

Skip to first unread message

Pekka Enberg

unread,

Jan 19, 2010, 12:30:02 PM1/19/10

It's fairly easy to overflow the "Hit" column with just few seconds of tracing
so increase the column length to avoid broken formatting.

Cc: Peter Zijlstra <a.p.zi...@chello.nl>
Cc: Paul Mackerras <pau...@samba.org>
Cc: Arnaldo Carvalho de Melo <ac...@redhat.com>
Cc: Li Zefan <li...@cn.fujitsu.com>
Cc: Xiao Guangrong <xiaogu...@cn.fujitsu.com>
Signed-off-by: Pekka Enberg <pen...@cs.helsinki.fi>
---
tools/perf/builtin-kmem.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c
index 7ceb741..33bb9df 100644
--- a/tools/perf/builtin-kmem.c
+++ b/tools/perf/builtin-kmem.c
@@ -375,7 +375,7 @@ static void __print_result(struct rb_root *root, struct perf_session *session,

printf("%.102s\n", graph_dotted_line);
printf(" %-34s |", is_caller ? "Callsite": "Alloc Ptr");
- printf(" Total_alloc/Per | Total_req/Per | Hit | Ping-pong | Frag\n");
+ printf(" Total_alloc/Per | Total_req/Per | Hit | Ping-pong | Frag\n");
printf("%.102s\n", graph_dotted_line);

next = rb_first(root);
@@ -401,7 +401,7 @@ static void __print_result(struct rb_root *root, struct perf_session *session,
snprintf(buf, sizeof(buf), "%#Lx", addr);
printf(" %-34s |", buf);

- printf(" %9llu/%-5lu | %9llu/%-5lu | %6lu | %8lu | %6.3f%%\n",
+ printf(" %9llu/%-5lu | %9llu/%-5lu | %8lu | %8lu | %6.3f%%\n",
(unsigned long long)data->bytes_alloc,
(unsigned long)data->bytes_alloc / data->hit,
(unsigned long long)data->bytes_req,
--
1.6.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

tip-bot for Pekka Enberg

unread,

Jan 20, 2010, 2:20:02 AM1/20/10

Commit-ID: 47103277f8861dcb48ab845533db331ddb9427ca
Gitweb: http://git.kernel.org/tip/47103277f8861dcb48ab845533db331ddb9427ca
Author: Pekka Enberg <pen...@cs.helsinki.fi>
AuthorDate: Tue, 19 Jan 2010 19:23:23 +0200
Committer: Ingo Molnar <mi...@elte.hu>
CommitDate: Wed, 20 Jan 2010 07:20:07 +0100

perf kmem: Increase "Hit" column length

It's fairly easy to overflow the "Hit" column with just few
seconds of tracing so increase the column length to avoid broken
formatting.

Signed-off-by: Pekka Enberg <pen...@cs.helsinki.fi>

LKML-Reference: <1263921803-10214-1-g...@cs.helsinki.fi>
Signed-off-by: Ingo Molnar <mi...@elte.hu>

---
tools/perf/builtin-kmem.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

0 new messages