Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in cipher.c

0 views
Skip to first unread message

Richard Hartmann

unread,
Feb 9, 2010, 8:40:02 PM2/9/10
to

Signed-off-by: Richard Hartmann <richih.ma...@gmail.com>
---
crypto/cipher.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/crypto/cipher.c b/crypto/cipher.c
index 9a1a731..39541e0 100644
--- a/crypto/cipher.c
+++ b/crypto/cipher.c
@@ -8,7 +8,7 @@
*
* This program is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License as published by the Free
- * Software Foundation; either version 2 of the License, or (at your option)
+ * Software Foundation; either version 2 of the License, or (at your option)
* any later version.
*
*/
--
1.6.6.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Richard Hartmann

unread,
Feb 9, 2010, 8:40:02 PM2/9/10
to

Signed-off-by: Richard Hartmann <richih.ma...@gmail.com>
---
crypto/compress.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/crypto/compress.c b/crypto/compress.c
index 1ee3570..c33f076 100644
--- a/crypto/compress.c
+++ b/crypto/compress.c
@@ -7,7 +7,7 @@


*
* This program is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License as published by the Free
- * Software Foundation; either version 2 of the License, or (at your option)
+ * Software Foundation; either version 2 of the License, or (at your option)
* any later version.
*
*/

@@ -39,7 +39,7 @@ int crypto_init_compress_ops(struct crypto_tfm *tfm)

ops->cot_compress = crypto_compress;
ops->cot_decompress = crypto_decompress;
-
+
return 0;

Richard Hartmann

unread,
Feb 9, 2010, 9:30:01 PM2/9/10
to
Obviously, this should have been named

CRYPTO: Fix checkpatch errors & warnings in compress.c

Should I re-send the patch or is it less noise & hassle if I just leave
it this way?


Richard

Herbert Xu

unread,
Feb 10, 2010, 11:50:01 PM2/10/10
to
On Wed, Feb 10, 2010 at 03:21:26AM +0100, Richard Hartmann wrote:
> Obviously, this should have been named
>
> CRYPTO: Fix checkpatch errors & warnings in compress.c
>
> Should I re-send the patch or is it less noise & hassle if I just leave
> it this way?

You don't have to resend it.

Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <her...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Richard Hartmann

unread,
Feb 16, 2010, 7:00:02 AM2/16/10
to
On Thu, Feb 11, 2010 at 05:46, Herbert Xu <her...@gondor.apana.org.au> wrote:

>> Should I re-send the patch or is it less noise & hassle if I just leave
>> it this way?
>
> You don't have to resend it.

GregKH said that I should just re-send all patches after a week. OTOH, I
am not sure if this is not a little bit too agressive.

Thus, I wanted to check if I should wait some more or what the general
consensus of action in the crypto subtree is.

And yes, I am aware that janitor work, and thus my patches, is very low
priority.


Thanks,
Richard

Richard Hartmann

unread,
Feb 16, 2010, 7:10:01 AM2/16/10
to
On Tue, Feb 16, 2010 at 13:00, Herbert Xu <her...@gondor.apana.org.au> wrote:

> For the crypto tree at least I've got all your patches so you
> don't have to resend.

OK, thank you very much. Expect more patches, in this case :)

One more question on workflow, though.. I have been checking
http://git.kernel.org/?p=linux/kernel/git/herbert/crypto-2.6.git;a=summary
for updates, but obviously, this was the wrong place.

Where should I look for your commits so I don't have to have you
waste your time answering emails?

Herbert Xu

unread,
Feb 16, 2010, 7:10:01 AM2/16/10
to
On Tue, Feb 16, 2010 at 12:56:15PM +0100, Richard Hartmann wrote:
>
> Thus, I wanted to check if I should wait some more or what the general
> consensus of action in the crypto subtree is.
>
> And yes, I am aware that janitor work, and thus my patches, is very low
> priority.

For the crypto tree at least I've got all your patches so you


don't have to resend.

For other trees please follow whatever their maintainer (or Greg)
says.

Cheers,

Herbert Xu

unread,
Feb 16, 2010, 7:30:02 AM2/16/10
to
On Tue, Feb 16, 2010 at 01:06:27PM +0100, Richard Hartmann wrote:
>
> One more question on workflow, though.. I have been checking
> http://git.kernel.org/?p=linux/kernel/git/herbert/crypto-2.6.git;a=summary
> for updates, but obviously, this was the wrong place.

You should check the cryptodev-2.6 tree. However, they won't be
there yet as I haven't pushed your changes out. Expect them to
be there by tomorrow.

0 new messages