Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH 2/3] PATCH: UV/NMI Fix tip/bot/kbuild test robot problems

1 view
Skip to first unread message

Mike Travis

unread,
Oct 18, 2013, 3:00:02 PM10/18/13
to
fix-tip-bot-errs.patch

Mike Travis

unread,
Oct 18, 2013, 3:00:02 PM10/18/13
to
fix-no-kdb-error.patch

Mike Travis

unread,
Oct 18, 2013, 3:00:03 PM10/18/13
to
uv-fix-use-kgdb.patch

Mike Travis

unread,
Oct 18, 2013, 3:00:03 PM10/18/13
to

* Change the fix for KDB not defined build problem by changing
the kgdb_nmicallin() interface to include the KDB specific
reason code. This removes a dependency on KDB in the debug
core. Also requires a change the call in from UV NMI handler.

* Fix some problems found by the kbuild test robot.

* Fix UV call into kgdb to depend only on whether KGDB is defined
and not both KGDB and KDB. This allows the power nmi command
to use the gdb remote connection if enabled. Note new action
of 'kgdb' needs to be set as well to indicate user wants to
wait for gdb to be connected. If it's set to 'kdb' then an
error message is displayed if KDB is not configured.
--

--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Ingo Molnar

unread,
Oct 19, 2013, 5:00:02 AM10/19/13
to

* Mike Travis <tra...@sgi.com> wrote:

>
> * Change the fix for KDB not defined build problem by changing
> the kgdb_nmicallin() interface to include the KDB specific
> reason code. This removes a dependency on KDB in the debug
> core. Also requires a change the call in from UV NMI handler.
>
> * Fix some problems found by the kbuild test robot.
>
> * Fix UV call into kgdb to depend only on whether KGDB is defined
> and not both KGDB and KDB. This allows the power nmi command
> to use the gdb remote connection if enabled. Note new action
> of 'kgdb' needs to be set as well to indicate user wants to
> wait for gdb to be connected. If it's set to 'kdb' then an
> error message is displayed if KDB is not configured.
> --

This looks better.

Jason, any objections?

Thanks,

Ingo

Mike Travis

unread,
Jan 13, 2014, 1:20:02 PM1/13/14
to


On 10/19/2013 1:56 AM, Ingo Molnar wrote:
>
> * Mike Travis <tra...@sgi.com> wrote:
>
>>
>> * Change the fix for KDB not defined build problem by changing
>> the kgdb_nmicallin() interface to include the KDB specific
>> reason code. This removes a dependency on KDB in the debug
>> core. Also requires a change the call in from UV NMI handler.
>>
>> * Fix some problems found by the kbuild test robot.
>>
>> * Fix UV call into kgdb to depend only on whether KGDB is defined
>> and not both KGDB and KDB. This allows the power nmi command
>> to use the gdb remote connection if enabled. Note new action
>> of 'kgdb' needs to be set as well to indicate user wants to
>> wait for gdb to be connected. If it's set to 'kdb' then an
>> error message is displayed if KDB is not configured.
>> --
>
> This looks better.
>
> Jason, any objections?
>
> Thanks,
>
> Ingo
>

I haven't heard anything back about this update. Were there
objections? Looks like another merge window is closing?

Thanks,
Mike

Ingo Molnar

unread,
Jan 13, 2014, 2:10:02 PM1/13/14
to

* Mike Travis <tra...@sgi.com> wrote:

> On 10/19/2013 1:56 AM, Ingo Molnar wrote:
> >
> > * Mike Travis <tra...@sgi.com> wrote:
> >
> >>
> >> * Change the fix for KDB not defined build problem by changing
> >> the kgdb_nmicallin() interface to include the KDB specific
> >> reason code. This removes a dependency on KDB in the debug
> >> core. Also requires a change the call in from UV NMI handler.
> >>
> >> * Fix some problems found by the kbuild test robot.
> >>
> >> * Fix UV call into kgdb to depend only on whether KGDB is defined
> >> and not both KGDB and KDB. This allows the power nmi command
> >> to use the gdb remote connection if enabled. Note new action
> >> of 'kgdb' needs to be set as well to indicate user wants to
> >> wait for gdb to be connected. If it's set to 'kdb' then an
> >> error message is displayed if KDB is not configured.
> >> --
> >
> > This looks better.
> >
> > Jason, any objections?
> >
> > Thanks,
> >
> > Ingo
> >
>
> I haven't heard anything back about this update. Were there
> objections? Looks like another merge window is closing?

Please resend the series.

Thanks,

Ingo

Mike Travis

unread,
Jan 13, 2014, 11:30:02 PM1/13/14
to

* Change the fix for 'KDB not defined' build problem by changing
the kgdb_nmicallin() interface to include the KDB specific
reason code. This removes the dependency on KDB in the debug
core. It also requires a change to the kgdb call in from UV
NMI handler to avoid a compile error.

* Fix some problems found by the kbuild test robot.

* Fix UV call into kgdb to depend only on whether KGDB is defined
and not both KGDB and KDB. This allows the power nmi command
to use the gdb remote connection if enabled. Note new action
of 'kgdb' needs to be set as well to indicate user wants the
kernel to wait for gdb to be connected. If it's set to 'kdb'
then an error message is displayed if KDB is not configured.
--

--

Mike Travis

unread,
Jan 13, 2014, 11:30:02 PM1/13/14
to
fix-tip-bot-errs.patch

Mike Travis

unread,
Jan 13, 2014, 11:30:02 PM1/13/14
to
fix-no-kdb-error.patch

Mike Travis

unread,
Jan 13, 2014, 11:30:02 PM1/13/14
to
uv-fix-use-kgdb.patch

Peter Zijlstra

unread,
Jan 14, 2014, 6:10:03 AM1/14/14
to
On Mon, Jan 13, 2014 at 10:24:09PM -0600, Mike Travis wrote:
> Fix some problems found by the kbuild test robot.
>
> Signed-off-by: Mike Travis <tra...@sgi.com>
> Reviewed-by: Hedi Berriche <he...@sgi.com>

In general it is best to actually mention the issues the patch cures,
otherwise review is impossible, /me stares hard at Hedi.

Mike Travis

unread,
Jan 14, 2014, 8:30:02 AM1/14/14
to


On 1/14/2014 3:00 AM, Peter Zijlstra wrote:
> On Mon, Jan 13, 2014 at 10:24:09PM -0600, Mike Travis wrote:
>> Fix some problems found by the kbuild test robot.
>>
>> Signed-off-by: Mike Travis <tra...@sgi.com>
>> Reviewed-by: Hedi Berriche <he...@sgi.com>
>
> In general it is best to actually mention the issues the patch cures,
> otherwise review is impossible, /me stares hard at Hedi.
>

I can send an updated patch if required? The issues were
pretty trivial so I didn't think more info than the patch
itself was needed.

Hopefully I don't get a lot more in the future (this was my
first time), should I include the actual tipbot messages?

Thanks.

Peter Zijlstra

unread,
Jan 14, 2014, 8:50:03 AM1/14/14
to
On Tue, Jan 14, 2014 at 05:27:46AM -0800, Mike Travis wrote:
>
>
> On 1/14/2014 3:00 AM, Peter Zijlstra wrote:
> > On Mon, Jan 13, 2014 at 10:24:09PM -0600, Mike Travis wrote:
> >> Fix some problems found by the kbuild test robot.
> >>
> >> Signed-off-by: Mike Travis <tra...@sgi.com>
> >> Reviewed-by: Hedi Berriche <he...@sgi.com>
> >
> > In general it is best to actually mention the issues the patch cures,
> > otherwise review is impossible, /me stares hard at Hedi.
> >
>
> I can send an updated patch if required? The issues were
> pretty trivial so I didn't think more info than the patch
> itself was needed.

It makes it impossible to say if what you did corresponds with what you
meant to do; let alone say if its the 'correct' way.

> Hopefully I don't get a lot more in the future (this was my
> first time), should I include the actual tipbot messages?

Sure.
0 new messages