Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] gpio: pxa: normalize the return value for gpio_get

1 view
Skip to first unread message

Neil Zhang

unread,
Jan 10, 2014, 1:10:02 AM1/10/14
to
It would be convenient to normalize the return value for gpio_get.

I have checked mach-mmp / mach-pxa / plat-pxa / plat-orion / mach-orion5x.
It's OK for all of them to change this function to return 0 and 1.

Signed-off-by: Neil Zhang <zha...@marvell.com>
---
drivers/gpio/gpio-pxa.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index cc13d1b..42e6e64 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -263,7 +263,8 @@ static int pxa_gpio_direction_output(struct gpio_chip *chip,

static int pxa_gpio_get(struct gpio_chip *chip, unsigned offset)
{
- return readl_relaxed(gpio_chip_base(chip) + GPLR_OFFSET) & (1 << offset);
+ u32 gplr = readl_relaxed(gpio_chip_base(chip) + GPLR_OFFSET);
+ return !!(gplr & (1 << offset));
}

static void pxa_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
--
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Linus Walleij

unread,
Jan 15, 2014, 3:00:01 AM1/15/14
to
On Fri, Jan 10, 2014 at 7:03 AM, Neil Zhang <zha...@marvell.com> wrote:

> It would be convenient to normalize the return value for gpio_get.
>
> I have checked mach-mmp / mach-pxa / plat-pxa / plat-orion / mach-orion5x.
> It's OK for all of them to change this function to return 0 and 1.
>
> Signed-off-by: Neil Zhang <zha...@marvell.com>

Bah I updated the commit message a bit ... you dropped the
gpio: pxa: etc from the previous patch, not good but don't worry
I fixed it up.

Yours,
Linus Walleij

Neil Zhang

unread,
Jan 15, 2014, 3:30:02 AM1/15/14
to

> -----Original Message-----
> From: Linus Walleij [mailto:linus....@linaro.org]
> Sent: 2014年1月15日 15:58
> To: Neil Zhang
> Cc: Alexandre Courbot; linux...@vger.kernel.org; linux-...@vger.kernel.org
> Subject: Re: [PATCH] gpio: pxa: normalize the return value for gpio_get
>
> On Fri, Jan 10, 2014 at 7:03 AM, Neil Zhang <zha...@marvell.com> wrote:
>
> > It would be convenient to normalize the return value for gpio_get.
> >
> > I have checked mach-mmp / mach-pxa / plat-pxa / plat-orion / mach-orion5x.
> > It's OK for all of them to change this function to return 0 and 1.
> >
> > Signed-off-by: Neil Zhang <zha...@marvell.com>
>
> Bah I updated the commit message a bit ... you dropped the
> gpio: pxa: etc from the previous patch, not good but don't worry I fixed it up.
>
Thanks!

> Yours,
> Linus Walleij

Best Regards,
Neil Zhang
0 new messages