Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] drivers: dwc2: Mark function as static in core.c

0 views
Skip to first unread message

Rashika Kheria

unread,
Dec 21, 2013, 5:30:02 AM12/21/13
to
Mark function dwc2_set_param_uframe_sched() as static in core.c because
it is not used outside this file.

This eliminates the following warning in core.c:
drivers/staging/dwc2/core.c:2739:5: warning: no previous prototype for ‘dwc2_set_param_uframe_sched’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika...@gmail.com>
---
drivers/staging/dwc2/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/dwc2/core.c b/drivers/staging/dwc2/core.c
index 6d001b5..c029cb6 100644
--- a/drivers/staging/dwc2/core.c
+++ b/drivers/staging/dwc2/core.c
@@ -2736,7 +2736,7 @@ int dwc2_get_hwparams(struct dwc2_hsotg *hsotg)
return 0;
}

-int dwc2_set_param_uframe_sched(struct dwc2_hsotg *hsotg, int val)
+static int dwc2_set_param_uframe_sched(struct dwc2_hsotg *hsotg, int val)
{
int retval = 0;

--
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Josh Triplett

unread,
Dec 21, 2013, 6:00:01 AM12/21/13
to
On Sat, Dec 21, 2013 at 03:50:29PM +0530, Rashika Kheria wrote:
> Mark function dwc2_set_param_uframe_sched() as static in core.c because
> it is not used outside this file.
>
> This eliminates the following warning in core.c:
> drivers/staging/dwc2/core.c:2739:5: warning: no previous prototype for ‘dwc2_set_param_uframe_sched’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika...@gmail.com>

Reviewed-by: Josh Triplett <jo...@joshtriplett.org>

Greg Kroah-Hartman

unread,
Jan 8, 2014, 6:50:02 PM1/8/14
to
On Sat, Dec 21, 2013 at 03:50:29PM +0530, Rashika Kheria wrote:
> Mark function dwc2_set_param_uframe_sched() as static in core.c because
> it is not used outside this file.
>
> This eliminates the following warning in core.c:
> drivers/staging/dwc2/core.c:2739:5: warning: no previous prototype for ‘dwc2_set_param_uframe_sched’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika...@gmail.com>

This patch doesn't apply to my tree.

And please stop sending patches in base64 mode, it makes it impossible
to add reviewed-by: markings to them.

thanks,

greg k-h
0 new messages