Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] backlight: Convert from Legacy pm ops to dev_pm_ops

5 views
Skip to first unread message

Shuah Khan

unread,
May 31, 2013, 11:30:02 PM5/31/13
to
Convert drivers/video/backlight/class to use dev_pm_ops for power
management and remove Legacy PM ops hooks. With this change, rtc class
registers suspend/resume callbacks via class->pm (dev_pm_ops) instead of
Legacy class->suspend/resume. When __device_suspend() runs call-backs,
it will find class->pm ops for the rtc class.

Signed-off-by: Shuah Khan <shua...@samsung.com>
Cc: Shuah Khan <shua...@gmail.com>
---
drivers/video/backlight/backlight.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c
index c74e7aa..0ffb251 100644
--- a/drivers/video/backlight/backlight.c
+++ b/drivers/video/backlight/backlight.c
@@ -208,7 +208,7 @@ static ssize_t backlight_show_actual_brightness(struct device *dev,

static struct class *backlight_class;

-static int backlight_suspend(struct device *dev, pm_message_t state)
+static int backlight_suspend(struct device *dev)
{
struct backlight_device *bd = to_backlight_device(dev);

@@ -236,6 +236,9 @@ static int backlight_resume(struct device *dev)
return 0;
}

+static SIMPLE_DEV_PM_OPS(backlight_class_dev_pm_ops, backlight_suspend,
+ backlight_resume);
+
static void bl_device_release(struct device *dev)
{
struct backlight_device *bd = to_backlight_device(dev);
@@ -414,8 +417,7 @@ static int __init backlight_class_init(void)
}

backlight_class->dev_attrs = bl_device_attributes;
- backlight_class->suspend = backlight_suspend;
- backlight_class->resume = backlight_resume;
+ backlight_class->pm = &backlight_class_dev_pm_ops;
return 0;
}

--
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Shuah Khan

unread,
Jun 1, 2013, 12:00:02 AM6/1/13
to
Convert drivers/video/backlight/class to use dev_pm_ops for power
management and remove Legacy PM ops hooks. With this change, rtc class
registers suspend/resume callbacks via class->pm (dev_pm_ops) instead of
Legacy class->suspend/resume. When __device_suspend() runs call-backs,
it will find class->pm ops for the backlight class.

Signed-off-by: Shuah Khan <shua...@samsung.com>
Cc: Shuah Khan <shua...@gmail.com>
---

v2: Updated changelog to correct device class.

Jingoo Han

unread,
Jun 1, 2013, 12:10:01 AM6/1/13
to
On Wednesday, November 14, 2040 8:02 PM, Shuah Khan wrote:
>
> Convert drivers/video/backlight/class to use dev_pm_ops for power
> management and remove Legacy PM ops hooks. With this change, rtc class

No, this is a backlight class, not rtc class.

Please fix the typo as below:
rtc class -> backlight class.


> registers suspend/resume callbacks via class->pm (dev_pm_ops) instead of
> Legacy class->suspend/resume. When __device_suspend() runs call-backs,
> it will find class->pm ops for the rtc class.

Same here.


Best regards,
Jingoo Han

Jingoo Han

unread,
Jun 1, 2013, 12:20:02 AM6/1/13
to
On Wednesday, November 14, 2040 8:27 PM, Shuah Khan wrote:
>
> Convert drivers/video/backlight/class to use dev_pm_ops for power
> management and remove Legacy PM ops hooks. With this change, rtc class

There is still the typo.

Please fix it.
rtc class -> backlight class


> registers suspend/resume callbacks via class->pm (dev_pm_ops) instead of
> Legacy class->suspend/resume. When __device_suspend() runs call-backs,
> it will find class->pm ops for the backlight class.
>
> Signed-off-by: Shuah Khan <shua...@samsung.com>
> Cc: Shuah Khan <shua...@gmail.com>


Shuah Khan

unread,
Jun 1, 2013, 7:10:02 PM6/1/13
to
Convert drivers/video/backlight/class to use dev_pm_ops for power
management and remove Legacy PM ops hooks. With this change, backlight
class registers suspend/resume callbacks via class->pm (dev_pm_ops)
instead of Legacy class->suspend/resume. When __device_suspend() runs
call-backs, it will find class->pm ops for the backlight class.

Signed-off-by: Shuah Khan <shua...@samsung.com>
Cc: Shuah Khan <shua...@gmail.com>
---

v2: Updated changelog to correct device class.
v3: Updated changelog to correct device class.

Jingoo Han

unread,
Jun 3, 2013, 12:20:01 AM6/3/13
to
On Sunday, June 02, 2013 8:07 AM, Shuah Khan wrote:
>
> Convert drivers/video/backlight/class to use dev_pm_ops for power
> management and remove Legacy PM ops hooks. With this change, backlight
> class registers suspend/resume callbacks via class->pm (dev_pm_ops)
> instead of Legacy class->suspend/resume. When __device_suspend() runs
> call-backs, it will find class->pm ops for the backlight class.
>
> Signed-off-by: Shuah Khan <shua...@samsung.com>
> Cc: Shuah Khan <shua...@gmail.com>

CC'ed Andrew Morton,

It looks good.

Acked-by: Jingoo Han <jg1...@samsung.com>


Best regards,
Jingoo Han

Arnd Bergmann

unread,
Jun 6, 2013, 5:30:03 PM6/6/13
to
On Monday 03 June 2013 13:10:10 Jingoo Han wrote:
> On Sunday, June 02, 2013 8:07 AM, Shuah Khan wrote:
> >
> > Convert drivers/video/backlight/class to use dev_pm_ops for power
> > management and remove Legacy PM ops hooks. With this change, backlight
> > class registers suspend/resume callbacks via class->pm (dev_pm_ops)
> > instead of Legacy class->suspend/resume. When __device_suspend() runs
> > call-backs, it will find class->pm ops for the backlight class.
> >
> > Signed-off-by: Shuah Khan <shua...@samsung.com>
> > Cc: Shuah Khan <shua...@gmail.com>
>
> CC'ed Andrew Morton,
>
> It looks good.
>
> Acked-by: Jingoo Han <jg1...@samsung.com>
>

I'm getting this build warning now:

arnd@wuerfel:/git/arm-soc$ cat build/omap1_defconfig/faillog
/git/arm-soc/drivers/video/backlight/backlight.c:212:12: warning: 'backlight_suspend' defined but not used [-Wunused-function]
static int backlight_suspend(struct device *dev)
^
/git/arm-soc/drivers/video/backlight/backlight.c:226:12: warning: 'backlight_resume' defined but not used [-Wunused-function]
static int backlight_resume(struct device *dev)

Arnd

Jingoo Han

unread,
Jun 6, 2013, 9:30:02 PM6/6/13
to
On Friday, June 07, 2013 6:28 AM, Arnd Bergmann wrote:
> On Monday 03 June 2013 13:10:10 Jingoo Han wrote:
> > On Sunday, June 02, 2013 8:07 AM, Shuah Khan wrote:
> > >
> > > Convert drivers/video/backlight/class to use dev_pm_ops for power
> > > management and remove Legacy PM ops hooks. With this change, backlight
> > > class registers suspend/resume callbacks via class->pm (dev_pm_ops)
> > > instead of Legacy class->suspend/resume. When __device_suspend() runs
> > > call-backs, it will find class->pm ops for the backlight class.
> > >
> > > Signed-off-by: Shuah Khan <shua...@samsung.com>
> > > Cc: Shuah Khan <shua...@gmail.com>
> >
> > CC'ed Andrew Morton,
> >
> > It looks good.
> >
> > Acked-by: Jingoo Han <jg1...@samsung.com>
> >
>
> I'm getting this build warning now:
>
> arnd@wuerfel:/git/arm-soc$ cat build/omap1_defconfig/faillog
> /git/arm-soc/drivers/video/backlight/backlight.c:212:12: warning: 'backlight_suspend' defined but not
> used [-Wunused-function]
> static int backlight_suspend(struct device *dev)
> ^
> /git/arm-soc/drivers/video/backlight/backlight.c:226:12: warning: 'backlight_resume' defined but not
> used [-Wunused-function]
> static int backlight_resume(struct device *dev)

Hi Arnd Bergmann,

I see what happens.
This build warning happens when CONFIG_PM is selected and
CONFIG_PM_SLEEP is not selected.

So, I will add '#ifdef CONFIG_PM_SLEEP' to './drivers/video/backlight/backlight.c'
and send it soon.
Thank you.

Best regards,
Jingoo Han

David Brown

unread,
Aug 9, 2013, 5:30:02 PM8/9/13
to
On Wed, Nov 14, 2040 at 04:27:17AM -0700, Shuah Khan wrote:
> ...

The clock on your computer might be running just a wee bit ahead.

Either that, or we're getting patches from the future.

David

--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

Shuah Khan

unread,
Aug 9, 2013, 5:40:01 PM8/9/13
to
On 08/09/2013 03:28 PM, David Brown wrote:
> On Wed, Nov 14, 2040 at 04:27:17AM -0700, Shuah Khan wrote:
>> ...
>
> The clock on your computer might be running just a wee bit ahead.
>
> Either that, or we're getting patches from the future.
>
> David
>

David,

I know what happened. I was testing suspend to disk with pm_trace
enabled and forgot to set the correct time after the running the test.
Generated the patch without realizing the time is incorrect. Would like
me to re-generate it.

-- Shuah

Shuah Khan, Linux Kernel Developer - Open Source Group Samsung Research
America (Silicon Valley) shua...@samsung.com | (970) 672-0658

Rafael J. Wysocki

unread,
Jan 19, 2014, 10:30:02 AM1/19/14
to
On Wednesday, November 14, 2040 04:27:17 AM Shuah Khan wrote:
> Convert drivers/video/backlight/class to use dev_pm_ops for power
> management and remove Legacy PM ops hooks. With this change, rtc class
> registers suspend/resume callbacks via class->pm (dev_pm_ops) instead of
> Legacy class->suspend/resume. When __device_suspend() runs call-backs,
> it will find class->pm ops for the backlight class.
>
> Signed-off-by: Shuah Khan <shua...@samsung.com>
> Cc: Shuah Khan <shua...@gmail.com>

Can you please resend the patches that nobody took with CCs to
linu...@vger.kernel.org? If the original maintainers don't care, I'll be
able to pick those patches up then (if they look good).

Thanks!
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Jingoo Han

unread,
Jan 19, 2014, 8:40:02 PM1/19/14
to
On Monday, January 20, 2014 12:37 AM, Rafael J. Wysocki wrote:
> On Wednesday, November 14, 2040 04:27:17 AM Shuah Khan wrote:
> > Convert drivers/video/backlight/class to use dev_pm_ops for power
> > management and remove Legacy PM ops hooks. With this change, rtc class
> > registers suspend/resume callbacks via class->pm (dev_pm_ops) instead of
> > Legacy class->suspend/resume. When __device_suspend() runs call-backs,
> > it will find class->pm ops for the backlight class.
> >
> > Signed-off-by: Shuah Khan <shua...@samsung.com>
> > Cc: Shuah Khan <shua...@gmail.com>
>
> Can you please resend the patches that nobody took with CCs to
> linu...@vger.kernel.org? If the original maintainers don't care, I'll be
> able to pick those patches up then (if they look good).

I already gave the comment, and am waiting v3 patch.
However, Shuah Khan did not send the v3 patch yet.

Currently, backlight subsystem patches go through mm-tree
With my acked-by.

Shuah Khan,
Will you send the v3 patch? As I said, there is the typo in
commit message. Please fix it.
s/rtc class/backlight class

Best regards,
Jingoo Han

Shuah Khan

unread,
Jan 20, 2014, 10:30:02 AM1/20/14
to
On 01/19/2014 06:34 PM, Jingoo Han wrote:
> On Monday, January 20, 2014 12:37 AM, Rafael J. Wysocki wrote:
>> On Wednesday, November 14, 2040 04:27:17 AM Shuah Khan wrote:
>>> Convert drivers/video/backlight/class to use dev_pm_ops for power
>>> management and remove Legacy PM ops hooks. With this change, rtc class
>>> registers suspend/resume callbacks via class->pm (dev_pm_ops) instead of
>>> Legacy class->suspend/resume. When __device_suspend() runs call-backs,
>>> it will find class->pm ops for the backlight class.
>>>
>>> Signed-off-by: Shuah Khan <shua...@samsung.com>
>>> Cc: Shuah Khan <shua...@gmail.com>
>>
>> Can you please resend the patches that nobody took with CCs to
>> linu...@vger.kernel.org? If the original maintainers don't care, I'll be
>> able to pick those patches up then (if they look good).
>
> I already gave the comment, and am waiting v3 patch.
> However, Shuah Khan did not send the v3 patch yet.
>
> Currently, backlight subsystem patches go through mm-tree
> With my acked-by.
>
> Shuah Khan,
> Will you send the v3 patch? As I said, there is the typo in
> commit message. Please fix it.
> s/rtc class/backlight class
>

Rafael/Jingoo Han,

I did send the v3 patch with the typo fixed. Here is the link:

http://lkml.indiana.edu/hypermail/linux/kernel/1306.0/00219.html

This is a while back. I will rebase and res-test and send it.

thanks,
-- Shuah

--
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shua...@samsung.com | (970) 672-0658

Shuah Khan

unread,
Jan 21, 2014, 10:40:01 AM1/21/14
to
On 01/19/2014 08:37 AM, Rafael J. Wysocki wrote:
> On Wednesday, November 14, 2040 04:27:17 AM Shuah Khan wrote:
>> Convert drivers/video/backlight/class to use dev_pm_ops for power
>> management and remove Legacy PM ops hooks. With this change, rtc class
>> registers suspend/resume callbacks via class->pm (dev_pm_ops) instead of
>> Legacy class->suspend/resume. When __device_suspend() runs call-backs,
>> it will find class->pm ops for the backlight class.
>>
>> Signed-off-by: Shuah Khan <shua...@samsung.com>
>> Cc: Shuah Khan <shua...@gmail.com>
>
> Can you please resend the patches that nobody took with CCs to
> linu...@vger.kernel.org? If the original maintainers don't care, I'll be
> able to pick those patches up then (if they look good).
>

Rafael,

Thanks. I have a few legacy pm patches that didn't get pulled into
trees. I will rebase to the latest and resend.

-- Shuah


--
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shua...@samsung.com | (970) 672-0658

Shuah Khan

unread,
Feb 4, 2014, 1:00:01 PM2/4/14
to
On 01/20/2014 08:27 AM, Shuah Khan wrote:
> On 01/19/2014 06:34 PM, Jingoo Han wrote:
>> On Monday, January 20, 2014 12:37 AM, Rafael J. Wysocki wrote:

> Rafael/Jingoo Han,
>
> I did send the v3 patch with the typo fixed. Here is the link:
>
> http://lkml.indiana.edu/hypermail/linux/kernel/1306.0/00219.html
>
> This is a while back. I will rebase and res-test and send it.
>

Checked 3.14-rc1 and patch v3 is in there.

commit 3601792e7b68150420ea8dc129e26e167c0484d8

Jingoo Han

unread,
Feb 4, 2014, 7:20:03 PM2/4/14
to
On Wednesday, February 05, 2014 2:55 AM, Shuah Khan wrote:
> On 01/20/2014 08:27 AM, Shuah Khan wrote:
> > On 01/19/2014 06:34 PM, Jingoo Han wrote:
> >> On Monday, January 20, 2014 12:37 AM, Rafael J. Wysocki wrote:
>
> > Rafael/Jingoo Han,
> >
> > I did send the v3 patch with the typo fixed. Here is the link:
> >
> > http://lkml.indiana.edu/hypermail/linux/kernel/1306.0/00219.html
> >
> > This is a while back. I will rebase and res-test and send it.
> >
>
> Checked 3.14-rc1 and patch v3 is in there.
>
> commit 3601792e7b68150420ea8dc129e26e167c0484d8

OK, I see. I checked that it was already merged to
mainline kernel. Thank you.

Best regards,
Jingoo Han

sebastia...@linaro.org

unread,
Feb 18, 2014, 5:30:02 PM2/18/14
to
0 new messages