[RFC v2 00/21] TCM Core and TCM_Loop patches for v2.6.37
Nicholas A. Bellinger
Greetings Tomo-san, hch, jejb, mnc, boaz, jens, konrad, jlbec, joe, and Co,
The following is a reviewable series containing TCM Core and TCM_Loop v4.0.0-rc4 +
very lastest lio-core-2.6.git/lio-4.0 updates against a fresh v2.6.36-rc5 clone who's commit
log has been broken up to be reviewable rather than historical. This code is intended
for mainline v2.6.37 acceptance and is currently going through the final public review.
The RFCv2 tree can be found in lio-4.0.git/rfcv2-for-37 here:
http://git.kernel.org/?p=linux/kernel/git/nab/lio-4.0.git;a=shortlog;h=refs/heads/rfcv2-for-37
Or can be pulled via:
git://git.kernel.org/pub/scm/linux/kernel/git/nab/lio-4.0.git rfcv2-for-37
The patches can also be found individually here:
http://www.kernel.org/pub/linux/kernel/people/nab/TCM-v4-patches-for-v2.6.36-rc5/
The announcement for the changes between v4.0.0-rc3 -> rc4 is available here:
http://lkml.org/lkml/2010/9/17/284
Note that this series has dropped the original ConfigFS ->check_link() patch, many thanks
to jlbec for making the case that this really was unnecessary. Also note that patch #1
here is the scsi.h defs update that has been posted seperately to linux-scsi:
http://marc.info/?l=linux-scsi&m=128513469032115&w=2
Please have a look at the code at your earliest convience. As before, I will be making
any required changes into lio-core-2.6.git/lio-4.0, and respining this tree as necessary
for an upstream maintainer pull for v2.6.37.
Many, many thanks again to all of the folks who contributed. It certainly would not
be possible without your help!
Signed-off-by: Nicholas A. Bellinger <n...@linux-iscsi.org>
Nicholas Bellinger (21):
scsi: Add missing SPC-4 CDB and MAINTENANCE_[IN,OUT] and
VARIABLE_LENGTH_CMD service actions
tcm: Add ConfigFS extended macro set
tcm: Add v4 base data structures and struct target_core_fabric_ops
tcm: Add SPC-4 explict and implict Asymmetric Logical Unit Access
(ALUA)
tcm: Add ConfigFS subsystem backstore infrastructure
tcm: Add fabric and subsystem transport engine core
tcm: Add HBA core infrastructure
tcm: Add device core infrastructure
tcm: Add target portal group infrastructure
tcm: Add SPC-4 compliant Persistent Reservations (PR)
tcm: Add Task Management infrastructure
tcm: Add UNIT_ATTENTION infrastructure support
tcm: Add SCSI MIB statistics support
tcm: Add FILEIO subsystem plugin
tcm: Add IBLOCK subsystem plugin
tcm: Add PSCSI subsystem plugin
tcm: Add RAMDISK_DR and RAMDISK_MCP subsystem plugins
tcm: Add generic fabric independent ConfigFS infrastructure
tcm: Add generic ProtoID and TransportID fabric handlers for SAS, FC,
and iSCSI
tcm: Add Kbuild and Kconfig for drivers/target,
Documentation/target/tcm_mod_builder.py
tcm_loop: Add multi-fabric Linux/SCSI LLD fabric module
Documentation/target/tcm_mod_builder.py | 1039 +++
Documentation/target/tcm_mod_builder.txt | 138 +
drivers/Kconfig | 2 +
drivers/Makefile | 1 +
drivers/target/Kbuild | 30 +
drivers/target/Kconfig | 36 +
drivers/target/target_core_alua.c | 1993 ++++++
drivers/target/target_core_alua.h | 142 +
drivers/target/target_core_configfs.c | 3334 +++++++++
drivers/target/target_core_device.c | 1705 +++++
drivers/target/target_core_fabric_configfs.c | 1001 +++
drivers/target/target_core_fabric_lib.c | 451 ++
drivers/target/target_core_file.c | 1197 ++++
drivers/target/target_core_file.h | 81 +
drivers/target/target_core_hba.c | 211 +
drivers/target/target_core_hba.h | 14 +
drivers/target/target_core_iblock.c | 1173 ++++
drivers/target/target_core_iblock.h | 44 +
drivers/target/target_core_mib.c | 1081 +++
drivers/target/target_core_mib.h | 31 +
drivers/target/target_core_pr.c | 4243 ++++++++++++
drivers/target/target_core_pr.h | 67 +
drivers/target/target_core_pscsi.c | 1569 +++++
drivers/target/target_core_pscsi.h | 69 +
drivers/target/target_core_rd.c | 1555 +++++
drivers/target/target_core_rd.h | 89 +
drivers/target/target_core_scdb.c | 158 +
drivers/target/target_core_scdb.h | 15 +
drivers/target/target_core_tmr.c | 405 ++
drivers/target/target_core_tpg.c | 830 +++
drivers/target/target_core_transport.c | 8860 ++++++++++++++++++++++++
drivers/target/target_core_ua.c | 332 +
drivers/target/target_core_ua.h | 36 +
drivers/target/tcm_loop/Kbuild | 11 +
drivers/target/tcm_loop/Kconfig | 13 +
drivers/target/tcm_loop/tcm_loop_configfs.c | 649 ++
drivers/target/tcm_loop/tcm_loop_configfs.h | 2 +
drivers/target/tcm_loop/tcm_loop_core.h | 77 +
drivers/target/tcm_loop/tcm_loop_fabric.c | 494 ++
drivers/target/tcm_loop/tcm_loop_fabric.h | 43 +
drivers/target/tcm_loop/tcm_loop_fabric_scsi.c | 618 ++
drivers/target/tcm_loop/tcm_loop_fabric_scsi.h | 10 +
include/scsi/scsi.h | 28 +
include/target/configfs_macros.h | 147 +
include/target/target_core_base.h | 1056 +++
include/target/target_core_configfs.h | 57 +
include/target/target_core_device.h | 66 +
include/target/target_core_fabric_configfs.h | 106 +
include/target/target_core_fabric_lib.h | 28 +
include/target/target_core_fabric_ops.h | 101 +
include/target/target_core_tmr.h | 43 +
include/target/target_core_tpg.h | 39 +
include/target/target_core_transport.h | 570 ++
53 files changed, 36090 insertions(+), 0 deletions(-)
create mode 100755 Documentation/target/tcm_mod_builder.py
create mode 100644 Documentation/target/tcm_mod_builder.txt
create mode 100644 drivers/target/Kbuild
create mode 100644 drivers/target/Kconfig
create mode 100644 drivers/target/target_core_alua.c
create mode 100644 drivers/target/target_core_alua.h
create mode 100644 drivers/target/target_core_configfs.c
create mode 100644 drivers/target/target_core_device.c
create mode 100644 drivers/target/target_core_fabric_configfs.c
create mode 100644 drivers/target/target_core_fabric_lib.c
create mode 100644 drivers/target/target_core_file.c
create mode 100644 drivers/target/target_core_file.h
create mode 100644 drivers/target/target_core_hba.c
create mode 100644 drivers/target/target_core_hba.h
create mode 100644 drivers/target/target_core_iblock.c
create mode 100644 drivers/target/target_core_iblock.h
create mode 100644 drivers/target/target_core_mib.c
create mode 100644 drivers/target/target_core_mib.h
create mode 100644 drivers/target/target_core_pr.c
create mode 100644 drivers/target/target_core_pr.h
create mode 100644 drivers/target/target_core_pscsi.c
create mode 100644 drivers/target/target_core_pscsi.h
create mode 100644 drivers/target/target_core_rd.c
create mode 100644 drivers/target/target_core_rd.h
create mode 100644 drivers/target/target_core_scdb.c
create mode 100644 drivers/target/target_core_scdb.h
create mode 100644 drivers/target/target_core_tmr.c
create mode 100644 drivers/target/target_core_tpg.c
create mode 100644 drivers/target/target_core_transport.c
create mode 100644 drivers/target/target_core_ua.c
create mode 100644 drivers/target/target_core_ua.h
create mode 100644 drivers/target/tcm_loop/Kbuild
create mode 100644 drivers/target/tcm_loop/Kconfig
create mode 100644 drivers/target/tcm_loop/tcm_loop_configfs.c
create mode 100644 drivers/target/tcm_loop/tcm_loop_configfs.h
create mode 100644 drivers/target/tcm_loop/tcm_loop_core.h
create mode 100644 drivers/target/tcm_loop/tcm_loop_fabric.c
create mode 100644 drivers/target/tcm_loop/tcm_loop_fabric.h
create mode 100644 drivers/target/tcm_loop/tcm_loop_fabric_scsi.c
create mode 100644 drivers/target/tcm_loop/tcm_loop_fabric_scsi.h
create mode 100644 include/target/configfs_macros.h
create mode 100644 include/target/target_core_base.h
create mode 100644 include/target/target_core_configfs.h
create mode 100644 include/target/target_core_device.h
create mode 100644 include/target/target_core_fabric_configfs.h
create mode 100644 include/target/target_core_fabric_lib.h
create mode 100644 include/target/target_core_fabric_ops.h
create mode 100644 include/target/target_core_tmr.h
create mode 100644 include/target/target_core_tpg.h
create mode 100644 include/target/target_core_transport.h
--
1.7.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
FUJITA Tomonori
"Nicholas A. Bellinger" <n...@linux-iscsi.org> wrote:
> drivers/Kconfig | 2 +
> drivers/Makefile | 1 +
> drivers/target/Kbuild | 30 +
> drivers/target/Kconfig | 36 +
Why do we need a new place for the target stuff? This could be used
for non scsi protocl?
We had the similar discussion when I put stgt to mainline but we
concluded that under drivers/scsi is the best place.
I don't like to put ibmvscsi driver under something like
drivers/target/tcm_ibmvscsit because ibmvscsi needs to include some
files under drivers/scsi/ibmvscsi/. It's more reasonable to put the
driver there.
Can we change the name, TCM (Target Core Mod), to something more
informative? I think that "Core Mod" is really pointless.
This will be the mainline scsi target feature so why can't we name
the files and modules in more appropriate way?
Nicholas A. Bellinger
> On Wed, 22 Sep 2010 15:48:22 -0700
> "Nicholas A. Bellinger" <n...@linux-iscsi.org> wrote:
>
> > drivers/Kconfig | 2 +
> > drivers/Makefile | 1 +
> > drivers/target/Kbuild | 30 +
> > drivers/target/Kconfig | 36 +
>
> Why do we need a new place for the target stuff? This could be used
> for non scsi protocl?
>
Yes, I have envisioned the princaple pieces of TCM/ConfigFS design being
very much SCSI fabric independent from the start of v3.0 development,
and I think the v4.0 virtual HBA/DEV abstraction now present in
target_core_configfs.c and fabric module independent control plane in
target_core_fabric_configfs.c does demonstrate this design feature.
Of course doing 'SCSI-less' target mode this would still involve some
work to target_core_transport.c to add ATA specific
emulation/passthrough and disable others for the default SPC-3 emulation
logic currently in place. However, I do believe the TCM subsystem
plugin API in target_core_transport.h for pSCSI, iBLOCK, FILEIO, etc is
already more or less SCSI fabric independent and adding a libata
subsystem plugin (eg: with it's own set of TCM fabric modules) minus
current libata-scsi.c glue code would be possible if the libata folks
would like to entertain that discussion..
> We had the similar discussion when I put stgt to mainline but we
> concluded that under drivers/scsi is the best place.
>
> I don't like to put ibmvscsi driver under something like
> drivers/target/tcm_ibmvscsit because ibmvscsi needs to include some
> files under drivers/scsi/ibmvscsi/. It's more reasonable to put the
> driver there.
>
> Can we change the name, TCM (Target Core Mod), to something more
> informative? I think that "Core Mod" is really pointless.
>
> This will be the mainline scsi target feature so why can't we name
> the files and modules in more appropriate way?
Honestly, I tend not to care very much about naming and things, but that
said I would really hate to have to rename actual TCM code at this point
for .37 (other than say directory location/layout and file names) while
the drivers/target/lio-target -> iscsi_proto.h conversion is still on
our TODO list.
Best,
--nab
FUJITA Tomonori
"Nicholas A. Bellinger" <n...@linux-iscsi.org> wrote:
> On Wed, 2010-10-06 at 11:21 +0900, FUJITA Tomonori wrote:
> > On Wed, 22 Sep 2010 15:48:22 -0700
> > "Nicholas A. Bellinger" <n...@linux-iscsi.org> wrote:
> >
> > > drivers/Kconfig | 2 +
> > > drivers/Makefile | 1 +
> > > drivers/target/Kbuild | 30 +
> > > drivers/target/Kconfig | 36 +
> >
> > Why do we need a new place for the target stuff? This could be used
> > for non scsi protocl?
> >
>
> Yes, I have envisioned the princaple pieces of TCM/ConfigFS design being
> very much SCSI fabric independent from the start of v3.0 development,
> and I think the v4.0 virtual HBA/DEV abstraction now present in
> target_core_configfs.c and fabric module independent control plane in
> target_core_fabric_configfs.c does demonstrate this design feature.
>
> Of course doing 'SCSI-less' target mode this would still involve some
> work to target_core_transport.c to add ATA specific
> emulation/passthrough and disable others for the default SPC-3 emulation
> logic currently in place. However, I do believe the TCM subsystem
> plugin API in target_core_transport.h for pSCSI, iBLOCK, FILEIO, etc is
> already more or less SCSI fabric independent and adding a libata
> subsystem plugin (eg: with it's own set of TCM fabric modules) minus
> current libata-scsi.c glue code would be possible if the libata folks
> would like to entertain that discussion..
I like to hear the opinions of SCSI maintainer and ATA folks.
Even if the target feature is SCSI independent, the SCSI drivers
should go to under driver/scsi. As I explained, at least, it's a
cleaner solution for ibmvscsi target driver.
> > We had the similar discussion when I put stgt to mainline but we
> > concluded that under drivers/scsi is the best place.
> >
> > I don't like to put ibmvscsi driver under something like
> > drivers/target/tcm_ibmvscsit because ibmvscsi needs to include some
> > files under drivers/scsi/ibmvscsi/. It's more reasonable to put the
> > driver there.
> >
> > Can we change the name, TCM (Target Core Mod), to something more
> > informative? I think that "Core Mod" is really pointless.
> >
> > This will be the mainline scsi target feature so why can't we name
> > the files and modules in more appropriate way?
>
> Honestly, I tend not to care very much about naming and things, but that
> said I would really hate to have to rename actual TCM code at this point
> for .37 (other than say directory location/layout and file names) while
> the drivers/target/lio-target -> iscsi_proto.h conversion is still on
> our TODO list.
I'm not sure this goes for .37 (up to James) but anyway I think that
we need to take care about the module names now. Once we put stuff
into mainline, it's not good to change the module names. File and
directory names and layout can be changed any time.
Nicholas A. Bellinger
jejb, jgarzik, tejun and co..? Any thoughts here..?
>
> Even if the target feature is SCSI independent, the SCSI drivers
> should go to under driver/scsi. As I explained, at least, it's a
> cleaner solution for ibmvscsi target driver.
>
>
Fair enough then. Then I will plan to move the upstream
lio-core-2.6.git/lio-4.0 branch to live under drivers/scsi/ soon, and
rebase the next .37 branch for mainline following this new layout.
> > > We had the similar discussion when I put stgt to mainline but we
> > > concluded that under drivers/scsi is the best place.
> > >
> > > I don't like to put ibmvscsi driver under something like
> > > drivers/target/tcm_ibmvscsit because ibmvscsi needs to include some
> > > files under drivers/scsi/ibmvscsi/. It's more reasonable to put the
> > > driver there.
> > >
> > > Can we change the name, TCM (Target Core Mod), to something more
> > > informative? I think that "Core Mod" is really pointless.
> > >
> > > This will be the mainline scsi target feature so why can't we name
> > > the files and modules in more appropriate way?
> >
> > Honestly, I tend not to care very much about naming and things, but that
> > said I would really hate to have to rename actual TCM code at this point
> > for .37 (other than say directory location/layout and file names) while
> > the drivers/target/lio-target -> iscsi_proto.h conversion is still on
> > our TODO list.
>
> I'm not sure this goes for .37 (up to James) but anyway I think that
> we need to take care about the module names now. Once we put stuff
> into mainline, it's not good to change the module names.
Yes, definately not..
> File and directory names and layout can be changed any time.
Thanks again for your comments Tomo!
--nab
Tejun Heo
>> I like to hear the opinions of SCSI maintainer and ATA folks.
>
> jejb, jgarzik, tejun and co..? Any thoughts here..?
I frankly have no idea whatsoever. Is there something I can read to
educate myself on the subject?
Thanks.
--
tejun
Vladislav Bolkhovitin
> On 10/06/2010 09:24 AM, Nicholas A. Bellinger wrote:
>>> I like to hear the opinions of SCSI maintainer and ATA folks.
>>
>> jejb, jgarzik, tejun and co..? Any thoughts here..?
>
> I frankly have no idea whatsoever. Is there something I can read to
> educate myself on the subject?
General information about a SCSI target subsystem you can find in
http://scst.sourceforge.net. More internal details about implementation
in http://scst.sourceforge.net/scst_pg.html. Features which are
implemented in http://scst.sourceforge.net/comparison.html.
Directly on the subject you can find some considerations in
http://lkml.org/lkml/2010/10/1/140 (second half of the message).
My opinion is that in ideal the SCSI initiator subsystem should be
drivers/scsi/initiator and the target subsystem - drivers/scsi/target
with shared code in drivers/scsi/. But in reality such big
reorganization is unlikely possible, so it's better to leave SCSI
initiator subsystem in drivers/scsi and the target subsystem - in the
separate directory in drivers/ (drivers/scst for SCST).
Vlad
Tejun Heo
On 10/06/2010 07:13 PM, Vladislav Bolkhovitin wrote:
> Tejun Heo, on 10/06/2010 06:10 PM wrote:
>> On 10/06/2010 09:24 AM, Nicholas A. Bellinger wrote:
>>>> I like to hear the opinions of SCSI maintainer and ATA folks.
>>>
>>> jejb, jgarzik, tejun and co..? Any thoughts here..?
>>
>> I frankly have no idea whatsoever. Is there something I can read to
>> educate myself on the subject?
>
> General information about a SCSI target subsystem you can find in
> http://scst.sourceforge.net. More internal details about implementation
> in http://scst.sourceforge.net/scst_pg.html. Features which are
> implemented in http://scst.sourceforge.net/comparison.html.
>
> Directly on the subject you can find some considerations in
> http://lkml.org/lkml/2010/10/1/140 (second half of the message).
>
> My opinion is that in ideal the SCSI initiator subsystem should be
> drivers/scsi/initiator and the target subsystem - drivers/scsi/target
> with shared code in drivers/scsi/. But in reality such big
> reorganization is unlikely possible, so it's better to leave SCSI
> initiator subsystem in drivers/scsi and the target subsystem - in the
> separate directory in drivers/ (drivers/scst for SCST).
Thanks for the pointers. Yeah, it would be pretty interesting to have
ATA support there too and for ATA I don't really see why anyone would
mix the initiator and target driver implementations. They may share
protocol constants and some utility functions but that will be about
it, so it will mostly be a completely separate subsystem and I think
it probably is better to put it somewhere separate too. I think it
would be best if we can keep the two subsystems clearly separated.
They're targeting very different and most likely disjoint audiences
after all.
Thanks.
--
tejun
Nicholas A. Bellinger
Hi Tejun,
So following hch's recent input and my series for unifying the SCSI
control CDB emulation handling of virtual subsystem plugins in TCM v4.0,
the actual struct se_subsystem_api abstraction itself and individual
IBLOCK, FILEIO and RAMDISK subsystem plugins will now be able to
function indepedent of any SCSI layer code. This will obviously still
require changes to TCM proper and a functioning ATA target mode driver
of course :-), but depending upon the amount of community interest in
this area is something we can start looking at for .38 and .39
Best,
--nab
Nicholas A. Bellinger
Greetings all,
The following is the third reviewable series containing TCM Core and TCM_Loop v4.0.0-rc5 +
very lastest lio-core-2.6.git/lio-4.0 updates against a fresh v2.6.36-rc8 clone who's commit
log has been broken up to be reviewable rather than historical. This code is intended
for mainline v2.6.37 acceptance and is currently going through the 3rd and final public review.
The RFCv3 tree can be found in lio-4.0.git/rfcv3-for-37 here:
http://git.kernel.org/?p=linux/kernel/git/nab/lio-4.0.git;a=shortlog;h=refs/heads/rfcv3-for-37
Or can be pulled via:
git://git.kernel.org/pub/scm/linux/kernel/git/nab/lio-4.0.git rfcv3-for-37
The patches can also be found individually here:
http://www.kernel.org/pub/linux/kernel/people/nab/TCM-v4-patches-for-v2.6.36-rc8/
This mornings announcement for the changes between v4.0.0-rc4 -> rc5 is available here:
http://lkml.org/lkml/2010/10/18/116
Finally, this same v4.0.0-rc5 / RFCv3 code has been merged in another branch named
lio-4.0.git/merge-for-37 with the following two commits:
*) scsi: Add missing SPC-4 CDB and MAINTENANCE_[IN,OUT] and
VARIABLE_LENGTH_CMD service actions
*) tcm: Add TCM and TCM_Loop v4.0.0-rc5
which can be pulled directly from:
git://git.kernel.org/pub/scm/linux/kernel/git/nab/lio-4.0.git merge-for-37
At this point the plan is to defer any new features into v4.1 / .38 code, and focus
on any remaining bugs with TCM_Loop / LIO-Target, and continue on with the LIO-Target
-> iscsi_proto.h conversion. I am also asking hch, jejb, tomo-san, mnc, hare and co
for a list of remaining recommended cleanups for the short term .37 merge.
As we have multiple in-progress TCM HW fabric modules underway that depend on this
code, there will be more testing in this area to make sure all of the functional items
within TCM for interfacing with mainline and out-of-tree target mode drivers.
hch, jejb and co. Please let me know any other cleanup items you would like me
to address for the .37 merge.
Thanks!
Signed-off-by: Nicholas A. Bellinger <n...@linux-iscsi.org>
Nicholas Bellinger (21):
scsi: Add missing SPC-4 CDB and MAINTENANCE_[IN,OUT] and
VARIABLE_LENGTH_CMD service actions
tcm: Add ConfigFS extended macro set
tcm: Add v4 base data structures and struct target_core_fabric_ops
tcm: Add SPC-4 explict and implict Asymmetric Logical Unit Access
(ALUA)
tcm: Add ConfigFS subsystem backstore infrastructure
tcm: Add fabric and subsystem transport engine core
tcm: Add HBA core infrastructure
tcm: Add device core infrastructure
tcm: Add target portal group infrastructure
tcm: Add SPC-4 compliant Persistent Reservations (PR)
tcm: Add Task Management infrastructure
tcm: Add UNIT_ATTENTION infrastructure support
tcm: Add SCSI MIB statistics support
tcm: Add FILEIO subsystem plugin
tcm: Add IBLOCK subsystem plugin
tcm: Add PSCSI subsystem plugin
tcm: Add RAMDISK_DR and RAMDISK_MCP subsystem plugins
tcm: Add generic fabric independent ConfigFS infrastructure
tcm: Add generic ProtoID and TransportID fabric handlers for SAS, FC,
and iSCSI
tcm: Add Kbuild and Kconfig for drivers/target and
Documentation/target/
tcm_loop: Add multi-fabric Linux/SCSI LLD fabric module
Documentation/target/tcm_mod_builder.py | 1094 +++
Documentation/target/tcm_mod_builder.txt | 145 +
drivers/Kconfig | 2 +
drivers/Makefile | 1 +
drivers/target/Kbuild | 30 +
drivers/target/Kconfig | 36 +
drivers/target/target_core_alua.c | 1993 +++++
drivers/target/target_core_alua.h | 142 +
drivers/target/target_core_configfs.c | 3499 +++++++++
drivers/target/target_core_device.c | 1816 +++++
drivers/target/target_core_fabric_configfs.c | 1001 +++
drivers/target/target_core_fabric_lib.c | 451 ++
drivers/target/target_core_file.c | 1052 +++
drivers/target/target_core_file.h | 81 +
drivers/target/target_core_hba.c | 211 +
drivers/target/target_core_hba.h | 14 +
drivers/target/target_core_iblock.c | 995 +++
drivers/target/target_core_iblock.h | 44 +
drivers/target/target_core_mib.c | 1081 +++
drivers/target/target_core_mib.h | 31 +
drivers/target/target_core_pr.c | 4243 +++++++++++
drivers/target/target_core_pr.h | 67 +
drivers/target/target_core_pscsi.c | 1583 ++++
drivers/target/target_core_pscsi.h | 73 +
drivers/target/target_core_rd.c | 1412 ++++
drivers/target/target_core_rd.h | 89 +
drivers/target/target_core_scdb.c | 158 +
drivers/target/target_core_scdb.h | 15 +
drivers/target/target_core_tmr.c | 405 ++
drivers/target/target_core_tpg.c | 830 +++
drivers/target/target_core_transport.c | 9262 ++++++++++++++++++++++++
drivers/target/target_core_ua.c | 332 +
drivers/target/target_core_ua.h | 36 +
drivers/target/tcm_loop/Kbuild | 11 +
drivers/target/tcm_loop/Kconfig | 13 +
drivers/target/tcm_loop/tcm_loop_configfs.c | 647 ++
drivers/target/tcm_loop/tcm_loop_configfs.h | 2 +
drivers/target/tcm_loop/tcm_loop_core.h | 77 +
drivers/target/tcm_loop/tcm_loop_fabric.c | 495 ++
drivers/target/tcm_loop/tcm_loop_fabric.h | 40 +
drivers/target/tcm_loop/tcm_loop_fabric_scsi.c | 618 ++
drivers/target/tcm_loop/tcm_loop_fabric_scsi.h | 10 +
include/scsi/scsi.h | 28 +
include/target/configfs_macros.h | 147 +
include/target/target_core_base.h | 1076 +++
include/target/target_core_configfs.h | 57 +
include/target/target_core_device.h | 73 +
include/target/target_core_fabric_configfs.h | 106 +
include/target/target_core_fabric_lib.h | 28 +
include/target/target_core_fabric_ops.h | 100 +
include/target/target_core_tmr.h | 43 +
include/target/target_core_tpg.h | 39 +
include/target/target_core_transport.h | 571 ++
53 files changed, 36405 insertions(+), 0 deletions(-)
--
1.7.3.1
Christoph Hellwig
I promised you and James to get back to a throughout review for more
than just the backends. It's still in progress, but here is what I
think is most important:
- Sort of the the namepspace for both the file names and function
names. I think you reluctantly agreed to do that a while ago anyway,
but I think it's time to bite the bullet now. Please agree on a
common prefix for both function names and modules. I think the
target name in the directory structure is the best one, but I really
don't care too much. The transport_ prefix used in some code is
really misleading, and the se_ in other isn't too helpful either.
- make sure backends, frontends and core/ code under drivers/target/
are properly separated
- clean up the exported - both as in EXPORT_SYMBOL and simply global
functions. There's a lot of things that should be static or not
exported to modules but is right now. The scripts/namespace.pl
script in the kernel tree is a great helper for that.
- Similarly the headers could use some re-arrangement. I've been
trying to make sense of what each header does but couldn't find it.
In the optimal world you'd have one header for the front-end API,
one of the back-end API and one or more for common structures
and defintions. All with a comment explaining what they are there
for.
Christoph Hellwig
Some comments on the configfs to backend API:
- the various get_*_info methods look like they really should use
the seq_file API. That gives you safety against overflows,
and simplifies the code.
- why are show_configfs_dev_params and get_dev_info separate
methods if they always end up calling the same code?
- the set_configfs_dev_params method implementation contains some
rather nast parsing code. They look like they really should use
the parser.h helpers we use for mount option parsing.
FUJITA Tomonori
Christoph Hellwig <h...@infradead.org> wrote:
> I promised you and James to get back to a throughout review for more
> than just the backends. It's still in progress, but here is what I
> think is most important:
Agreed about all the comments. I complained about similar issues
publicly and privately.
btw, when I'm back to Japan, I resume to work on the ibmvscsis driver.
> - Sort of the the namepspace for both the file names and function
> names. I think you reluctantly agreed to do that a while ago anyway,
> but I think it's time to bite the bullet now. Please agree on a
> common prefix for both function names and modules. I think the
> target name in the directory structure is the best one, but I really
> don't care too much. The transport_ prefix used in some code is
> really misleading, and the se_ in other isn't too helpful either.
Agreed. And as I said, we definitely need to fix the module names
before the mainline inclusion.
Christoph Hellwig
some split up into smaller files while we're at it.
Christoph Hellwig
some comments on the I/O path:
- I think there are too many entry points and different kinds of pass
through. As a start transport_allocate_passthrough should go away,
it can be replaced with retriving the inquiry/serial data from
the device attributes. pscsi can then do it's internal lowlevel
INQUIRY on the device to fill them on probe.
Second all the frontends should agree on one way to insert commands
into the queue, and we should get rid of all the magic flags on the
se_cmd to treat them slightly different. That gives you a single
I/O path for all users making the debugging a lot simpler.
- the se_task / backend task allocation currently is rather
inefficient. See my RFC patch below to unify them in a style similar
to the VFS inode. The backends should probably also switch to use
slab caches and switch to a constistant foo_task naming, but that's
left for later.
- the cdb storage should move into the generic code, including the
external allocation for large CDBs.
- Same for the sense data.
- the data_direction setup in the low-level drivers should be lifted
into common code.
- what's the point of keeping different SG/non-SG codepathes around?
non-SG is a special case of an S/G list with 1 entry. We've switched
to the SG-only model in the scsi initiator layer long ago, and
it simplifies a lot of things. In addition the cdb_read*/
cdb_write*/cdb_none routines should be merged into a single map_task
method that looks at the data direction previously set in se_task.
The methods map to common code alsmost all of the time anyway.
- I really don't like all the function pointers in the se_cmd and the
one in the se_task. They're basically private to
target_core_transport.c and should be replaced by flags, or even
better by only reading their input information where it's actually
used if possible.
And here's the RFC path for the simpler and faster task/request
allocation:
Index: lio-core-2.6/drivers/target/target_core_file.c
===================================================================
--- lio-core-2.6.orig/drivers/target/target_core_file.c 2010-11-08 18:33:49.181529678 +0100
+++ lio-core-2.6/drivers/target/target_core_file.c 2010-11-08 18:53:20.358196345 +0100
@@ -284,13 +284,14 @@ static int fd_transport_complete(struct
return 0;
}
-/* fd_allocate_request(): (Part of se_subsystem_api_t template)
- *
- *
- */
-static void *fd_allocate_request(
- struct se_task *task,
- struct se_device *dev)
+static inline struct fd_request *FILE_REQ(struct se_task *task)
+{
+ return container_of(task, struct fd_request, fd_task);
+}
+
+
+static struct se_task *
+fd_alloc_task(struct se_cmd *cmd)
{
struct fd_request *fd_req;
@@ -300,9 +301,9 @@ static void *fd_allocate_request(
return NULL;
}
- fd_req->fd_dev = dev->dev_ptr;
+ fd_req->fd_dev = SE_DEV(cmd)->dev_ptr;
- return (void *)fd_req;
+ return &fd_req->fd_task;
}
static inline int fd_iovec_alloc(struct fd_request *req)
@@ -381,7 +382,7 @@ static static int fd_sendactor(
{
unsigned long count = desc->count;
struct se_task *task = desc->arg.data;
- struct fd_request *req = (struct fd_request *) task->transport_req;
+ struct fd_request *req = FILE_REQ(task);
struct scatterlist *sg = task->task_sg;
printk(KERN_INFO "page: %p offset: %lu size: %lu\n", page,
@@ -592,7 +593,7 @@ static int fd_do_task(struct se_task *ta
{
struct se_cmd *cmd = task->task_se_cmd;
struct se_device *dev = cmd->se_dev;
- struct fd_request *req = task->transport_req;
+ struct fd_request *req = FILE_REQ(task);
int ret = 0;
req->fd_lba = task->task_lba;
@@ -642,7 +643,7 @@ static int fd_do_task(struct se_task *ta
*/
static void fd_free_task(struct se_task *task)
{
- struct fd_request *req = task->transport_req;
+ struct fd_request *req = FILE_REQ(task);
kfree(req->fd_iovs);
kfree(req);
@@ -785,7 +786,7 @@ static void __fd_get_dev_info(struct fd_
static void fd_map_task_non_SG(struct se_task *task)
{
struct se_cmd *cmd = TASK_CMD(task);
- struct fd_request *req = task->transport_req;
+ struct fd_request *req = FILE_REQ(task);
req->fd_bufflen = task->task_size;
req->fd_buf = (void *) T_TASK(cmd)->t_task_buf;
@@ -798,7 +799,7 @@ static void fd_map_task_non_SG(struct se
*/
static void fd_map_task_SG(struct se_task *task)
{
- struct fd_request *req = task->transport_req;
+ struct fd_request *req = FILE_REQ(task);
req->fd_bufflen = task->task_size;
req->fd_buf = NULL;
@@ -811,7 +812,7 @@ static void fd_map_task_SG(struct se_tas
*/
static int fd_CDB_none(struct se_task *task, u32 size)
{
- struct fd_request *req = task->transport_req;
+ struct fd_request *req = FILE_REQ(task);
req->fd_data_direction = FD_DATA_NONE;
req->fd_bufflen = 0;
@@ -827,7 +828,7 @@ static int fd_CDB_none(struct se_task *t
*/
static int fd_CDB_read_non_SG(struct se_task *task, u32 size)
{
- struct fd_request *req = task->transport_req;
+ struct fd_request *req = FILE_REQ(task);
req->fd_data_direction = FD_DATA_READ;
fd_map_task_non_SG(task);
@@ -841,7 +842,7 @@ static int fd_CDB_read_non_SG(struct se_
*/
static int fd_CDB_read_SG(struct se_task *task, u32 size)
{
- struct fd_request *req = task->transport_req;
+ struct fd_request *req = FILE_REQ(task);
req->fd_data_direction = FD_DATA_READ;
fd_map_task_SG(task);
@@ -855,7 +856,7 @@ static int fd_CDB_read_SG(struct se_task
*/
static int fd_CDB_write_non_SG(struct se_task *task, u32 size)
{
- struct fd_request *req = task->transport_req;
+ struct fd_request *req = FILE_REQ(task);
req->fd_data_direction = FD_DATA_WRITE;
fd_map_task_non_SG(task);
@@ -869,7 +870,7 @@ static int fd_CDB_write_non_SG(struct se
*/
static int fd_CDB_write_SG(struct se_task *task, u32 size)
{
- struct fd_request *req = task->transport_req;
+ struct fd_request *req = FILE_REQ(task);
req->fd_data_direction = FD_DATA_WRITE;
fd_map_task_SG(task);
@@ -892,7 +893,7 @@ static int fd_check_lba(unsigned long lo
*/
static int fd_check_for_SG(struct se_task *task)
{
- struct fd_request *req = task->transport_req;
+ struct fd_request *req = FILE_REQ(task);
return req->fd_sg_count;
}
@@ -903,7 +904,7 @@ static int fd_check_for_SG(struct se_tas
*/
static unsigned char *fd_get_cdb(struct se_task *task)
{
- struct fd_request *req = task->transport_req;
+ struct fd_request *req = FILE_REQ(task);
return req->fd_scsi_cdb;
}
@@ -964,7 +965,7 @@ static struct se_subsystem_api fileio_te
.fua_read_emulated = fd_emulated_fua_read,
.write_cache_emulated = fd_emulated_write_cache,
.transport_complete = fd_transport_complete,
- .allocate_request = fd_allocate_request,
+ .alloc_task = fd_alloc_task,
.do_task = fd_do_task,
.do_sync_cache = fd_emulate_sync_cache,
.free_task = fd_free_task,
Index: lio-core-2.6/drivers/target/target_core_file.h
===================================================================
--- lio-core-2.6.orig/drivers/target/target_core_file.h 2010-11-08 18:33:49.194863013 +0100
+++ lio-core-2.6/drivers/target/target_core_file.h 2010-11-08 19:19:34.261529679 +0100
@@ -21,6 +21,7 @@ extern struct se_global *se_global;
#define RRF_GOT_LBA 0x02
struct fd_request {
+ struct se_task fd_task;
/* SCSI CDB from iSCSI Command PDU */
unsigned char fd_scsi_cdb[TCM_MAX_COMMAND_SIZE];
/* Data Direction */
Index: lio-core-2.6/drivers/target/target_core_iblock.c
===================================================================
--- lio-core-2.6.orig/drivers/target/target_core_iblock.c 2010-11-08 18:37:12.051529680 +0100
+++ lio-core-2.6/drivers/target/target_core_iblock.c 2010-11-08 18:54:12.738196343 +0100
@@ -253,13 +253,13 @@ static int iblock_transport_complete(str
return 0;
}
-/* iblock_allocate_request(): (Part of se_subsystem_api_t template)
- *
- *
- */
-static void *iblock_allocate_request(
- struct se_task *task,
- struct se_device *dev)
+static inline struct iblock_req *IBLOCK_REQ(struct se_task *task)
+{
+ return container_of(task, struct iblock_req, ib_task);
+}
+
+static struct se_task *
+iblock_alloc_task(struct se_cmd *cmd)
{
struct iblock_req *ib_req;
@@ -269,9 +269,9 @@ static void *iblock_allocate_request(
return NULL;
}
- ib_req->ib_dev = dev->dev_ptr;
+ ib_req->ib_dev = SE_DEV(cmd)->dev_ptr;
atomic_set(&ib_req->ib_bio_cnt, 0);
- return ib_req;
+ return &ib_req->ib_task;
}
static unsigned long long iblock_emulate_read_cap_with_block_size(
@@ -439,7 +439,7 @@ int iblock_emulated_fua_read(struct se_d
static int iblock_do_task(struct se_task *task)
{
struct se_device *dev = task->task_se_cmd->se_dev;
- struct iblock_req *req = (struct iblock_req *)task->transport_req;
+ struct iblock_req *req = IBLOCK_REQ(task);
struct iblock_dev *ibd = (struct iblock_dev *)req->ib_dev;
struct request_queue *q = bdev_get_queue(ibd->ibd_bd);
struct bio *bio = req->ib_bio, *nbio = NULL;
@@ -490,7 +490,7 @@ static int iblock_do_discard(struct se_d
static void iblock_free_task(struct se_task *task)
{
- struct iblock_req *req = task->transport_req;
+ struct iblock_req *req = IBLOCK_REQ(task);
struct bio *bio, *hbio = req->ib_bio;
/*
* We only release the bio(s) here if iblock_bio_done() has not called
@@ -504,7 +504,6 @@ static void iblock_free_task(struct se_t
}
kfree(req);
- task->transport_req = NULL;
}
static ssize_t iblock_set_configfs_dev_params(struct se_hba *hba,
@@ -697,7 +696,7 @@ static int iblock_map_task_SG(struct se_
struct se_cmd *cmd = task->task_se_cmd;
struct se_device *dev = SE_DEV(cmd);
struct iblock_dev *ib_dev = task->se_dev->dev_ptr;
- struct iblock_req *ib_req = task->transport_req;
+ struct iblock_req *ib_req = IBLOCK_REQ(task);
struct bio *bio = NULL, *hbio = NULL, *tbio = NULL;
struct scatterlist *sg;
int ret = 0;
@@ -817,9 +816,7 @@ static int iblock_check_for_SG(struct se
static unsigned char *iblock_get_cdb(struct se_task *task)
{
- struct iblock_req *req = task->transport_req;
-
- return req->ib_scsi_cdb;
+ return IBLOCK_REQ(task)->ib_scsi_cdb;
}
static u32 iblock_get_device_rev(struct se_device *dev)
@@ -849,7 +846,7 @@ static sector_t iblock_get_blocks(struct
static void iblock_bio_done(struct bio *bio, int err)
{
struct se_task *task = bio->bi_private;
- struct iblock_req *ibr = task->transport_req;
+ struct iblock_req *ibr = IBLOCK_REQ(task);
/*
* Set -EIO if !BIO_UPTODATE and the passed is still err=0
*/
@@ -914,7 +911,7 @@ static struct se_subsystem_api iblock_te
.fua_read_emulated = iblock_emulated_fua_read,
.write_cache_emulated = iblock_emulated_write_cache,
.transport_complete = iblock_transport_complete,
- .allocate_request = iblock_allocate_request,
+ .alloc_task = iblock_alloc_task,
.do_task = iblock_do_task,
.do_discard = iblock_do_discard,
.do_sync_cache = iblock_emulate_sync_cache,
Index: lio-core-2.6/drivers/target/target_core_iblock.h
===================================================================
--- lio-core-2.6.orig/drivers/target/target_core_iblock.h 2010-11-08 18:37:12.068196346 +0100
+++ lio-core-2.6/drivers/target/target_core_iblock.h 2010-11-08 18:37:47.664863030 +0100
@@ -12,6 +12,7 @@
extern struct se_global *se_global;
struct iblock_req {
+ struct se_task ib_task;
unsigned char ib_scsi_cdb[TCM_MAX_COMMAND_SIZE];
atomic_t ib_bio_cnt;
atomic_t ib_bio_err_cnt;
Index: lio-core-2.6/drivers/target/target_core_pscsi.c
===================================================================
--- lio-core-2.6.orig/drivers/target/target_core_pscsi.c 2010-11-08 18:41:14.521529681 +0100
+++ lio-core-2.6/drivers/target/target_core_pscsi.c 2010-11-08 18:59:57.218196347 +0100
@@ -602,6 +602,12 @@ static void pscsi_free_device(void *p)
kfree(pdv);
}
+static inline struct pscsi_plugin_task *PSCSI_TASK(struct se_task *task)
+{
+ return container_of(task, struct pscsi_plugin_task, pscsi_task);
+}
+
+
/* pscsi_transport_complete():
*
*
@@ -611,7 +617,7 @@ static int pscsi_transport_complete(stru
struct pscsi_dev_virt *pdv = task->se_dev->dev_ptr;
struct scsi_device *sd = pdv->pdv_sd;
int result;
- struct pscsi_plugin_task *pt = task->transport_req;
+ struct pscsi_plugin_task *pt = PSCSI_TASK(task);
unsigned char *cdb = &pt->pscsi_cdb[0];
result = pt->pscsi_result;
@@ -689,23 +695,18 @@ after_mode_select:
return 0;
}
-/* pscsi_allocate_request(): (Part of se_subsystem_api_t template)
- *
- *
- */
-static void *pscsi_allocate_request(
- struct se_task *task,
- struct se_device *dev)
+static struct se_task *
+pscsi_alloc_task(struct se_cmd *cmd)
{
- struct se_cmd *cmd = task->task_se_cmd;
struct pscsi_plugin_task *pt;
unsigned char *cdb = T_TASK(cmd)->t_task_cdb;
pt = kzalloc(sizeof(struct pscsi_plugin_task), GFP_KERNEL);
- if (!(pt)) {
+ if (!pt) {
printk(KERN_ERR "Unable to allocate struct pscsi_plugin_task\n");
return NULL;
}
+
/*
* If TCM Core is signaling a > TCM_MAX_COMMAND_SIZE allocation,
* allocate the extended CDB buffer for per struct se_task context
@@ -732,7 +733,7 @@ static void *pscsi_allocate_request(
} else
pt->pscsi_cdb = &pt->__pscsi_cdb[0];
- return pt;
+ return &pt->pscsi_task;
}
static inline void pscsi_blk_init_request(
@@ -775,7 +776,7 @@ static inline void pscsi_blk_init_reques
*/
static int pscsi_blk_get_request(struct se_task *task)
{
- struct pscsi_plugin_task *pt = task->transport_req;
+ struct pscsi_plugin_task *pt = PSCSI_TASK(task);
struct pscsi_dev_virt *pdv = task->se_dev->dev_ptr;
pt->pscsi_req = blk_get_request(pdv->pdv_sd->request_queue,
@@ -799,7 +800,7 @@ static int pscsi_blk_get_request(struct
*/
static int pscsi_do_task(struct se_task *task)
{
- struct pscsi_plugin_task *pt = task->transport_req;
+ struct pscsi_plugin_task *pt = PSCSI_TASK(task);
struct pscsi_dev_virt *pdv = task->se_dev->dev_ptr;
/*
* Set the struct request->timeout value based on peripheral
@@ -826,9 +827,9 @@ static int pscsi_do_task(struct se_task
*/
static void pscsi_free_task(struct se_task *task)
{
- struct pscsi_plugin_task *pt = task->transport_req;
+ struct pscsi_plugin_task *pt = PSCSI_TASK(task);
/*
- * Release the extended CDB allocation from pscsi_allocate_request()
+ * Release the extended CDB allocation from pscsi_alloc_task()
* if one exists.
*/
if (task->task_se_cmd->se_cmd_flags & SCF_ECDB_ALLOCATION)
@@ -1084,7 +1085,7 @@ static int __pscsi_map_task_SG(
u32 task_sg_num,
int bidi_read)
{
- struct pscsi_plugin_task *pt = task->transport_req;
+ struct pscsi_plugin_task *pt = PSCSI_TASK(task);
struct pscsi_dev_virt *pdv = task->se_dev->dev_ptr;
struct bio *bio = NULL, *hbio = NULL, *tbio = NULL;
struct page *page;
@@ -1260,7 +1261,7 @@ static int pscsi_map_task_SG(struct se_t
static int pscsi_map_task_non_SG(struct se_task *task)
{
struct se_cmd *cmd = TASK_CMD(task);
- struct pscsi_plugin_task *pt = task->transport_req;
+ struct pscsi_plugin_task *pt = PSCSI_TASK(task);
struct pscsi_dev_virt *pdv = task->se_dev->dev_ptr;
int ret = 0;
@@ -1279,7 +1280,7 @@ static int pscsi_map_task_non_SG(struct
static int pscsi_CDB_none(struct se_task *task, u32 size)
{
- struct pscsi_plugin_task *pt = task->transport_req;
+ struct pscsi_plugin_task *pt = PSCSI_TASK(task);
pt->pscsi_direction = DMA_NONE;
@@ -1292,7 +1293,7 @@ static int pscsi_CDB_none(struct se_task
*/
static int pscsi_CDB_read_non_SG(struct se_task *task, u32 size)
{
- struct pscsi_plugin_task *pt = task->transport_req;
+ struct pscsi_plugin_task *pt = PSCSI_TASK(task);
pt->pscsi_direction = DMA_FROM_DEVICE;
@@ -1308,7 +1309,7 @@ static int pscsi_CDB_read_non_SG(struct
*/
static int pscsi_CDB_read_SG(struct se_task *task, u32 size)
{
- struct pscsi_plugin_task *pt = task->transport_req;
+ struct pscsi_plugin_task *pt = PSCSI_TASK(task);
pt->pscsi_direction = DMA_FROM_DEVICE;
/*
@@ -1327,7 +1328,7 @@ static int pscsi_CDB_read_SG(struct se_t
*/
static int pscsi_CDB_write_non_SG(struct se_task *task, u32 size)
{
- struct pscsi_plugin_task *pt = task->transport_req;
+ struct pscsi_plugin_task *pt = PSCSI_TASK(task);
pt->pscsi_direction = DMA_TO_DEVICE;
@@ -1343,7 +1344,7 @@ static int pscsi_CDB_write_non_SG(struct
*/
static int pscsi_CDB_write_SG(struct se_task *task, u32 size)
{
- struct pscsi_plugin_task *pt = task->transport_req;
+ struct pscsi_plugin_task *pt = PSCSI_TASK(task);
pt->pscsi_direction = DMA_TO_DEVICE;
/*
@@ -1380,7 +1381,7 @@ static int pscsi_check_for_SG(struct se_
*/
static unsigned char *pscsi_get_cdb(struct se_task *task)
{
- struct pscsi_plugin_task *pt = task->transport_req;
+ struct pscsi_plugin_task *pt = PSCSI_TASK(task);
return pt->pscsi_cdb;
}
@@ -1391,7 +1392,7 @@ static unsigned char *pscsi_get_cdb(stru
*/
static unsigned char *pscsi_get_sense_buffer(struct se_task *task)
{
- struct pscsi_plugin_task *pt = task->transport_req;
+ struct pscsi_plugin_task *pt = PSCSI_TASK(task);
return (unsigned char *)&pt->pscsi_sense[0];
}
@@ -1467,7 +1468,7 @@ static inline void pscsi_process_SAM_sta
static void pscsi_req_done(struct request *req, int uptodate)
{
struct se_task *task = req->end_io_data;
- struct pscsi_plugin_task *pt = task->transport_req;
+ struct pscsi_plugin_task *pt = PSCSI_TASK(task);
pt->pscsi_result = req->errors;
pt->pscsi_resid = req->resid_len;
@@ -1500,7 +1501,7 @@ static struct se_subsystem_api pscsi_tem
.create_virtdevice = pscsi_create_virtdevice,
.free_device = pscsi_free_device,
.transport_complete = pscsi_transport_complete,
- .allocate_request = pscsi_allocate_request,
+ .alloc_task = pscsi_alloc_task,
.do_task = pscsi_do_task,
.free_task = pscsi_free_task,
.check_configfs_dev_params = pscsi_check_configfs_dev_params,
Index: lio-core-2.6/drivers/target/target_core_pscsi.h
===================================================================
--- lio-core-2.6.orig/drivers/target/target_core_pscsi.h 2010-11-08 18:41:14.531529680 +0100
+++ lio-core-2.6/drivers/target/target_core_pscsi.h 2010-11-08 18:46:40.261529681 +0100
@@ -28,6 +28,7 @@ extern struct se_global *se_global;
#include <linux/kobject.h>
struct pscsi_plugin_task {
+ struct se_task pscsi_task;
unsigned char *pscsi_cdb;
unsigned char __pscsi_cdb[TCM_MAX_COMMAND_SIZE];
unsigned char pscsi_sense[SCSI_SENSE_BUFFERSIZE];
Index: lio-core-2.6/drivers/target/target_core_rd.c
===================================================================
--- lio-core-2.6.orig/drivers/target/target_core_rd.c 2010-11-08 18:37:52.141529679 +0100
+++ lio-core-2.6/drivers/target/target_core_rd.c 2010-11-08 19:03:45.954863014 +0100
@@ -351,24 +351,24 @@ static int rd_transport_complete(struct
return 0;
}
-/* rd_allocate_request(): (Part of se_subsystem_api_t template)
- *
- *
- */
-static void *rd_allocate_request(
- struct se_task *task,
- struct se_device *dev)
+static inline struct rd_request *RD_REQ(struct se_task *task)
+{
+ return container_of(task, struct rd_request, rd_task);
+}
+
+static struct se_task *
+rd_alloc_task(struct se_cmd *cmd)
{
struct rd_request *rd_req;
rd_req = kzalloc(sizeof(struct rd_request), GFP_KERNEL);
- if (!(rd_req)) {
+ if (!rd_req) {
printk(KERN_ERR "Unable to allocate struct rd_request\n");
return NULL;
}
- rd_req->rd_dev = dev->dev_ptr;
+ rd_req->rd_dev = SE_DEV(cmd)->dev_ptr;
- return (void *)rd_req;
+ return &rd_req->rd_task;
}
/* rd_get_sg_table():
@@ -644,7 +644,7 @@ static int rd_MEMCPY_write(struct rd_req
static int rd_MEMCPY_do_task(struct se_task *task)
{
struct se_device *dev = task->se_dev;
- struct rd_request *req = task->transport_req;
+ struct rd_request *req = RD_REQ(task);
int ret;
req->rd_lba = task->task_lba;
@@ -678,7 +678,7 @@ static int rd_DIRECT_with_offset(
u32 *se_mem_cnt,
u32 *task_offset)
{
- struct rd_request *req = (struct rd_request *)task->transport_req;
+ struct rd_request *req = RD_REQ(task);
struct rd_dev *dev = req->rd_dev;
struct rd_dev_sg_table *table;
struct se_mem *se_mem;
@@ -781,7 +781,7 @@ static int rd_DIRECT_without_offset(
u32 *se_mem_cnt,
u32 *task_offset)
{
- struct rd_request *req = (struct rd_request *)task->transport_req;
+ struct rd_request *req = RD_REQ(task);
struct rd_dev *dev = req->rd_dev;
struct rd_dev_sg_table *table;
struct se_mem *se_mem;
@@ -866,7 +866,7 @@ static int rd_DIRECT_do_se_mem_map(
u32 *task_offset_in)
{
struct se_cmd *cmd = task->task_se_cmd;
- struct rd_request *req = task->transport_req;
+ struct rd_request *req = RD_REQ(task);
u32 task_offset = *task_offset_in;
int ret;
@@ -991,9 +991,7 @@ static int rd_DIRECT_do_task(struct se_t
*/
static void rd_free_task(struct se_task *task)
{
- struct rd_request *req = task->transport_req;
-
- kfree(req);
+ kfree(RD_REQ(task));
}
static ssize_t rd_set_configfs_dev_params(
@@ -1118,7 +1116,7 @@ static void __rd_get_dev_info(struct rd_
static void rd_map_task_non_SG(struct se_task *task)
{
struct se_cmd *cmd = TASK_CMD(task);
- struct rd_request *req = task->transport_req;
+ struct rd_request *req = RD_REQ(task);
req->rd_bufflen = task->task_size;
req->rd_buf = (void *) T_TASK(cmd)->t_task_buf;
@@ -1131,7 +1129,7 @@ static void rd_map_task_non_SG(struct se
*/
static void rd_map_task_SG(struct se_task *task)
{
- struct rd_request *req = task->transport_req;
+ struct rd_request *req = RD_REQ(task);
req->rd_bufflen = task->task_size;
req->rd_buf = task->task_sg;
@@ -1144,7 +1142,7 @@ static void rd_map_task_SG(struct se_tas
*/
static int rd_CDB_none(struct se_task *task, u32 size)
{
- struct rd_request *req = task->transport_req;
+ struct rd_request *req = RD_REQ(task);
req->rd_data_direction = RD_DATA_NONE;
req->rd_bufflen = 0;
@@ -1160,7 +1158,7 @@ static int rd_CDB_none(struct se_task *t
*/
static int rd_CDB_read_non_SG(struct se_task *task, u32 size)
{
- struct rd_request *req = task->transport_req;
+ struct rd_request *req = RD_REQ(task);
req->rd_data_direction = RD_DATA_READ;
rd_map_task_non_SG(task);
@@ -1174,7 +1172,7 @@ static int rd_CDB_read_non_SG(struct se_
*/
static int rd_CDB_read_SG(struct se_task *task, u32 size)
{
- struct rd_request *req = task->transport_req;
+ struct rd_request *req = RD_REQ(task);
req->rd_data_direction = RD_DATA_READ;
rd_map_task_SG(task);
@@ -1188,7 +1186,7 @@ static int rd_CDB_read_SG(struct se_task
*/
static int rd_CDB_write_non_SG(struct se_task *task, u32 size)
{
- struct rd_request *req = task->transport_req;
+ struct rd_request *req = RD_REQ(task);
req->rd_data_direction = RD_DATA_WRITE;
rd_map_task_non_SG(task);
@@ -1202,7 +1200,7 @@ static int rd_CDB_write_non_SG(struct se
*/
static int rd_CDB_write_SG(struct se_task *task, u32 size)
{
- struct rd_request *req = task->transport_req;
+ struct rd_request *req = RD_REQ(task);
req->rd_data_direction = RD_DATA_WRITE;
rd_map_task_SG(task);
@@ -1235,7 +1233,7 @@ static int rd_MEMCPY_check_lba(unsigned
*/
static int rd_check_for_SG(struct se_task *task)
{
- struct rd_request *req = task->transport_req;
+ struct rd_request *req = RD_REQ(task);
return req->rd_sg_count;
}
@@ -1246,7 +1244,7 @@ static int rd_check_for_SG(struct se_tas
*/
static unsigned char *rd_get_cdb(struct se_task *task)
{
- struct rd_request *req = task->transport_req;
+ struct rd_request *req = RD_REQ(task);
return req->rd_scsi_cdb;
}
@@ -1296,7 +1294,7 @@ static struct se_subsystem_api rd_dr_tem
.transport_complete = rd_transport_complete,
.allocate_DMA = rd_DIRECT_allocate_DMA,
.free_DMA = rd_DIRECT_free_DMA,
- .allocate_request = rd_allocate_request,
+ .alloc_task = rd_alloc_task,
.do_task = rd_DIRECT_do_task,
.free_task = rd_free_task,
.check_configfs_dev_params = rd_check_configfs_dev_params,
@@ -1330,7 +1328,7 @@ static struct se_subsystem_api rd_mcp_te
.create_virtdevice = rd_MEMCPY_create_virtdevice,
.free_device = rd_free_device,
.transport_complete = rd_transport_complete,
- .allocate_request = rd_allocate_request,
+ .alloc_task = rd_alloc_task,
.do_task = rd_MEMCPY_do_task,
.free_task = rd_free_task,
.check_configfs_dev_params = rd_check_configfs_dev_params,
Index: lio-core-2.6/drivers/target/target_core_rd.h
===================================================================
--- lio-core-2.6.orig/drivers/target/target_core_rd.h 2010-11-08 18:37:52.151529680 +0100
+++ lio-core-2.6/drivers/target/target_core_rd.h 2010-11-08 18:38:58.954863015 +0100
@@ -30,6 +30,8 @@ void rd_module_exit(void);
#define RRF_GOT_LBA 0x02
struct rd_request {
+ struct se_task rd_task;
+
/* SCSI CDB from iSCSI Command PDU */
unsigned char rd_scsi_cdb[TCM_MAX_COMMAND_SIZE];
/* Data Direction */
Index: lio-core-2.6/drivers/target/target_core_stgt.c
===================================================================
--- lio-core-2.6.orig/drivers/target/target_core_stgt.c 2010-11-08 18:39:50.574863012 +0100
+++ lio-core-2.6/drivers/target/target_core_stgt.c 2010-11-08 19:00:20.074863014 +0100
@@ -336,13 +336,19 @@ static void stgt_free_device(void *p)
kfree(sdv);
}
+static inline struct stgt_plugin_task *STGT_TASK(struct se_task *task)
+{
+ return container_of(task, struct st_plugin_task, stgt_task);
+}
+
+
/* pscsi_transport_complete():
*
*
*/
static int stgt_transport_complete(struct se_task *task)
{
- struct stgt_plugin_task *st = task->transport_req;
+ struct stgt_plugin_task *st = STGT_TASK(task);
int result;
result = st->stgt_result;
@@ -352,23 +358,18 @@ static int stgt_transport_complete(struc
return 0;
}
-/* stgt_allocate_request(): (Part of se_subsystem_api_t template)
- *
- *
- */
-static void *stgt_allocate_request(
- struct se_task *task,
- struct se_device *dev)
+static struct se_task *
+stgt_alloc_task(struct se_cmd *cmd)
{
struct stgt_plugin_task *st;
st = kzalloc(sizeof(struct stgt_plugin_task), GFP_KERNEL);
- if (!(st)) {
+ if (!st) {
printk(KERN_ERR "Unable to allocate struct stgt_plugin_task\n");
return NULL;
}
- return st;
+ return &st->stgt_task;
}
/* stgt_do_task(): (Part of se_subsystem_api_t template)
@@ -377,7 +378,7 @@ static void *stgt_allocate_request(
*/
static int stgt_do_task(struct se_task *task)
{
- struct stgt_plugin_task *st = task->transport_req;
+ struct stgt_plugin_task *st = STGT_TASK(task);
struct Scsi_Host *sh = task->se_dev->se_hba->hba_ptr;
struct scsi_cmnd *sc;
int tag = MSG_SIMPLE_TAG;
@@ -414,7 +415,7 @@ static int stgt_do_task(struct se_task *
*/
static void stgt_free_task(struct se_task *task)
{
- struct stgt_plugin_task *st = (struct stgt_plugin_task *)task->transport_req;
+ struct stgt_plugin_task *st = STGT_TASK(task);
kfree(st);
}
@@ -629,7 +630,7 @@ static int stgt_map_task_non_SG(struct s
static int stgt_CDB_none(struct se_task *task, u32 size)
{
- struct stgt_plugin_task *st = task->transport_req;
+ struct stgt_plugin_task *st = STGT_TASK(task);
st->stgt_direction = DMA_NONE;
return 0;
@@ -641,7 +642,7 @@ static int stgt_CDB_none(struct se_task
*/
static int stgt_CDB_read_non_SG(struct se_task *task, u32 size)
{
- struct stgt_plugin_task *pt = task->transport_req;
+ struct stgt_plugin_task *st = STGT_TASK(task);
pt->stgt_direction = DMA_FROM_DEVICE;
return stgt_map_task_non_SG(task);
@@ -653,7 +654,7 @@ static int stgt_CDB_read_non_SG(struct s
*/
static int stgt_CDB_read_SG(struct se_task *task, u32 size)
{
- struct stgt_plugin_task *pt = task->transport_req;
+ struct stgt_plugin_task *st = STGT_TASK(task);
pt->stgt_direction = DMA_FROM_DEVICE;
@@ -669,7 +670,7 @@ static int stgt_CDB_read_SG(struct se_ta
*/
static int stgt_CDB_write_non_SG(struct se_task *task, u32 size)
{
- struct stgt_plugin_task *pt = task->transport_req;
+ struct stgt_plugin_task *st = STGT_TASK(task);
pt->stgt_direction = DMA_TO_DEVICE;
return stgt_map_task_non_SG(task);
@@ -681,7 +682,7 @@ static int stgt_CDB_write_non_SG(struct
*/
static int stgt_CDB_write_SG(struct se_task *task, u32 size)
{
- struct stgt_plugin_task *st = task->transport_req;
+ struct stgt_plugin_task *st = STGT_TASK(task);
st->stgt_direction = DMA_TO_DEVICE;
@@ -715,7 +716,7 @@ static int stgt_check_for_SG(struct se_t
*/
static unsigned char *stgt_get_cdb(struct se_task *task)
{
- struct stgt_plugin_task *pt = task->transport_req;
+ struct stgt_plugin_task *st = STGT_TASK(task);
return pt->stgt_cdb;
}
@@ -726,7 +727,7 @@ static unsigned char *stgt_get_cdb(struc
*/
static unsigned char *stgt_get_sense_buffer(struct se_task *task)
{
- struct stgt_plugin_task *pt = task->transport_req;
+ struct stgt_plugin_task *st = STGT_TASK(task);
return (unsigned char *)&pt->stgt_sense[0];
}
@@ -808,13 +809,12 @@ static int stgt_transfer_response(struct
void (*done)(struct scsi_cmnd *))
{
struct se_task *task = (struct se_task *)sc->SCp.ptr;
- struct stgt_plugin_task *st;
+ struct stgt_plugin_task *st = STGT_TASK(task);
if (!task) {
printk(KERN_ERR "struct se_task is NULL!\n");
BUG();
}
- st = (struct stgt_plugin_task *)task->transport_req;
if (!st) {
printk(KERN_ERR "struct stgt_plugin_task is NULL!\n");
BUG();
@@ -847,7 +847,7 @@ static struct se_subsystem_api stgt_temp
.create_virtdevice = stgt_create_virtdevice,
.free_device = stgt_free_device,
.transport_complete = stgt_transport_complete,
- .allocate_request = stgt_allocate_request,
+ .alloc_task = stgt_alloc_task,
.do_task = stgt_do_task,
.free_task = stgt_free_task,
.check_configfs_dev_params = stgt_check_configfs_dev_params,
Index: lio-core-2.6/drivers/target/target_core_stgt.h
===================================================================
--- lio-core-2.6.orig/drivers/target/target_core_stgt.h 2010-11-08 18:40:10.978196347 +0100
+++ lio-core-2.6/drivers/target/target_core_stgt.h 2010-11-08 18:41:10.054863013 +0100
@@ -20,6 +20,7 @@ extern struct se_global *se_global;
#include <linux/kobject.h>
struct stgt_plugin_task {
+ struct se_task stgt_task;
unsigned char stgt_cdb[TCM_MAX_COMMAND_SIZE];
unsigned char stgt_sense[SCSI_SENSE_BUFFERSIZE];
int stgt_direction;
Index: lio-core-2.6/drivers/target/target_core_transport.c
===================================================================
--- lio-core-2.6.orig/drivers/target/target_core_transport.c 2010-11-08 18:32:16.114863012 +0100
+++ lio-core-2.6/drivers/target/target_core_transport.c 2010-11-08 19:03:08.344863013 +0100
@@ -189,7 +189,6 @@ struct se_global *se_global;
EXPORT_SYMBOL(se_global);
struct kmem_cache *se_cmd_cache;
-struct kmem_cache *se_task_cache;
struct kmem_cache *se_tmr_req_cache;
struct kmem_cache *se_sess_cache;
struct kmem_cache *se_hba_cache;
@@ -279,12 +278,6 @@ int init_se_global(void)
printk(KERN_ERR "kmem_cache_create for struct se_cmd failed\n");
goto out;
}
- se_task_cache = kmem_cache_create("se_task_cache",
- sizeof(struct se_task), __alignof__(struct se_task), 0, NULL);
- if (!(se_task_cache)) {
- printk(KERN_ERR "kmem_cache_create for struct se_task failed\n");
- goto out;
- }
se_tmr_req_cache = kmem_cache_create("se_tmr_cache",
sizeof(struct se_tmr_req), __alignof__(struct se_tmr_req),
0, NULL);
@@ -371,8 +364,6 @@ int init_se_global(void)
out:
if (se_cmd_cache)
kmem_cache_destroy(se_cmd_cache);
- if (se_task_cache)
- kmem_cache_destroy(se_task_cache);
if (se_tmr_req_cache)
kmem_cache_destroy(se_tmr_req_cache);
if (se_sess_cache)
@@ -406,7 +397,6 @@ void release_se_global(void)
return;
kmem_cache_destroy(se_cmd_cache);
- kmem_cache_destroy(se_task_cache);
kmem_cache_destroy(se_tmr_req_cache);
kmem_cache_destroy(se_sess_cache);
kmem_cache_destroy(se_hba_cache);
@@ -2450,8 +2440,8 @@ static struct se_task *transport_generic
struct se_device *dev = SE_DEV(cmd);
unsigned long flags;
- task = kmem_cache_zalloc(se_task_cache, GFP_KERNEL);
- if (!(task)) {
+ task = dev->transport->alloc_task(cmd);
+ if (!task) {
printk(KERN_ERR "Unable to allocate struct se_task\n");
return NULL;
}
@@ -2466,12 +2456,6 @@ static struct se_task *transport_generic
DEBUG_SO("se_obj_ptr: %p\n", se_obj_ptr);
- task->transport_req = TRANSPORT(dev)->allocate_request(task, dev);
- if (!(task->transport_req)) {
- kmem_cache_free(se_task_cache, task);
- return NULL;
- }
-
spin_lock_irqsave(&T_TASK(cmd)->t_state_lock, flags);
list_add_tail(&task->t_list, &T_TASK(cmd)->t_task_list);
spin_unlock_irqrestore(&T_TASK(cmd)->t_state_lock, flags);
@@ -5703,12 +5687,11 @@ void transport_free_dev_tasks(struct se_
if (atomic_read(&task->task_active))
continue;
- if (!task->transport_req)
- continue;
-
kfree(task->task_sg_bidi);
kfree(task->task_sg);
+ list_del(&task->t_list);
+
spin_unlock_irqrestore(&T_TASK(cmd)->t_state_lock, flags);
if (task->se_dev)
TRANSPORT(task->se_dev)->free_task(task);
@@ -5716,9 +5699,6 @@ void transport_free_dev_tasks(struct se_
printk(KERN_ERR "task[%u] - task->se_dev is NULL\n",
task->task_no);
spin_lock_irqsave(&T_TASK(cmd)->t_state_lock, flags);
-
- list_del(&task->t_list);
- kmem_cache_free(se_task_cache, task);
}
spin_unlock_irqrestore(&T_TASK(cmd)->t_state_lock, flags);
}
Index: lio-core-2.6/include/target/target_core_transport.h
===================================================================
--- lio-core-2.6.orig/include/target/target_core_transport.h 2010-11-08 18:33:13.384863013 +0100
+++ lio-core-2.6/include/target/target_core_transport.h 2010-11-08 18:45:51.271529681 +0100
@@ -406,10 +406,7 @@ struct se_subsystem_api {
* drivers. Provided out of convenience.
*/
int (*transport_complete)(struct se_task *task);
- /*
- * allocate_request():
- */
- void *(*allocate_request)(struct se_task *, struct se_device *);
+ struct se_task *(*alloc_task)(struct se_cmd *);
/*
* allocate_buf():
*/
Index: lio-core-2.6/include/target/target_core_base.h
===================================================================
--- lio-core-2.6.orig/include/target/target_core_base.h 2010-11-08 19:00:40.734863012 +0100
+++ lio-core-2.6/include/target/target_core_base.h 2010-11-08 19:01:10.851529680 +0100
@@ -472,7 +472,6 @@ struct se_task {
unsigned char task_sense;
struct scatterlist *task_sg;
struct scatterlist *task_sg_bidi;
- void *transport_req;
u8 task_scsi_status;
u8 task_flags;
int task_error_status;
Nicholas A. Bellinger
> Hi Nick,
>
> I promised you and James to get back to a throughout review for more
> than just the backends. It's still in progress, but here is what I
> think is most important:
>
> - Sort of the the namepspace for both the file names and function
> names. I think you reluctantly agreed to do that a while ago anyway,
> but I think it's time to bite the bullet now. Please agree on a
> common prefix for both function names and modules. I think the
> target name in the directory structure is the best one, but I really
> don't care too much. The transport_ prefix used in some code is
> really misleading, and the se_ in other isn't too helpful either.
Fair enough. So for the sake on continuity I am happy to rename
functions that are available externally to frontends with a target_*()
prefix and primary data structures to a tcm_* prefix.
> - make sure backends, frontends and core/ code under drivers/target/
> are properly separated
So at this point only the backend code still lives in drivers/target,
while everything related to frontends resides in
drivers/target/$TCM_MODNAME. Now moving IBLOCK, FILEIO, PSCSI and
RAMDISK .c and .h files into drivers/target/backend/ to resolve this
item..
> - clean up the exported - both as in EXPORT_SYMBOL and simply global
> functions. There's a lot of things that should be static or not
> exported to modules but is right now. The scripts/namespace.pl
> script in the kernel tree is a great helper for that.
<nod> I will follow up with an audit of this code, most of which is
coming from target_core_transport.c
> - Similarly the headers could use some re-arrangement. I've been
> trying to make sense of what each header does but couldn't find it.
> In the optimal world you'd have one header for the front-end API,
> one of the back-end API and one or more for common structures
> and defintions. All with a comment explaining what they are there
> for.
>
Yes, the documentation that I have been promising will help clear this
up. target_core_transport.h contains the struct se_subsystem_api that
is used for backend code, and target_core_fabric_ops.h contains the
struct target_core_fabric_ops used by frontend drivers. There is still
a handful of other includes required for frontend drivers, but I did
spend time on this recently to clean up what is made available in
include/target.
--nab
Nicholas A. Bellinger
> Some comments on the configfs to backend API:
>
> - the various get_*_info methods look like they really should use
> the seq_file API. That gives you safety against overflows,
> and simplifies the code.
Hmmm, it is my understanding that seq_file is currently not available
for configfs. Also, we never going to expect these particular calls to
return anything close to PAGE_SIZE, so I am not sure how much of an
issue this really is.
> - why are show_configfs_dev_params and get_dev_info separate
> methods if they always end up calling the same code?
Hmmm, this was some legacy informational code that no longer has a
reason to be seperate. I will get this merged into a single function.
> - the set_configfs_dev_params method implementation contains some
> rather nast parsing code. They look like they really should use
> the parser.h helpers we use for mount option parsing.
<nod> This code current expects the the incoming buffer to be in the
form of 'key0=value0,key1=value1,key2=value2' etc. Assuming that
parser.h code can handle the comma seperated values, I will look at
getting these converted as well.
--nab
Christoph Hellwig
> Hmmm, it is my understanding that seq_file is currently not available
> for configfs. Also, we never going to expect these particular calls to
> return anything close to PAGE_SIZE, so I am not sure how much of an
> issue this really is.
Seq_file is avaible for anything where you can plug in file_operations.
If configfs doesn't allow plugging in file_operations that's a serious
deficit. If you need less than a page of data single_open provides a
simplified version of seq_file with a similar but much simpler API.
> > - the set_configfs_dev_params method implementation contains some
> > rather nast parsing code. They look like they really should use
> > the parser.h helpers we use for mount option parsing.
>
> <nod> This code current expects the the incoming buffer to be in the
> form of 'key0=value0,key1=value1,key2=value2' etc. Assuming that
> parser.h code can handle the comma seperated values, I will look at
> getting these converted as well.
That's exactly how mount options work.
Nicholas A. Bellinger
> On Mon, Nov 08, 2010 at 01:20:07PM -0800, Nicholas A. Bellinger wrote:
> > Hmmm, it is my understanding that seq_file is currently not available
> > for configfs. Also, we never going to expect these particular calls to
> > return anything close to PAGE_SIZE, so I am not sure how much of an
> > issue this really is.
>
> Seq_file is avaible for anything where you can plug in file_operations.
> If configfs doesn't allow plugging in file_operations that's a serious
> deficit. If you need less than a page of data single_open provides a
> simplified version of seq_file with a similar but much simpler API.
Hmmm, I recall asking Joel about this at some point back in 2008 and
back then I believe configfs was still limited to a PAGE_SIZE.
Joel, any comments here on the usage of seq_file() w/ configfs..?
>
> > > - the set_configfs_dev_params method implementation contains some
> > > rather nast parsing code. They look like they really should use
> > > the parser.h helpers we use for mount option parsing.
> >
> > <nod> This code current expects the the incoming buffer to be in the
> > form of 'key0=value0,key1=value1,key2=value2' etc. Assuming that
> > parser.h code can handle the comma seperated values, I will look at
> > getting these converted as well.
>
> That's exactly how mount options work.
>
<nod> Ok, I will get this code converted to use parser.h.
--nab
Christoph Hellwig
> Hmmm, I recall asking Joel about this at some point back in 2008 and
> back then I believe configfs was still limited to a PAGE_SIZE.
>
> Joel, any comments here on the usage of seq_file() w/ configfs..?
If fixing this would require configfs changes feel free to postponed it
for now.