Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] ixgbevf: delete unneeded call to pci_set_power_state

1 view
Skip to first unread message

Julia Lawall

unread,
Jan 7, 2014, 11:10:02 AM1/7/14
to
From: Julia Lawall <Julia....@lip6.fr>

This driver does not need to adjust the power state on suspend, so the
call to pci_set_power_state in the resume function is a no-op. Drop it, to
make the code more understandable.

Signed-off-by: Julia Lawall <Julia....@lip6.fr>

---
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
index a5d3167..5709fb0 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
@@ -3226,7 +3226,6 @@ static int ixgbevf_resume(struct pci_dev *pdev)
struct net_device *netdev = adapter->netdev;
u32 err;

- pci_set_power_state(pdev, PCI_D0);
pci_restore_state(pdev);
/*
* pci_restore_state clears dev->state_saved so call

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Brown, Aaron F

unread,
Jan 21, 2014, 3:50:02 PM1/21/14
to
On Tue, 2014-01-07 at 18:00 +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia....@lip6.fr>
>
> This driver does not need to adjust the power state on suspend, so the
> call to pci_set_power_state in the resume function is a no-op. Drop it, to
> make the code more understandable.
>
> Signed-off-by: Julia Lawall <Julia....@lip6.fr>
Tested-by: Phil Schmitt <phillip....@intel.com>
Signed-off-by: Aaron Brown <aaron....@intel.com>

> ---
> drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> index a5d3167..5709fb0 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> @@ -3226,7 +3226,6 @@ static int ixgbevf_resume(struct pci_dev *pdev)
> struct net_device *netdev = adapter->netdev;
> u32 err;
>
> - pci_set_power_state(pdev, PCI_D0);
> pci_restore_state(pdev);
> /*
> * pci_restore_state clears dev->state_saved so call
>
> --

> To unsubscribe from this list: send the line "unsubscribe netdev" in

0 new messages