Received: by 10.66.80.166 with SMTP id s6mr4647342pax.30.1349762905104;
        Mon, 08 Oct 2012 23:08:25 -0700 (PDT)
Path: t10ni23656708pbh.0!nntp.google.com!npeer02.iad.highwinds-media.com!news.highwinds-media.com!feed-me.highwinds-media.com!border3.nntp.dca.giganews.com!border1.nntp.dca.giganews.com!border4.nntp.dca.giganews.com!border2.nntp.dca.giganews.com!nntp.giganews.com!newspeer1.nac.net!news.mi.ras.ru!goblin-spool!goblin2!goblin.stu.neva.ru!news.stack.nl!aioe.org!bofh.it!news.nic.it!robomod
From: Alexander Graf <ag...@suse.de>
Newsgroups: linux.kernel
Subject: Re: [REGRESSION] nfsd crashing with 3.6.0-rc7 on PowerPC
Date: Wed, 03 Oct 2012 00:40:02 +0200
Message-ID: <jQjia-7qi-15@gated-at.bofh.it>
References: <jOy1Y-4b8-17@gated-at.bofh.it> <jOybE-4uP-1@gated-at.bofh.it> <jOyuZ-4IG-13@gated-at.bofh.it> <jOKwb-51k-21@gated-at.bofh.it> <jPOR3-2DX-7@gated-at.bofh.it> <jPZ9O-1B7-57@gated-at.bofh.it> <jQivL-6Qx-5@gated-at.bofh.it> <jQivM-6Qx-11@gated-at.bofh.it> <jQiYO-7io-17@gated-at.bofh.it>
X-Original-To: Nishanth Aravamudan <n...@linux.vnet.ibm.com>
MIME-Version: 1.0 (Apple Message framework v1278)
X-Mailer: Apple Mail (2.1278)
Sender: robo...@news.nic.it
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Approved: robo...@news.nic.it
Lines: 57
Organization: linux.* mail to news gateway
X-Original-Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org>,
	linux-...@vger.kernel.org, Jan Kara <j...@suse.cz>,
	Linus Torvalds <torva...@linux-foundation.org>,
	LKML List <linux-ker...@vger.kernel.org>,
	"J. Bruce Fields" <bfie...@fieldses.org>, an...@samba.org,
	skinsbur...@parallels.com, bfie...@redhat.com,
	linuxppc-dev <linuxppc-...@lists.ozlabs.org>
X-Original-Date: Wed, 3 Oct 2012 00:31:09 +0200
X-Original-Message-ID: <E141CA01-F58C-47B1-8ED5-A314D1DEC968@suse.de>
X-Original-References: <3BDA9E62-7031-42D6-8CA9-5327B6170...@suse.de> <CA+55aFyXwB1QcXE4Z_FAGnXROSgvP2x2+wjnX9OWPa4Dfaa...@mail.gmail.com> <DC545CD9-8745-47DD-B13B-3385C0EB5...@suse.de> <20120928151043.GA19...@fieldses.org> <2A52FC96-148C-4F7A-9950-E152E0C66...@suse.de> <1349139509.3847.2.camel@pasglop> <20121002214327.GA29...@linux.vnet.ibm.com> <9257E705-4EF9-4347-945C-B4A7582C4...@suse.de> <20121002221736.GB29...@linux.vnet.ibm.com>
X-Original-Sender: linux-kernel-ow...@vger.kernel.org
Bytes: 4408
X-Received-Bytes: 4516
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit


On 03.10.2012, at 00:17, Nishanth Aravamudan wrote:

> On 02.10.2012 [23:47:39 +0200], Alexander Graf wrote:
>> 
>> On 02.10.2012, at 23:43, Nishanth Aravamudan wrote:
>> 
>>> Hi Ben,
>>> 
>>> On 02.10.2012 [10:58:29 +1000], Benjamin Herrenschmidt wrote:
>>>> On Mon, 2012-10-01 at 16:03 +0200, Alexander Graf wrote:
>>>>> Phew. Here we go :). It looks to be more of a PPC specific problem
>>>>> than it appeared as at first:
>>>> 
>>>> Ok, so I suspect the problem is the pushing down of the locks which
>>>> breaks with iommu backends that have a separate flush callback. In
>>>> that case, the flush moves out of the allocator lock.
>>>> 
>>>> Now we do call flush before we return, still, but it becomes racy
>>>> I suspect, but somebody needs to give it a closer look. I'm hoping
>>>> Anton or Nish will later today.
>>> 
>>> Started looking into this. If your suspicion were accurate, wouldn't the
>>> bisection have stopped at 0e4bc95d87394364f408627067238453830bdbf3
>>> ("powerpc/iommu: Reduce spinlock coverage in iommu_alloc and
>>> iommu_free")?
>>> 
>>> Alex, the error is reproducible, right?
>> 
>> Yes. I'm having a hard time to figure out if the reason my U4 based G5
>> Mac crashes and fails reading data is the same since I don't have a
>> serial connection there, but I assume so.
> 
> Ok, great, thanks. Yeah, that would imply (I think) that the I would
> have thought the lock pushdown in the above commit (or even in one of
> the others in Anton's series) would have been the real source if it was
> a lock-based race. But that's just my first sniff at what Ben was
> suggesting. Still reading/understanding the code.
> 
>>> Does it go away by reverting
>>> that commit against mainline? Just trying to narrow down my focus.
>> 
>> The patch doesn't revert that easily. Mind to provide a revert patch
>> so I can try?
> 
> The following at least builds on defconfig here:

Yes. With that patch applied, things work for me again.


Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/