Received: by 10.180.24.135 with SMTP id u7mr1733950wif.3.1344912002108;
        Mon, 13 Aug 2012 19:40:02 -0700 (PDT)
Path: n2ni119114925win.0!nntp.google.com!goblin3!goblin2!goblin.stu.neva.ru!newsfeed.x-privat.org!bofh.it!news.nic.it!robomod
From: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Newsgroups: linux.kernel
Subject: Re: [PATCH V2] staging: sm7xxfb: copy name of the device before  calling smtc_alloc_fb_info
Date: Tue, 14 Aug 2012 04:40:01 +0200
Message-ID: <jyfcZ-6Qh-1@gated-at.bofh.it>
References: <juQkO-7lJ-9@gated-at.bofh.it>
X-Original-To: Devendra Naga <develkernel412...@gmail.com>
        d=google.com; s=20120113;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent
         :x-gm-message-state;
        bh=3enQyblfLixA8XmiX3F6teC13/fDXdjAC0UID8ChSzk=;
        b=Z4CaL8u+o+b2UsfM3BLqtWTqyr/UD4fekYzhvVmzyzHPejoWEB+tFfzuie7egfTdUf
         1DO0oMspyMPP5MKgvvbYvSsHns2JSLmjU3iwB/BOY4xNO88aVMD2D/UBWXWTw/ic9qgm
         7o9tlx5zInZdBVqYKY0g0nqINeJY7b7HAcdmwC7I31OKX10FGHeK3van7XwLIAMfZVRx
         Qs3pleed/1oDWYQndqizFJifvU4zMtfzQyneX77ahRDxzuVeB8s5rij5mGYYH4noFxmA
         MIyaE/Xh7y+FQEWa39g/+ChEeIClMsIXhcJ3XjNfS4oAe2yZGioMlTZgzhb7L66IOQgu
         GGYQ==
MIME-Version: 1.0
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Gm-Message-State: ALoCoQnwYEojhh8YCokXjnkSR9//xD1TS5sDyZql61ivnmbmpyd5GFOHy7BfDAPmgUN1X+vucuw5
Sender: robo...@news.nic.it
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Approved: robo...@news.nic.it
Lines: 21
Organization: linux.* mail to news gateway
X-Original-Cc: Javier =?iso-8859-1?Q?Mu=F1oz?= <jmun...@igalia.com>,
	Paul Gortmaker <paul.gortma...@windriver.com>,
	Devendra Naga <devendra.a...@gmail.com>,
	de...@driverdev.osuosl.org, linux-ker...@vger.kernel.org
X-Original-Date: Mon, 13 Aug 2012 19:30:02 -0700
X-Original-Message-ID: <20120814023002.GA1046@kroah.com>
X-Original-References: <1344101120-22866-1-git-send-email-develkernel412...@gmail.com>
X-Original-Sender: linux-kernel-ow...@vger.kernel.org
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Aug 04, 2012 at 11:10:20PM +0545, Devendra Naga wrote:
> as we do a strcpy(smdrv_ptr->fb_struct->fix->id, name), and the name here in
> sm7xxx_probe is not having any assignment, and which leads to copying of the garbage value
> into the id field of the fix struct of fb interface struct. fix it by copying the name before
> calling alloc_fbinfo.
> 
> Signed-off-by: Devendra Naga <develkernel412...@gmail.com>
> ---
> 
> Changes since V1:
>  Fix a null deref when smtc_alloc_fbinfo fails, this was added by me in V1.

Huh?  Please resend the correct patch you want me to apply, I'm confused
here.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/