Google Groups Home
Help | Sign in
Message from discussion killing linux/irq.h
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
v...@zeniv.linux.org.uk  
View profile
 More options Sep 9 2005, 2:50 pm
Newsgroups: linux.kernel
From: v...@ZenIV.linux.org.uk
Date: Fri, 09 Sep 2005 20:50:11 +0200
Local: Fri, Sep 9 2005 2:50 pm
Subject: [RFC] killing linux/irq.h
        We get regular portability bugs when somebody decides to include
linux/irq.h into a driver instead of asm/irq.h.  It's almost always a
wrong thing to do and, in fact, causes immediate breakage on e.g. arm.

        Here's what I'm going to do:
* check current includes of linux/irq.h; e.g. in arch/x86_64 all but two
had been 100% useless, one should've been asm/irq.h and one - asm/irq.h +
asm/hw_irq.h.  The only legitimate user of linux/irq.h on amd64 was
asm/hardirq.h.
Situation elsewhere in arch/* is similar - most of includes are not needed
at all.
* remove bogus includes, arch by arch for architectures that live in main
tree.  Switch ones that should've been asm/irq.h to that form.
* put the current contents of linux/irq.h to asm-generic/hardirq.h (which
is what it really is - declarations for hardirq code, relevant on many but
not all platforms).
* switch remaining users of linux/irq.h to asm-generic/hardirq.h (again, for
architectures that live in main tree)
* replace contents of linux/irq.h with #warning and
#include <asm-generic/hardirq.h>.
* after 2.6.14 kill linux/irq.h completely.

        Objections?  That variant leaves out-of-tree folks with window until
2.6.15 to convert and that's really more than enough...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2008 Google