Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] USB: usb-skeleton.c: fix compilation error and restore kref_put on fail in skel_open

13 views
Skip to first unread message

Constantine Shulyupin

unread,
Oct 7, 2012, 6:00:02 AM10/7/12
to
From: Constantine Shulyupin <co...@MakeLinux.com>

Function skel_open increments usage count for the device with kref_get and the usage count should be decremented on the function failure.

Some last changes in function skel_open and finally commit
52a7499 Revert "USB: usb-skeleton.c: fix open/disconnect race"
introduced a bug in function skel_open, which this patch fixes.

Signed-off-by: Constantine Shulyupin <co...@MakeLinux.com>
---
drivers/usb/usb-skeleton.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
index 0616f23..027005b 100644
--- a/drivers/usb/usb-skeleton.c
+++ b/drivers/usb/usb-skeleton.c
@@ -113,8 +113,10 @@ static int skel_open(struct inode *inode, struct file *file)
mutex_lock(&dev->io_mutex);

retval = usb_autopm_get_interface(interface);
- if (retval)
- goto out_err;
+ if (retval) {
+ kref_put(&dev->kref, skel_delete);
+ goto exit;
+ }

/* save our object in the file's private structure */
file->private_data = dev;
--
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Oliver Neukum

unread,
Oct 10, 2012, 6:00:03 AM10/10/12
to
Hi,

good catch, but the fix is wrong. You also need to drop the lock.

Regards
Oliver

Constantine Shulyupin

unread,
Oct 10, 2012, 6:40:03 AM10/10/12
to
From: Constantine Shulyupin <co...@MakeLinux.com>

Function skel_open increments usage count for the device with kref_get and the usage count should be decremented on the function failure.

Some last changes in function skel_open and finally commit
52a7499 Revert "USB: usb-skeleton.c: fix open/disconnect race"
introduced a bug in function skel_open, which this patch fixes.

--
Changelog:
-- Fixed accordinly feedback of Oliver Neukum one...@suse.de: also need to drop the lock.

Signed-off-by: Constantine Shulyupin <co...@MakeLinux.com>
---
drivers/usb/usb-skeleton.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
index 0616f23..2025d03 100644
--- a/drivers/usb/usb-skeleton.c
+++ b/drivers/usb/usb-skeleton.c
@@ -113,8 +113,9 @@ static int skel_open(struct inode *inode, struct file *file)
mutex_lock(&dev->io_mutex);

retval = usb_autopm_get_interface(interface);
- if (retval)
- goto out_err;
+ if (retval) {
+ kref_put(&dev->kref, skel_delete);
+ }

/* save our object in the file's private structure */
file->private_data = dev;
--
1.7.9.5

Oliver Neukum

unread,
Oct 10, 2012, 8:40:02 AM10/10/12
to
On Wednesday 10 October 2012 12:32:54 Constantine Shulyupin wrote:
> From: Constantine Shulyupin <co...@MakeLinux.com>
>
> Function skel_open increments usage count for the device with kref_get and the usage count should be decremented on the function failure.
>
> Some last changes in function skel_open and finally commit
> 52a7499 Revert "USB: usb-skeleton.c: fix open/disconnect race"
> introduced a bug in function skel_open, which this patch fixes.
>
> --
> Changelog:
> -- Fixed accordinly feedback of Oliver Neukum one...@suse.de: also need to drop the lock.

Well, touching file->private_data is not nice. It is correct, but
really dirty. The skeleton driver should be nice. Could you introduce
a second label for goto at the right place?

Regards
Oliver
0 new messages