No-exec support for ppc64
The group you are posting to is a
Usenet group . Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
Newsgroups: linux.kernel
From:
Jake Moilanen <moila... @austin.ibm.com> Date: Wed, 09 Mar 2005 00:30:19 +0100
Local: Tues, Mar 8 2005 6:30 pm
Subject: [PATCH 0/2] No-exec support for ppc64
These patches add no execute support to PPC64. They prohibit executing
code on the stack, or most any non-text segment for both user space, and
kernel.
No execute is supported on Power4 processors and up. These processors
The patches include a base fixup from Anton Blanchard. This includes a
For distros that compile w/ pt_gnu_stacks, they depend on Ben
The patch is broken into two parts:
1/2: PPC64 no-exec support for user space: This will prohibit user
2/2: PPC64 no-exec support for kernel space: This prohibits the kernel
Thanks, ... @vger.kernel.org http://vger.kernel.org/majordomo-info.html http://www.tux.org/lkml/
You must
Sign in before you can post messages.
You do not have the permission required to post.
Newsgroups: linux.kernel
From:
Jake Moilanen <moila... @austin.ibm.com> Date: Wed, 09 Mar 2005 00:30:17 +0100
Local: Tues, Mar 8 2005 6:30 pm
Subject: [PATCH 1/2] No-exec support for ppc64
No-exec base and user space support for PPC64.
This will prohibit user space apps that a compile w/ PT_GNU_STACK from
Signed-off-by: Jake Moilanen <moila... @austin.ibm.com>
---
linux-2.6-bk-moilanen/arch/ppc64/kernel/head.S | 5 +
diff -puN arch/ppc64/kernel/head.S~nx-user-ppc64 arch/ppc64/kernel/head.S
#ifdef CONFIG_PPC_ISERIES
/*
HvCallHpt_get(&hpte, slot);
- flags = newpp & 3;
BUG_ON(lpar_rc != H_Success);
BUG_ON((trap == 0x380) || (trap == 0x480));
@@ -199,16 +200,19 @@ int do_page_fault(struct pt_regs *regs,
+ if (is_exec) {
diff -puN arch/ppc64/mm/hash_low.S~nx-user-ppc64 arch/ppc64/mm/hash_low.S
spin_lock(&mm->page_table_lock);
+ is_exec = access & _PAGE_EXEC;
- hpteflags = 0x2 | (! (pte_val(new_pte) & _PAGE_RW));
/* Check if pte already has an hpte (case 2) */
out:
return err;
/*
#define virt_addr_valid(kaddr) pfn_valid(__pa(kaddr) >> PAGE_SHIFT)
-#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \
#endif /* __KERNEL__ */
read more »
You must
Sign in before you can post messages.
You do not have the permission required to post.
Newsgroups: linux.kernel
From:
Jake Moilanen <moila... @austin.ibm.com> Date: Wed, 09 Mar 2005 00:40:08 +0100
Local: Tues, Mar 8 2005 6:40 pm
Subject: [PATCH 2/2] No-exec support for ppc64
No-exec support for the kernel on PPC64.
This will mark all non-text kernel pages as no-execute.
Signed-off-by: Jake Moilanen <moila... @austin.ibm.com>
---
linux-2.6-bk-moilanen/arch/ppc64/kernel/iSeries_setup.c | 7 +++
diff -puN arch/ppc64/kernel/iSeries_setup.c~nx-kernel-ppc64 arch/ppc64/kernel/iSeries_setup.c
for (pa = saddr; pa < eaddr ;pa += PAGE_SIZE) {
if (hpte.dw0.dw0.v) {
/* Free memory returned from module_alloc */
+pte_t *lookup_address(unsigned long address)
BUG_ON((trap == 0x380) || (trap == 0x480));
@@ -253,6 +269,15 @@ bad_area_nosemaphore:
return SIGSEGV;
#ifdef DEBUG
+int is_kernel_text(unsigned long addr)
if (large)
+
hpteg = ((hash & htab_hash_mask) * HPTES_PER_GROUP);
if (ret == -1) {
-#define PPC64_HWNOEXEC (1 << 2)
@@ -250,8 +267,8 @@ unsigned int hash_page_do_lazy_icache(un
#define HW_NO_EXEC _PAGE_EXEC /* This is used when the bit is
_ ... @vger.kernel.org http://vger.kernel.org/majordomo-info.html http://www.tux.org/lkml/
You must
Sign in before you can post messages.
You do not have the permission required to post.
Newsgroups: linux.kernel
From:
Benjamin Herrenschmidt <b... @kernel.crashing.org> Date: Wed, 09 Mar 2005 04:10:07 +0100
Local: Tues, Mar 8 2005 10:10 pm
Subject: Re: [PATCH 2/2] No-exec support for ppc64
On Tue, 2005-03-08 at 17:13 -0600, Jake Moilanen wrote:
> diff -puN arch/ppc64/kernel/iSeries_setup.c~nx-kernel-ppc64 arch/ppc64/kernel/iSeries_setup.c
> --- linux-2.6-bk/arch/ppc64/kernel/iSeries_setup.c~nx-kernel-ppc64 2005-03-08 16:08:57 -06:00
> +++ linux-2.6-bk-moilanen/arch/ppc64/kernel/iSeries_setup.c 2005-03-08 16:08:57 -06:00
> @@ -624,6 +624,7 @@ static void __init iSeries_bolt_kernel(u
> {
> unsigned long pa;
> unsigned long mode_rw = _PAGE_ACCESSED | _PAGE_COHERENT | PP_RWXX;
> + unsigned long tmp_mode;
> HPTE hpte;
> for (pa = saddr; pa < eaddr ;pa += PAGE_SIZE) {
> if (hpte.dw0.dw0.v) {
tmp_mode doesn't seem to be ever used here ...
> /* Free memory returned from module_alloc */
> diff -puN arch/ppc64/mm/fault.c~nx-kernel-ppc64 arch/ppc64/mm/fault.c
> --- linux-2.6-bk/arch/ppc64/mm/fault.c~nx-kernel-ppc64 2005-03-08 16:08:57 -06:00
> +++ linux-2.6-bk-moilanen/arch/ppc64/mm/fault.c 2005-03-08 16:08:57 -06:00
> @@ -76,6 +76,21 @@ static int store_updates_sp(struct pt_re
> return 0;
> }
> +pte_t *lookup_address(unsigned long address)
Use find_linux_pte() here (asm-ppc64/pgtable.h). It will return NULL of
the PTE is not present too, so no need to dbl check that. That way, I
won't have to fix your copy of the function when I get the proper 4L
headers patch in ;)
> /*
> * The error_code parameter is
> * - DSISR for a non-SLB data access fault,
> @@ -94,6 +109,7 @@ int do_page_fault(struct pt_regs *regs,
> unsigned long is_write = error_code & 0x02000000;
> unsigned long trap = TRAP(regs);
> unsigned long is_exec = trap == 0x400;
> + pte_t *ptep;
> BUG_ON((trap == 0x380) || (trap == 0x480));
> @@ -253,6 +269,15 @@ bad_area_nosemaphore:
Can you try to limit to 80 columns ? (I know, I'm not the best for that
neither, but I'm trying to cure myself here, I promise my next rewrite
of radeonfb will be fully 80-columns safe :)
- ... @vger.kernel.org http://vger.kernel.org/majordomo-info.html http://www.tux.org/lkml/
You must
Sign in before you can post messages.
You do not have the permission required to post.
Newsgroups: linux.kernel
From:
o... @austin.ibm.com (Olof Johansson) Date: Thu, 10 Mar 2005 04:40:09 +0100
Local: Wed, Mar 9 2005 10:40 pm
Subject: Re: [PATCH 1/2] No-exec support for ppc64
On Tue, Mar 08, 2005 at 05:08:26PM -0600, Jake Moilanen wrote:
Hi, a couple of comments below.
-Olof
> @@ -786,6 +786,7 @@ int hash_huge_page(struct mm_struct *mm,
> pte_t old_pte, new_pte;
> unsigned long hpteflags, prpn;
> long slot;
> + int is_exec;
> int err = 1;
> spin_lock(&mm->page_table_lock);
> + is_exec = access & _PAGE_EXEC;
You only use is_exec this one time, you can probably skip it and just
add the mask in the if statement.
> @@ -898,6 +908,7 @@ repeat:
> err = 0;
> out:
Whitespace change
> diff -puN include/asm-ppc64/pgtable.h~nx-user-ppc64 include/asm-ppc64/pgtable.h
Good to see the comment there, I remember we talked about that earlier.
It can be somewhat confusing. :-)
> #define _PAGE_GUARDED 0x0008
Can you break it into 80 columns with \ ?
- ... @vger.kernel.org http://vger.kernel.org/majordomo-info.html http://www.tux.org/lkml/
You must
Sign in before you can post messages.
You do not have the permission required to post.
Newsgroups: linux.kernel
From:
o... @austin.ibm.com (Olof Johansson) Date: Thu, 10 Mar 2005 04:50:06 +0100
Local: Wed, Mar 9 2005 10:50 pm
Subject: Re: [PATCH 2/2] No-exec support for ppc64
Hi,
On Tue, Mar 08, 2005 at 05:13:26PM -0600, Jake Moilanen wrote:
> diff -puN arch/ppc64/mm/hash_utils.c~nx-kernel-ppc64 arch/ppc64/mm/hash_utils.c
> --- linux-2.6-bk/arch/ppc64/mm/hash_utils.c~nx-kernel-ppc64 2005-03-08 16:08:57 -06:00
> +++ linux-2.6-bk-moilanen/arch/ppc64/mm/hash_utils.c 2005-03-08 16:08:57 -06:00
> @@ -89,12 +90,23 @@ static inline void loop_forever(void)
> ;
> }
> +int is_kernel_text(unsigned long addr)
This is used in two files, but never declared extern in the second file
(iSeries_setup.c). Should it go in a header file as a static inline
instead?
There also seems to be a local static is_kernel_text() in kallsyms that
-Olof ... @vger.kernel.org http://vger.kernel.org/majordomo-info.html http://www.tux.org/lkml/
You must
Sign in before you can post messages.
You do not have the permission required to post.
Newsgroups: linux.kernel
From:
Benjamin Herrenschmidt <b... @kernel.crashing.org> Date: Thu, 10 Mar 2005 08:30:13 +0100
Local: Thurs, Mar 10 2005 2:30 am
Subject: Re: [PATCH 2/2] No-exec support for ppc64
On Wed, 2005-03-09 at 21:25 -0600, Olof Johansson wrote:
> Hi,
> On Tue, Mar 08, 2005 at 05:13:26PM -0600, Jake Moilanen wrote:
> > +int is_kernel_text(unsigned long addr)
> This is used in two files, but never declared extern in the second file
Yes, I think it should.
> There also seems to be a local static is_kernel_text() in kallsyms that
> overlaps (but it's not identical). Removing that redundancy can be taken
> care of as a janitorial patch outside of the noexec stuff.
> -Olof ... @ozlabs.org https://ozlabs.org/cgi-bin/mailman/listinfo/linuxppc64-dev
--
Benjamin Herrenschmidt <b
... @kernel.crashing.org>
- ... @vger.kernel.org http://vger.kernel.org/majordomo-info.html http://www.tux.org/lkml/
You must
Sign in before you can post messages.
You do not have the permission required to post.
Newsgroups: linux.kernel
From:
Jake Moilanen <moila... @austin.ibm.com> Date: Thu, 10 Mar 2005 23:50:12 +0100
Local: Thurs, Mar 10 2005 5:50 pm
Subject: Re: [PATCH 1/2] No-exec support for ppc64
On Wed, 9 Mar 2005 21:22:13 -0600
o
... @austin.ibm.com (Olof Johansson) wrote:
> On Tue, Mar 08, 2005 at 05:08:26PM -0600, Jake Moilanen wrote:
> > No-exec base and user space support for PPC64.
> Hi, a couple of comments below.
Here's the revised user & base support for no-exec on ppc64 with Olof
and Ben's comments.
Signed-off-by: Jake Moilanen <moila... @austin.ibm.com>
---
linux-2.6-bk-moilanen/arch/ppc64/kernel/head.S | 5 +
diff -puN arch/ppc64/kernel/head.S~nx-user-ppc64 arch/ppc64/kernel/head.S
#ifdef CONFIG_PPC_ISERIES
/*
HvCallHpt_get(&hpte, slot);
- flags = newpp & 3;
BUG_ON(lpar_rc != H_Success);
BUG_ON((trap == 0x380) || (trap == 0x480));
@@ -199,16 +200,19 @@ int do_page_fault(struct pt_regs *regs,
+ if (is_exec) {
diff -puN arch/ppc64/mm/hash_low.S~nx-user-ppc64 arch/ppc64/mm/hash_low.S
+ if (unlikely((access & _PAGE_EXEC) && !(pte_val(*ptep) & _PAGE_EXEC)))
- hpteflags = 0x2 | (! (pte_val(new_pte) & _PAGE_RW));
/* Check if pte already has an hpte (case 2) */
/*
#define virt_addr_valid(kaddr) pfn_valid(__pa(kaddr) >> PAGE_SHIFT)
-#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \
#endif /* __KERNEL__ */
read more »
You must
Sign in before you can post messages.
You do not have the permission required to post.
Newsgroups: linux.kernel
From:
Benjamin Herrenschmidt <b... @kernel.crashing.org> Date: Fri, 11 Mar 2005 00:10:09 +0100
Local: Thurs, Mar 10 2005 6:10 pm
Subject: Re: [PATCH 2/2] No-exec support for ppc64
> /* Free memory returned from module_alloc */
> diff -puN arch/ppc64/mm/fault.c~nx-kernel-ppc64 arch/ppc64/mm/fault.c
> --- linux-2.6-bk/arch/ppc64/mm/fault.c~nx-kernel-ppc64 2005-03-10 13:54:14 -06:00
> +++ linux-2.6-bk-moilanen/arch/ppc64/mm/fault.c 2005-03-10 13:54:14 -06:00
> @@ -76,6 +76,13 @@ static int store_updates_sp(struct pt_re
> return 0;
> }
> +pte_t *lookup_address(unsigned long address)
static please, even inline in this case.
I've removed Andrew from CC upon his request, Paul, Anton or I will
Ben.
- ... @vger.kernel.org http://vger.kernel.org/majordomo-info.html http://www.tux.org/lkml/
You must
Sign in before you can post messages.
You do not have the permission required to post.
Newsgroups: linux.kernel
From:
Jake Moilanen <moila... @austin.ibm.com> Date: Fri, 11 Mar 2005 00:10:08 +0100
Local: Thurs, Mar 10 2005 6:10 pm
Subject: Re: [PATCH 2/2] No-exec support for ppc64
On Thu, 10 Mar 2005 18:15:34 +1100
Benjamin Herrenschmidt <b
... @kernel.crashing.org> wrote:
> On Wed, 2005-03-09 at 21:25 -0600, Olof Johansson wrote:
> > Hi,
> > On Tue, Mar 08, 2005 at 05:13:26PM -0600, Jake Moilanen wrote:
> > > +int is_kernel_text(unsigned long addr)
> > This is used in two files, but never declared extern in the second file
> Yes, I think it should.
Here is the revised no-exec for the kernel on ppc64 w/ Olof and Ben's comments.
Signed-off-by: Jake Moilanen <moila... @austin.ibm.com>
---
linux-2.6-bk-moilanen/arch/ppc64/kernel/iSeries_setup.c | 4 +++
diff -puN arch/ppc64/kernel/iSeries_setup.c~nx-kernel-ppc64 arch/ppc64/kernel/iSeries_setup.c
+ /* Make non-kernel text non-executable */
/* Free memory returned from module_alloc */
+pte_t *lookup_address(unsigned long address)
BUG_ON((trap == 0x380) || (trap == 0x480));
@@ -253,6 +261,17 @@ bad_area_nosemaphore:
return SIGSEGV;
#ifdef DEBUG
if (large)
+
hpteg = ((hash & htab_hash_mask) * HPTES_PER_GROUP);
if (ret == -1) {
-#define PPC64_HWNOEXEC (1 << 2)
@@ -250,8 +257,8 @@ unsigned int hash_page_do_lazy_icache(un
#define HW_NO_EXEC _PAGE_EXEC /* This is used when the bit is
+
_ ... @vger.kernel.org http://vger.kernel.org/majordomo-info.html http://www.tux.org/lkml/
You must
Sign in before you can post messages.
You do not have the permission required to post.
Newsgroups: linux.kernel
From:
Jake Moilanen <moila... @austin.ibm.com> Date: Fri, 11 Mar 2005 15:20:08 +0100
Local: Fri, Mar 11 2005 9:20 am
Subject: Re: [PATCH 2/2] No-exec support for ppc64
On Fri, 11 Mar 2005 09:44:28 +1100
Benjamin Herrenschmidt <b
... @kernel.crashing.org> wrote:
> > /* Free memory returned from module_alloc */
> > +pte_t *lookup_address(unsigned long address)
> static please, even inline in this case.
> I've removed Andrew from CC upon his request, Paul, Anton or I will
3rd time is a charm.
Signed-off-by: Jake Moilanen <moila... @austin.ibm.com>
---
linux-2.6-bk-moilanen/arch/ppc64/kernel/iSeries_setup.c | 4 +++
diff -puN arch/ppc64/kernel/iSeries_setup.c~nx-kernel-ppc64 arch/ppc64/kernel/iSeries_setup.c
+ /* Make non-kernel text non-executable */
/* Free memory returned from module_alloc */
+static inline pte_t *lookup_address(unsigned long address)
BUG_ON((trap == 0x380) || (trap == 0x480));
@@ -253,6 +261,17 @@ bad_area_nosemaphore:
return SIGSEGV;
#ifdef DEBUG
if (large)
+
hpteg = ((hash & htab_hash_mask) * HPTES_PER_GROUP);
if (ret == -1) {
-#define PPC64_HWNOEXEC (1 << 2)
@@ -250,8 +257,8 @@ unsigned int hash_page_do_lazy_icache(un
#define HW_NO_EXEC _PAGE_EXEC /* This is used when the bit is
+
_ ... @vger.kernel.org http://vger.kernel.org/majordomo-info.html http://www.tux.org/lkml/
You must
Sign in before you can post messages.
You do not have the permission required to post.
Newsgroups: linux.kernel
From:
Paul Mackerras <pau... @samba.org> Date: Mon, 14 Mar 2005 11:20:12 +0100
Local: Mon, Mar 14 2005 5:20 am
Subject: Re: [PATCH 1/2] No-exec support for ppc64
Jake Moilanen writes:
I don't think I can push that upstream. What happens if you leave
that out?
More generally, we are making a user-visible change, even for programs
Paul. ... @vger.kernel.org http://vger.kernel.org/majordomo-info.html http://www.tux.org/lkml/
You must
Sign in before you can post messages.
You do not have the permission required to post.
Newsgroups: linux.kernel
From:
Jake Moilanen <moila... @austin.ibm.com> Date: Mon, 14 Mar 2005 23:20:13 +0100
Local: Mon, Mar 14 2005 5:20 pm
Subject: Re: [PATCH 1/2] No-exec support for ppc64
On Mon, 14 Mar 2005 21:13:36 +1100
Paul Mackerras <pau
... @samba.org> wrote:
> Jake Moilanen writes:
> > diff -puN fs/binfmt_elf.c~nx-user-ppc64 fs/binfmt_elf.c
> I don't think I can push that upstream. What happens if you leave
The bss and the plt are in the same segment, and plt obviously needs to
be executable.
Section Headers:
Segment Sections...
Anton mentioned that Alan was considering putting plt into a new segment.
> More generally, we are making a user-visible change, even for programs
Unless a program is compiled w/ pt_gnu_stacks we will set the
READ_IMPLIES_EXEC personality and those applications should still
work as normal.
Jake ... @vger.kernel.org http://vger.kernel.org/majordomo-info.html http://www.tux.org/lkml/
You must
Sign in before you can post messages.
You do not have the permission required to post.
Newsgroups: linux.kernel
From:
Paul Mackerras <pau... @samba.org> Date: Mon, 14 Mar 2005 23:40:14 +0100
Local: Mon, Mar 14 2005 5:40 pm
Subject: Re: [PATCH 1/2] No-exec support for ppc64
Jake Moilanen writes:
> > I don't think I can push that upstream. What happens if you leave
> > that out?
> The bss and the plt are in the same segment, and plt obviously needs to
Yes... what I was asking was "do things actually break if you leave
that out, or does the binfmt_elf loader honour the 'x' permission on
the PT_LOAD entry for the data/bss region, meaning that it all just
works anyway?"
I did an objdump -p on some random 32-bit binaries, and they all have
Paul. ... @vger.kernel.org http://vger.kernel.org/majordomo-info.html http://www.tux.org/lkml/
You must
Sign in before you can post messages.
You do not have the permission required to post.
Newsgroups: linux.kernel
From:
Jake Moilanen <moila... @austin.ibm.com> Date: Tue, 15 Mar 2005 23:10:11 +0100
Local: Tues, Mar 15 2005 5:10 pm
Subject: Re: [PATCH 1/2] No-exec support for ppc64
On Tue, 15 Mar 2005 09:18:04 +1100
Paul Mackerras <pau
... @samba.org> wrote:
> Jake Moilanen writes:
> > > I don't think I can push that upstream. What happens if you leave
> > The bss and the plt are in the same segment, and plt obviously needs to
> Yes... what I was asking was "do things actually break if you leave
It does not work w/o the sys_mprotect. It will hang in one of the first
few binaries.
I believe the problem is that the last PT_LOAD entry does not have the
Here is /bin/bash on SLES 9:
Section Headers:
Program Headers:
Section to Segment mapping:
In the program headers section, the FileSiz for the last PT_LOAD is
Did I miss something to explain this? Can you think of another way to
Jake
- ... @vger.kernel.org http://vger.kernel.org/majordomo-info.html http://www.tux.org/lkml/
You must
Sign in before you can post messages.
You do not have the permission required to post.
Newsgroups: linux.kernel
From:
Alan Modra <amo... @bigpond.net.au> Date: Wed, 16 Mar 2005 00:00:22 +0100
Local: Tues, Mar 15 2005 6:00 pm
Subject: Re: [PATCH 1/2] No-exec support for ppc64
On Tue, Mar 15, 2005 at 03:51:35PM -0600, Jake Moilanen wrote:
Huh? .sbss, .plt and .bss have no file contents, so of course p_filesz
doesn't cover them.
-- ... @vger.kernel.org http://vger.kernel.org/majordomo-info.html http://www.tux.org/lkml/
You must
Sign in before you can post messages.
You do not have the permission required to post.
Newsgroups: linux.kernel
From:
Jake Moilanen <moila... @austin.ibm.com> Date: Wed, 16 Mar 2005 00:30:11 +0100
Local: Tues, Mar 15 2005 6:30 pm
Subject: Re: [PATCH 1/2] No-exec support for ppc64
On Wed, 16 Mar 2005 09:18:36 +1030
Alan Modra <amo
... @bigpond.net.au> wrote:
> On Tue, Mar 15, 2005 at 03:51:35PM -0600, Jake Moilanen wrote:
> > I believe the problem is that the last PT_LOAD entry does not have the
> > correct size, and we only mmap up to the sbss. The .sbss, .plt, and
> > .bss do not get mmapped with the section.
> Huh? .sbss, .plt and .bss have no file contents, so of course p_filesz
Your right, those shouldn't be mmapped.
set_brk() call is called on sbss, plt and bss. There needs to be some
Jake ... @vger.kernel.org http://vger.kernel.org/majordomo-info.html http://www.tux.org/lkml/
You must
Sign in before you can post messages.
You do not have the permission required to post.
Newsgroups: linux.kernel
From:
Paul Mackerras <pau... @samba.org> Date: Wed, 16 Mar 2005 07:20:07 +0100
Local: Wed, Mar 16 2005 1:20 am
Subject: Re: [PATCH 1/2] No-exec support for ppc64
Jake Moilanen writes:
Hmmm, what distro is this with? I just tried a kernel with the patch
below on a SLES9 install and a Debian install and it came up and ran
just fine in both cases.
Paul.
diff -urN linux-2.5/arch/ppc64/kernel/head.S test/arch/ppc64/kernel/head.S
/*
HvCallHpt_get(&hpte, slot);
+ /* Make non-kernel text non-executable */
/* Free memory returned from module_alloc */
- flags = newpp & 3;
BUG_ON(lpar_rc != H_Success);
BUG_ON((trap == 0x380) || (trap == 0x480));
@@ -109,7 +110,7 @@
- if (error_code & 0x00400000) {
+ if (is_exec) {
@@ -251,6 +255,12 @@
+ if (trap == 0x400 && (error_code & DSISR_PROTFAULT)
/*
#ifdef DEBUG
if (large)
+
hpteg = ((hash & htab_hash_mask) * HPTES_PER_GROUP);
if (ret == -1) {
-#define PPC64_HWNOEXEC (1 << 2)
@@ -251,7 +258,7 @@
hpteflags = 0x2 | (! (pte_val(new_pte) & _PAGE_RW));
/* Check if pte already has an hpte (case 2) */
/*
#define virt_addr_valid(kaddr) pfn_valid(__pa(kaddr) >> PAGE_SHIFT)
-#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \
+#define VM_STACK_DEFAULT_FLAGS32 (VM_READ | VM_WRITE | VM_EXEC | \
read more »
You must
Sign in before you can post messages.
You do not have the permission required to post.
Newsgroups: linux.kernel
From:
Jake Moilanen <moila... @austin.ibm.com> Date: Wed, 16 Mar 2005 23:10:14 +0100
Local: Wed, Mar 16 2005 5:10 pm
Subject: Re: [PATCH 1/2] No-exec support for ppc64
On Wed, 16 Mar 2005 17:10:57 +1100
Paul Mackerras <pau
... @samba.org> wrote:
> Jake Moilanen writes:
> > It does not work w/o the sys_mprotect. It will hang in one of the first
> Hmmm, what distro is this with? I just tried a kernel with the patch
I'm not sure that the patch you sent is actually doing protection
correctly.
To test I commented out this line:
> +#define elf_read_implies_exec(ex, have_pt_gnu_stack) (!(have_pt_gnu_stack))
and then ran a non-pt_gnu_stack binary which should have executed on a non-exec
segment, it did not segfault.
> + *
I think the problem was this hunk. __P011 should be PAGE_COPY and
__P100 should be PAGE_READONLY_X.
Here is a patch ontop of the last patch you sent to fix this problem and
Signed-off-by: Jake Moilanen <moila... @austin.ibm.com>
---
linux-2.6.11.4-paulus-moilanen/fs/binfmt_elf.c | 18 +++++++++----
diff -puN fs/binfmt_elf.c~more-nx fs/binfmt_elf.c
#define BAD_ADDR(x) ((unsigned long)(x) > TASK_SIZE)
-static int set_brk(unsigned long start, unsigned long end)
k = elf_ppnt->p_vaddr + elf_ppnt->p_filesz;
- if (k > elf_bss)
loc->elf_ex.e_entry += load_bias;
_ ... @vger.kernel.org http://vger.kernel.org/majordomo-info.html http://www.tux.org/lkml/
You must
Sign in before you can post messages.
You do not have the permission required to post.
|
