> warning: (UX500_SOC_COMMON) selects PL310_ERRATA_753970 which has unmet direct dependencies (CACHE_PL310)
> warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC && UX500_SOC_COMMON) selects ARM_ERRATA_764369 which has unmet direct dependencies (CPU_V7 && SMP)

> Signed-off-by: Arnd Bergmann <a...@arndb.de>
> Cc: Linus Walleij <linus.wall...@linaro.org>
> Cc: Stephen Warren <swar...@wwwdotorg.org>

> #ifdef drop code coverage

> > Without this patch, building at91x40_defconfig results in:

> > arch/arm/mach-at91/setup.c:90:24: warning: 'at91_io_desc' defined but not used [-Wunused-variable]
> I prefer a __maybe_unused on the struct so the compilator will just drop it

> It has CONFIG_MEMORY_SIZE=0x1e800000.

> So what I suspect has happened is that an extra zero has crept into
> arch/arm/configs/kota2_defconfig and the intended value is:

> CONFIG_MEMORY_SIZE=0x1e000000

> Unfortunately I do not have access to a board to test this,
> nor am I aware of anyone who does.

> > It has CONFIG_MEMORY_SIZE=0x1e800000.

> > So what I suspect has happened is that an extra zero has crept into
> > arch/arm/configs/kota2_defconfig and the intended value is:

> > CONFIG_MEMORY_SIZE=0x1e000000

> > Unfortunately I do not have access to a board to test this,
> > nor am I aware of anyone who does.

> Ok, I'll drop this patch for now then, so we keep the warning around
> to remind us of the problem.

> On Tue, Oct 2, 2012 at 10:36 AM, Arnd Bergmann <a...@arndb.de> wrote:
> > pci_scan_root_bus is __devinit, so iop13xx_scan_bus has to be the
> > same in order to safely call it. This is ok because the function
> > itself is only called from the hwpci->scan callback.

> > WARNING: vmlinux.o(.text+0x10138): Section mismatch in reference from the function iop13xx_scan_bus() to the function .devinit.text:pci_scan_root_bus()
> > The function iop13xx_scan_bus() references
> > the function __devinit pci_scan_root_bus().
> > This is often because iop13xx_scan_bus lacks a __devinit
> > annotation or the annotation of pci_scan_root_bus is wrong.

> With CONFIG_HOTPLUG going away (I think the current state is that it
> is always set to "y"), __devinit will effectively become a no-op, so I
> expect we'll remove it from pci_scan_root_bus().

> Therefore, I would skip this patch and live with the warning a little longer.

> Without this patch, building da8xx_omapl_defconfig results in:

> WARNING: arch/arm/mach-davinci/built-in.o(.text+0x2eb4): Section mismatch in reference from the function read_factory_config() to the function .init.text:da850_register_cpufreq()
> The function read_factory_config() references
> the function __init da850_register_cpufreq().
> This is often because read_factory_config lacks a __init
> annotation or the annotation of da850_register_cpufreq is wrong.

> Signed-off-by: Arnd Bergmann <a...@arndb.de>
> Cc: Sekhar Nori <nsek...@ti.com>
> Cc: Kevin Hilman <khil...@ti.com>

> > #ifdef drop code coverage

> Ok, agreed. Here is the new version:

> From bacd47abb36104665261c84f6f85bba7aef8a521 Mon Sep 17 00:00:00 2001
> From: Arnd Bergmann <a...@arndb.de>
> Date: Mon, 30 Apr 2012 13:00:32 +0000
> Subject: [PATCH] ARM: at91: unused variable in at91_pm_verify_clocks

> The code using the variable 'i' in this function is conditional which
> results in a harmless compiler warning. Using the IS_ENABLED macro
> instead of #ifdef makes the code look nicer and gets rid of the
> warning.

> Without this patch, building at91sam9263_defconfig results in:

> /home/arnd/linux-arm/arch/arm/mach-at91/pm.c: In function 'at91_pm_verify_clocks':
> /home/arnd/linux-arm/arch/arm/mach-at91/pm.c:137:6: warning: unused variable 'i' [-Wunused-variable]

> Signed-off-by: Arnd Bergmann <a...@arndb.de>
> Cc: Nicolas Ferre <nicolas.fe...@atmel.com>
> Cc: Jean-Christophe Plagniol-Villard <plagn...@jcrosoft.com>

> On Tuesday 02 October 2012, Bjorn Helgaas wrote:

> > On Tue, Oct 2, 2012 at 10:36 AM, Arnd Bergmann <a...@arndb.de> wrote:
> > > pci_scan_root_bus is __devinit, so iop13xx_scan_bus has to be the
> > > same in order to safely call it. This is ok because the function
> > > itself is only called from the hwpci->scan callback.

> > > WARNING: vmlinux.o(.text+0x10138): Section mismatch in reference from the function iop13xx_scan_bus() to the function .devinit.text:pci_scan_root_bus()
> > > The function iop13xx_scan_bus() references
> > > the function __devinit pci_scan_root_bus().
> > > This is often because iop13xx_scan_bus lacks a __devinit
> > > annotation or the annotation of pci_scan_root_bus is wrong.

> > With CONFIG_HOTPLUG going away (I think the current state is that it
> > is always set to "y"), __devinit will effectively become a no-op, so I
> > expect we'll remove it from pci_scan_root_bus().

> > Therefore, I would skip this patch and live with the warning a little longer.

> Hmm, I'm just trying to get rid of all build time warnings in the defconfigs
> right now, and modpost still complains about the section mismatches. I have
> a bunch more of these patches, but it would also be fine with me if we can
> patch mostpost to ignore these cases.

> I've also redone the analysis that Greg cited in the commit message for
> 45f035ab9b8 "CONFIG_HOTPLUG should be always on"

>    It is quite hard to disable it these days, and even if you do, it
>     only saves you about 200 bytes.  However, if it is disabled, lots of
>     bugs show up because it is almost never tested if the option is disabled.

> My test case (ARM omap2plus_defconfig, one of the most common configurations)
> shows these size -A differences:

> section            nohotplug       hotplug         difference
> .head.text 392             392             0
> .text              4829940         4881140         51200
> .rodata            1630360         1633056         2696
> __ksymtab  25720           25720           0
> __ksymtab_gpl      17096           17136           40
> __kcrctab  12860           12860           0
> __kcrctab_gpl      8548            8568            20
> __ksymtab_stri     96427           96509           82
> __init_rodata      0               9800            9800
> __param            2320            2320            0
> __modver   716             364             -352
> .ARM.unwind_idx    160360          160792          432
> .ARM.unwind_tab    24312           24312           0
> .init.text 234632          195688          -38944
> .exit.text 8680            5116            -3564
> .init.proc.info    312             312             0
> .init.arch.info    2964            2964            0
> .init.tagtable     72              72              0
> .init.smpalt       776             776             0
> .init.pv_table     880             880             0
> .init.data 123356          111348          -12008
> .exit.data 0               0               0
> .data..percpu      12928           12928           0
> .data              560160          562688          2528
> .notes             36              36              0
> .bss               5605324         5605580         256

> total              13359171        13371357        12186
> after boot 13001183        13054521        53338

> That is over 50kb difference after discarding the init sections,
> significantly more than the 200 bytes that Greg found.
> The point about lack of testing is still valid of course, and I'm
> not saying we need to keep the option around, but it's really
> not as obvious as before. An argument in favor of removing the
> __devinit logic is that these 50kb is still just 0.4% of the
> kernel size.

> For the five ARM defconfig files that actually turn off hotplug,
> the absolute numbers are a bit lower, but the percentage is similar.

> This is the amount of space wasted by enabling on CONFIG_HOTPLUG
> on them, in bytes after discarding the init sections, and as a
> percentage of the vmlinux size:

> at91x40_defconfig  3448    0.27%
> edb7211_defconfig  8912    0.41%
> footbridge_defconfig       33347   0.97%
> fortunet_defconfig 4592    0.25%
> pleb_defconfig             7405    0.28%

> Footbridge is the only config among these that enables PCI and USB, so
> it has a bunch more drivers that actually have notable functions that
> can be discarded.

> The defconfig does not have this problem because it enables imx6
> as well, but disabling it leads to this warning:

> arch/arm/mach-imx/built-in.o: In function `v7_cpu_resume':
> arch/arm/mach-imx/head-v7.S:104: undefined reference to `cpu_resume'

> Signed-off-by: Arnd Bergmann <a...@arndb.de>
> Cc: Sascha Hauer <ker...@pengutronix.de>
> Cc: Shawn Guo <shawn....@linaro.org>
> ---
>  arch/arm/mach-imx/Kconfig |    1 +
>  1 file changed, 1 insertion(+)

> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index afd542a..8e96573 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -89,6 +89,7 @@ config SOC_IMX5
>    select ARCH_MXC_IOMUX_V3
>    select ARCH_HAS_CPUFREQ
>    select ARCH_MX5
> +  select ARM_CPU_SUSPEND if PM
>    bool

>  config SOC_IMX50
> --
> 1.7.10

> http://thread.gmane.org/gmane.linux.ports.arm.kernel/183222/focus=134...

> Without this patch, building corgi_defconfig results in:

> /home/arnd/linux-arm/arch/arm/mach-pxa/sharpsl_pm.c:693:12: warning: 'sharpsl_fatal_check' defined but not used [-Wunused-function]

> Signed-off-by: Arnd Bergmann <a...@arndb.de>
> Cc: Pavel Machek <pa...@ucw.cz>
> Cc: Stanislav Brabec <u...@penguin.cz>
> Cc: Eric Miao <eric.y.m...@gmail.com>
> Cc: Haojian Zhuang <haojian.zhu...@gmail.com>

> diff --git a/arch/arm/mach-pxa/sharpsl_pm.c b/arch/arm/mach-pxa/sharpsl_pm.c
> index bdf4cb8..6c9658f 100644
> --- a/arch/arm/mach-pxa/sharpsl_pm.c
> +++ b/arch/arm/mach-pxa/sharpsl_pm.c
> @@ -55,7 +55,6 @@
>  #ifdef CONFIG_PM
>  static int sharpsl_off_charge_battery(void);
>  static int sharpsl_check_battery_voltage(void);
> -static int sharpsl_fatal_check(void);
>  #endif
>  static int sharpsl_check_battery_temp(void);
>  static int sharpsl_ac_check(void);
> @@ -686,53 +685,6 @@ static int corgi_pxa_pm_enter(suspend_state_t state)
>         return 0;
>  }

> -/*
> - * Check for fatal battery errors
> - * Fatal returns -1
> - */
> -static int sharpsl_fatal_check(void)
> -{
> -       int buff[5], temp, i, acin;
> -
> -       dev_dbg(sharpsl_pm.dev, "sharpsl_fatal_check entered\n");
> -
> -       /* Check AC-Adapter */
> -       acin = sharpsl_pm.machinfo->read_devdata(SHARPSL_STATUS_ACIN);
> -
> -       if (acin && (sharpsl_pm.charge_mode == CHRG_ON)) {
> -               sharpsl_pm.machinfo->charge(0);
> -               udelay(100);
> -               sharpsl_pm.machinfo->discharge(1);      /* enable discharge */
> -               mdelay(SHARPSL_WAIT_DISCHARGE_ON);
> -       }
> -
> -       if (sharpsl_pm.machinfo->discharge1)
> -               sharpsl_pm.machinfo->discharge1(1);
> -
> -       /* Check battery : check inserting battery ? */
> -       for (i = 0; i < 5; i++) {
> -               buff[i] = sharpsl_pm.machinfo->read_devdata(SHARPSL_BATT_VOLT);
> -               mdelay(SHARPSL_CHECK_BATTERY_WAIT_TIME_VOLT);
> -       }
> -
> -       if (sharpsl_pm.machinfo->discharge1)
> -               sharpsl_pm.machinfo->discharge1(0);
> -
> -       if (acin && (sharpsl_pm.charge_mode == CHRG_ON)) {
> -               udelay(100);
> -               sharpsl_pm.machinfo->charge(1);
> -               sharpsl_pm.machinfo->discharge(0);
> -       }
> -
> -       temp = get_select_val(buff);
> -       dev_dbg(sharpsl_pm.dev, "sharpsl_fatal_check: acin: %d, discharge voltage: %d, no discharge: %ld\n", acin, temp, sharpsl_pm.machinfo->read_devdata(SHARPSL_BATT_VOLT));
> -
> -       if ((acin && (temp < sharpsl_pm.machinfo->fatal_acin_volt)) ||
> -                       (!acin && (temp < sharpsl_pm.machinfo->fatal_noacin_volt)))
> -               return -1;
> -       return 0;
> -}
> -
>  static int sharpsl_off_charge_error(void)
>  {
>         dev_err(sharpsl_pm.dev, "Offline Charger: Error occurred.\n");
> --
> 1.7.10

>> Without this patch, building corgi_defconfig results in:

>> /home/arnd/linux-arm/arch/arm/mach-pxa/sharpsl_pm.c:693:12: warning: 'sharpsl_fatal_check' defined but not used [-Wunused-function]

>> Signed-off-by: Arnd Bergmann <a...@arndb.de>
>> Cc: Pavel Machek <pa...@ucw.cz>
>> Cc: Stanislav Brabec <u...@penguin.cz>
>> Cc: Eric Miao <eric.y.m...@gmail.com>
>> Cc: Haojian Zhuang <haojian.zhu...@gmail.com>

> Acked-by: Eric Miao <eric.y.m...@gmail.com>

> Let's get it cleaned up firstly. One can always reference the history for a
> sample implementation later if this is needed in the future.

>> > It has CONFIG_MEMORY_SIZE=0x1e800000.

>> > So what I suspect has happened is that an extra zero has crept into
>> > arch/arm/configs/kota2_defconfig and the intended value is:

>> > CONFIG_MEMORY_SIZE=0x1e000000

>> > Unfortunately I do not have access to a board to test this,
>> > nor am I aware of anyone who does.

>> Ok, I'll drop this patch for now then, so we keep the warning around
>> to remind us of the problem.

> Thanks. I have subsequently located a Kota2 board,
> however it may be a little while before I get my hands on it.

> On Thu, Oct 4, 2012 at 1:58 AM, Simon Horman <ho...@verge.net.au> wrote:
> > On Thu, Oct 04, 2012 at 08:34:54AM +0000, Arnd Bergmann wrote:
> >> On Wednesday 03 October 2012, Simon Horman wrote:
> >> > I looked through my fines and found a config that I believe
> >> > worked with a derivative of 2.6.35.7.

> >> > It has CONFIG_MEMORY_SIZE=0x1e800000.

> >> > So what I suspect has happened is that an extra zero has crept into
> >> > arch/arm/configs/kota2_defconfig and the intended value is:

> >> > CONFIG_MEMORY_SIZE=0x1e000000

> >> > Unfortunately I do not have access to a board to test this,
> >> > nor am I aware of anyone who does.

> >> Ok, I'll drop this patch for now then, so we keep the warning around
> >> to remind us of the problem.

> > Thanks. I have subsequently located a Kota2 board,
> > however it may be a little while before I get my hands on it.

> Gentle ping. I just came across this warning again so I figured I'd check.

> On Thu, Oct 4, 2012 at 1:58 AM, Simon Horman <ho...@verge.net.au> wrote:
> > On Thu, Oct 04, 2012 at 08:34:54AM +0000, Arnd Bergmann wrote:
> >> On Wednesday 03 October 2012, Simon Horman wrote:
> >> > I looked through my fines and found a config that I believe
> >> > worked with a derivative of 2.6.35.7.

> >> > It has CONFIG_MEMORY_SIZE=0x1e800000.

> >> > So what I suspect has happened is that an extra zero has crept into
> >> > arch/arm/configs/kota2_defconfig and the intended value is:

> >> > CONFIG_MEMORY_SIZE=0x1e000000

> >> > Unfortunately I do not have access to a board to test this,
> >> > nor am I aware of anyone who does.

> >> Ok, I'll drop this patch for now then, so we keep the warning around
> >> to remind us of the problem.

> > Thanks. I have subsequently located a Kota2 board,
> > however it may be a little while before I get my hands on it.

> Gentle ping. I just came across this warning again so I figured I'd check.

> Ok, thanks!

> Should we mark that patch for stable backports?

> > Should we mark that patch for stable backports?

> I don't believe it warrants a stable backport as
> the board appears to function well without the change.