[PATCH] Add missing macro argument for devm_release_* family

[Hiroshi DOYU]

From: ext Hiroshi DOYU <Hirosh...@nokia.com>

Signed-off-by: Hiroshi DOYU <Hirosh...@nokia.com>
---
include/linux/ioport.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/ioport.h b/include/linux/ioport.h
index 22d2115..c813c63 100644
--- a/include/linux/ioport.h
+++ b/include/linux/ioport.h
@@ -158,9 +158,9 @@ extern struct resource * __devm_request_region(struct device *dev,
struct resource *parent, resource_size_t start,
resource_size_t n, const char *name);

-#define devm_release_region(start,n) \
+#define devm_release_region(dev,start,n) \
__devm_release_region(dev, &ioport_resource, (start), (n))
-#define devm_release_mem_region(start,n) \
+#define devm_release_mem_region(dev,start,n) \
__devm_release_region(dev, &iomem_resource, (start), (n))

extern void __devm_release_region(struct device *dev, struct resource *parent,
--
1.5.5.1.357.g1af8b

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

[Andrew Morton]

On Sat, 6 Sep 2008 04:00:23 +0300 Hiroshi DOYU <Hirosh...@nokia.com> wrote:

> From: ext Hiroshi DOYU <Hirosh...@nokia.com>
>
> Signed-off-by: Hiroshi DOYU <Hirosh...@nokia.com>
> ---
> include/linux/ioport.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/ioport.h b/include/linux/ioport.h
> index 22d2115..c813c63 100644
> --- a/include/linux/ioport.h
> +++ b/include/linux/ioport.h
> @@ -158,9 +158,9 @@ extern struct resource * __devm_request_region(struct device *dev,
> struct resource *parent, resource_size_t start,
> resource_size_t n, const char *name);
>
> -#define devm_release_region(start,n) \
> +#define devm_release_region(dev,start,n) \
> __devm_release_region(dev, &ioport_resource, (start), (n))
> -#define devm_release_mem_region(start,n) \
> +#define devm_release_mem_region(dev,start,n) \
> __devm_release_region(dev, &iomem_resource, (start), (n))
>
> extern void __devm_release_region(struct device *dev, struct resource *parent,

um, OK.

But none of these things appear to have any callers anywhere. Why
don't we just delete it all?

[Hiroshi DOYU]

From: "ext Andrew Morton" <ak...@linux-foundation.org>
Subject: Re: [PATCH] Add missing macro argument for devm_release_* family
Date: Fri, 5 Sep 2008 18:52:54 -0700

> On Sat, 6 Sep 2008 04:00:23 +0300 Hiroshi DOYU <Hirosh...@nokia.com> wrote:
>
> > From: ext Hiroshi DOYU <Hirosh...@nokia.com>
> >
> > Signed-off-by: Hiroshi DOYU <Hirosh...@nokia.com>
> > ---
> > include/linux/ioport.h | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/ioport.h b/include/linux/ioport.h
> > index 22d2115..c813c63 100644
> > --- a/include/linux/ioport.h
> > +++ b/include/linux/ioport.h
> > @@ -158,9 +158,9 @@ extern struct resource * __devm_request_region(struct device *dev,
> > struct resource *parent, resource_size_t start,
> > resource_size_t n, const char *name);
> >
> > -#define devm_release_region(start,n) \
> > +#define devm_release_region(dev,start,n) \
> > __devm_release_region(dev, &ioport_resource, (start), (n))
> > -#define devm_release_mem_region(start,n) \
> > +#define devm_release_mem_region(dev,start,n) \
> > __devm_release_region(dev, &iomem_resource, (start), (n))
> >
> > extern void __devm_release_region(struct device *dev, struct resource *parent,
>
> um, OK.
>
> But none of these things appear to have any callers anywhere. Why
> don't we just delete it all?

Not sure for others, but at least, I am using this in my developing
driver;)

[Andrew Morton]

yeah, I was just trolling ;)

I queued this fix for 2.6.27.