Gmail Calendar Documents Reader Web more »
Recently Visited Groups | Help | Sign in
Google Groups Home
linux.kernel
+ new post
About this group
Subscribe to this group
This is a Usenet group - learn more
trivial: fix checking socket() in net tstamp example
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   5 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Ali Gholami Rudi  
View profile  
 More options Nov 8, 11:00 am
Newsgroups: linux.kernel
From: Ali Gholami Rudi <a...@rudi.ir>
Date: Sun, 08 Nov 2009 17:00:02 +0100
Local: Sun, Nov 8 2009 11:00 am
Subject: [PATCH] trivial: fix checking socket() in net tstamp example
Reply | Reply to author | Forward | Print | Individual message | Show original | Report this message | Find messages by this author

Signed-off-by: Ali Gholami Rudi <a...@rudi.ir>
---
 .../networking/timestamping/timestamping.c         |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Documentation/networking/timestamping/timestamping.c b/Documentation/networking/timestamping/timestamping.c
index a7936fe..bab619a 100644
--- a/Documentation/networking/timestamping/timestamping.c
+++ b/Documentation/networking/timestamping/timestamping.c
@@ -370,7 +370,7 @@ int main(int argc, char **argv)
        }

        sock = socket(PF_INET, SOCK_DGRAM, IPPROTO_UDP);
-       if (socket < 0)
+       if (sock < 0)
                bail("socket");

        memset(&device, 0, sizeof(device));
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Patrick Ohly  
View profile  
 More options Nov 8, 12:30 pm
Newsgroups: linux.kernel
From: Patrick Ohly <patrick.o...@intel.com>
Date: Sun, 08 Nov 2009 18:30:03 +0100
Local: Sun, Nov 8 2009 12:30 pm
Subject: Re: [PATCH] trivial: fix checking socket() in net tstamp example
Reply | Reply to author | Forward | Print | Individual message | Show original | Report this message | Find messages by this author

Argh, of course you are right. FWIW, acknowledged.

--
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Ali Gholami Rudi  
View profile  
 More options Nov 8, 1:00 pm
Newsgroups: linux.kernel
From: Ali Gholami Rudi <a...@rudi.ir>
Date: Sun, 08 Nov 2009 19:00:02 +0100
Local: Sun, Nov 8 2009 1:00 pm
Subject: Re: [PATCH] trivial: fix checking socket() in net tstamp example
Reply | Reply to author | Forward | Print | Individual message | Show original | Report this message | Find messages by this author
Hi Patrick,

Patrick Ohly <patrick.o...@intel.com> wrote:
> > --- a/Documentation/networking/timestamping/timestamping.c
> > +++ b/Documentation/networking/timestamping/timestamping.c
> > @@ -370,7 +370,7 @@ int main(int argc, char **argv)
> >       }

> >       sock = socket(PF_INET, SOCK_DGRAM, IPPROTO_UDP);
> > -     if (socket < 0)
> > +     if (sock < 0)

> Argh, of course you are right. FWIW, acknowledged.

By the way, I tried igb hardware timestamp but HWTSTAMP_FILTER_ALL works
almost like HWTSTAMP_FILTER_PTP_*.  Isn't it supposed to timestamp all
of the incoming packets?  Maybe there is something wrong with my test
setup?

Thanks,
Ali
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Discussion subject changed to "What's the state of the TX timestamping?" by Emilio G. Cota
Emilio G. Cota  
View profile  
 More options Nov 8, 4:10 pm
Newsgroups: linux.kernel
From: "Emilio G. Cota" <c...@braap.org>
Date: Sun, 08 Nov 2009 22:10:02 +0100
Local: Sun, Nov 8 2009 4:10 pm
Subject: What's the state of the TX timestamping?
Reply | Reply to author | Forward | Print | Individual message | Show original | Report this message | Find messages by this author
[dropped triv...@kernel.org since this is not relevant to them]

by the way Patrick,

A few months ago I tried to implement TX timestamping for a card
I was working on [1]. I wasn't quite successful (sorry can't be more
explicit, I haven't touched it since then) and thought the reason
was that the implementation was half-baked because David reverted
it--I got to that conclusion after reading this thread in
linux-net ("TX time stamping"):

http://thread.gmane.org/gmane.linux.network/121378/

Could you please tell me what the state of TX timestamping is?
Did David revert it or not? I can't find a revert commit.

Thanks,
                Emilio

[1] http://www.ohwr.org/twiki/bin/view/OHR/WhiteRabbit/WhiteRabbit

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Discussion subject changed to "trivial: fix checking socket() in net tstamp example" by Jiri Kosina
Jiri Kosina  
View profile  
 More options Dec 18, 9:30 am
Newsgroups: linux.kernel
From: Jiri Kosina <jkos...@suse.cz>
Date: Fri, 18 Dec 2009 15:30:01 +0100
Local: Fri, Dec 18 2009 9:30 am
Subject: Re: [PATCH] trivial: fix checking socket() in net tstamp example
Reply | Reply to author | Forward | Print | Individual message | Show original | Report this message | Find messages by this author

On Sun, 8 Nov 2009, Patrick Ohly wrote:
> > diff --git a/Documentation/networking/timestamping/timestamping.c b/Documentation/networking/timestamping/timestamping.c
> > index a7936fe..bab619a 100644
> > --- a/Documentation/networking/timestamping/timestamping.c
> > +++ b/Documentation/networking/timestamping/timestamping.c
> > @@ -370,7 +370,7 @@ int main(int argc, char **argv)
> >       }

> >       sock = socket(PF_INET, SOCK_DGRAM, IPPROTO_UDP);
> > -     if (socket < 0)
> > +     if (sock < 0)

> Argh, of course you are right. FWIW, acknowledged.

Doesn't seem to be present in 2.6.33-rc1, I have applied it to my tree.

Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2009 Google