Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH -tip] x86: perf_counter AMD supports performance monitoring for K7

0 views
Skip to first unread message

Jaswinder Singh Rajput

unread,
Jun 10, 2009, 2:50:10 PM6/10/09
to

Signed-off-by: Jaswinder Singh Rajput <jaswind...@gmail.com>
---
arch/x86/kernel/cpu/perf_counter.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/cpu/perf_counter.c b/arch/x86/kernel/cpu/perf_counter.c
index 240ca56..5d56742 100644
--- a/arch/x86/kernel/cpu/perf_counter.c
+++ b/arch/x86/kernel/cpu/perf_counter.c
@@ -1436,6 +1436,10 @@ static int intel_pmu_init(void)

static int amd_pmu_init(void)
{
+ /* performance-monitoring supported from K7 */
+ if (boot_cpu_data.x86 < 7)
+ return -ENODEV;
+
x86_pmu = amd_pmu;

switch (boot_cpu_data.x86) {
--
1.6.1.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Ingo Molnar

unread,
Jun 10, 2009, 8:20:08 PM6/10/09
to

* Jaswinder Singh Rajput <jasw...@kernel.org> wrote:

>
> Signed-off-by: Jaswinder Singh Rajput <jaswind...@gmail.com>
> ---
> arch/x86/kernel/cpu/perf_counter.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/perf_counter.c b/arch/x86/kernel/cpu/perf_counter.c
> index 240ca56..5d56742 100644
> --- a/arch/x86/kernel/cpu/perf_counter.c
> +++ b/arch/x86/kernel/cpu/perf_counter.c
> @@ -1436,6 +1436,10 @@ static int intel_pmu_init(void)
>
> static int amd_pmu_init(void)
> {
> + /* performance-monitoring supported from K7 */
> + if (boot_cpu_data.x86 < 7)
> + return -ENODEV;
> +
> x86_pmu = amd_pmu;
>
> switch (boot_cpu_data.x86) {

A commit under Linux consists of three parts:

1) the title
2) the changlog
3) the body

This sloppy patch of yours manages to get _all_ three wrong:

- the title is wrong (it is incorrect)
- the changelog is wrong (it is missing)
- the body is wrong (it is broken - K7 != family 7)

What the heck is going on here?

Ingo

Jaswinder Singh Rajput

unread,
Jun 11, 2009, 1:40:07 AM6/11/09
to

oops, sorry here is updated patch :

[PATCH -tip] x86: perf_counter check AMD performance monitoring support

AMD supports performance monitoring from K7.

Signed-off-by: Jaswinder Singh Rajput <jaswind...@gmail.com>
---
arch/x86/kernel/cpu/perf_counter.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/cpu/perf_counter.c b/arch/x86/kernel/cpu/perf_counter.c
index 57ae1be..719a7d5 100644
--- a/arch/x86/kernel/cpu/perf_counter.c
+++ b/arch/x86/kernel/cpu/perf_counter.c
@@ -1452,6 +1452,10 @@ static int intel_pmu_init(void)



static int amd_pmu_init(void)
{
+ /* performance-monitoring supported from K7 */

+ if (boot_cpu_data.x86 < 6)


+ return -ENODEV;
+
x86_pmu = amd_pmu;

switch (boot_cpu_data.x86) {

--
1.6.3.2


> What the heck is going on here?
>

hmm, I am really surprise how I wrote Signed-off-by line correct, I was
really very upset at that time, and you know the reason, Please help
me ;-)

Thanks,
--
JSR

0 new messages