Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] broadcom: Fix &&/|| confusion in bcm54xx_adjust_rxrefclk()

0 views
Skip to first unread message

Roel Kluin

unread,
Dec 30, 2009, 11:50:02 AM12/30/09
to
This always evaluates to true.

Signed-off-by: Roel Kluin <roel....@gmail.com>
---
drivers/net/phy/broadcom.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
index c13cf64..33c4b12 100644
--- a/drivers/net/phy/broadcom.c
+++ b/drivers/net/phy/broadcom.c
@@ -331,8 +331,8 @@ static void bcm54xx_adjust_rxrefclk(struct phy_device *phydev)
bool clk125en = true;

/* Abort if we are using an untested phy. */
- if (BRCM_PHY_MODEL(phydev) != PHY_ID_BCM57780 ||
- BRCM_PHY_MODEL(phydev) != PHY_ID_BCM50610 ||
+ if (BRCM_PHY_MODEL(phydev) != PHY_ID_BCM57780 &&
+ BRCM_PHY_MODEL(phydev) != PHY_ID_BCM50610 &&
BRCM_PHY_MODEL(phydev) != PHY_ID_BCM50610M)
return;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

David Miller

unread,
Jan 4, 2010, 1:10:01 AM1/4/10
to
From: Roel Kluin <roel....@gmail.com>
Date: Wed, 30 Dec 2009 17:43:06 +0100

> This always evaluates to true.
>
> Signed-off-by: Roel Kluin <roel....@gmail.com>

Applied, thanks Roel.

0 new messages