Bug#692122: unblock: ampache/ampache-3.6-git408e713+dfsg-3.1

Charlie Smotherman

unread,

Nov 2, 2012, 8:30:01 AM11/2/12

to

Package: release.debian.org
Severity: normal
User: release.d...@packages.debian.org
Usertags: unblock

Please unblock package ampache

Ampache has been NMU'd please unblock

unblock ampache/ampache-3.6-git408e713+dfsg-3.1

-- System Information:
Debian Release: wheezy/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-3-686-pae (SMP w/1 CPU core)

debdiff.txt

Julien Cristau

unread,

Nov 11, 2012, 12:40:03 PM11/11/12

to

tag 692122 moreinfo
kthxbye

On Fri, Nov 2, 2012 at 02:17:00 -0500, Charlie Smotherman wrote:

> diff -Nru ampache-3.6-git408e713+dfsg/debian/ampache.postrm ampache-3.6-git408e713+dfsg/debian/ampache.postrm
> --- ampache-3.6-git408e713+dfsg/debian/ampache.postrm 2012-06-07 00:44:04.000000000 -0500
> +++ ampache-3.6-git408e713+dfsg/debian/ampache.postrm 2012-10-14 10:13:27.000000000 -0500
> @@ -4,24 +4,6 @@
>
> . /usr/share/debconf/confmodule
>
> -rm_log(){
> - if [ -d /var/log/ampache ]; then
> - rm -rf /var/log/ampache
> - fi
> -}
> -
> -rm_logr(){
> - if [ -f /etc/logrotate.d/ampache ]; then
> - rm -f /etc/logrotate.d/ampache
> - fi
> -}
> -
> -rm_cron(){
> - if [ -f /etc/cron.daily/ampache ]; then
> - rm -f /etc/cron.daily/ampache
> - fi
> -}
> -

Why is this removed entirely? Surely you still need to clean things up
in postrm purge?

> restart_server(){
> if [ -e /var/run/apache2.pid ]; then
> service apache2 reload
> @@ -32,25 +14,14 @@
> db_get ampache/restart_webserver || true
> re_start="$RET"
> if [ "$re_start" = "false" ]; then
> - rm_log
> - rm_logr
> - rm_cron
> + printf "Please restart the web server manually."

Why doesn't this have a newline? (Why doesn't it use echo?)

> elif [ "$re_start" = "true" ]; then
> - rm_log
> - rm_logr
> - rm_cron
> restart_server
> else
> printf "unable to de-configure ampache, please do so manually.\n"
> fi
> fi
>
> -if [ "$1" = "purge" ]; then
> - if [ -d /etc/ampache ]; then
> - rm -rf /etc/ampache
> - fi
> -fi
> -

That looks wrong.

> #DEBHELPER#
>
> exit 0

Cheers,
Julien

signature.asc

Charlie Smotherman

unread,

Nov 12, 2012, 11:40:02 PM11/12/12

to

Julien, Hi

Thanks for the review :)

I have been looking at ampache a bit closer and I have found some
additional bugs. With it this late in the freeze probably the
easiest/best thing to do is to remove ampache from testing so the
release can happen. Apache is due to transition to 2.4 post release,
which I will have to do an upload for anyway. That should give me
enough time to make piuparts happy.

Best regard
Charlie Smotherman

--
To UNSUBSCRIBE, email to debian-bugs-...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listm...@lists.debian.org

Debian Bug Tracking System

unread,

Nov 25, 2012, 8:30:02 AM11/25/12

to

Your message dated Sun, 25 Nov 2012 14:23:01 +0100
with message-id <50B21BB5...@stefanbaur.de>
and subject line Closed as removal request for ampache/wheezy has been filed.
has caused the Debian Bug report #692122,
regarding unblock: ampache/ampache-3.6-git408e713+dfsg-3.1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)

--
692122: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=692122
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

debdiff.txt