Bug#672430: RFS: logisim/2.7.1-1 [ITP] -- graphical tool for designing and simulating logic circuits

[Vincent Cheng]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I'm looking for a sponsor for my package "logisim".

* Package name : logisim
Version : 2.7.1
Upstream Author : Carl Burch <log...@cburch.com>
* URL : http://ozark.hendrix.edu/~burch/logisim/
* License : GPL-2+
Programming Lang: Java
Description : graphical tool for designing and simulating logic circuits
Logisim is an educational tool for designing and simulating digital logic
circuits. With its simple toolbar interface and simulation of circuits as you
build them, it is simple enough to facilitate learning the most basic concepts
related to logic circuits. With the capacity to build larger circuits from
smaller subcircuits, and to draw bundles of wires with a single mouse drag,
Logisim can be used (and is used) to design and simulate entire CPUs for
educational purposes.

To access further information about this package, please visit the following URL:

http://mentors.debian.net/package/logisim

Alternatively, one can download the package with dget using this command:

dget -x http://mentors.debian.net/debian/pool/main/l/logisim/logisim_2.7.1-1.dsc

I would be glad if someone uploaded this package for me.

Kind regards,
Vincent Cheng

-- System Information:
Debian Release: wheezy/sid
APT prefers testing
APT policy: (700, 'testing'), (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_CA.utf8, LC_CTYPE=en_CA.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash



--
To UNSUBSCRIBE, email to debian-bugs-...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listm...@lists.debian.org

[Paul Wise]

On Fri, May 11, 2012 at 8:48 AM, Vincent Cheng wrote:

> I'm looking for a sponsor for my package "logisim".

I don't intend to sponsor this but here is a review:

src/com/cburch/logisim/file/ReaderInputStream.java is Apache 2.0
licensed, not GPL. That isn't compatible with GPLv2 but since the rest
of the code is GPLv2+ that seems to be Ok (GPLv3 is compatible), I
wonder why it is licenced that way though, perhaps you could ask
upstream.

Please install resources/logisim/img/logisim-icon-*.png to
/usr/share/icons/hicolor/*/apps/logisim.png and put Icon=logisim in
the .desktop file.

doc/search_lookup_*/ look like generated files, is it possible to
build those on Debian? If not they should probably be removed.

A bunch of the icons and images mention they were created in the GIMP,
I wonder if upstream has GIMP XCF files lying around. I also wonder
about the fonts used.

lintian complaints that are bugs in lintian should not get overridden.
Since a bug is already filed, you should either ignore the warning and
or send a patch to the lintian maintainers.

There are a number of duplicate and triplicate files. Please see if it
is possible for upstream to de-duplicate them or to use symlinks to
de-duplicate them on Debian.

Please send upstream a patch for the unwanted BOM. Wow,
get-orig-source is ugly, it would be nice if upstream released sane
source tarballs. Please contact them about that and also point them at
our upstream guide (which has some Java-related links):

http://wiki.debian.org/UpstreamGuide

The packaging in general is pretty good, you may find a sponsor with
pkg-electronics or perhaps debian-science:

http://wiki.debian.org/PkgElectronics
http://wiki.debian.org/Teams/DebianScience
http://wiki.debian.org/DebianScience
http://wiki.debian.org/DebianScience/Electronics

jlint finds a lot of issues, you might like to tell upstream about it.

lintian:

P: logisim: no-upstream-changelog

pngcheck:

$ pngcheck -q resources/logisim/img/logisim-icon-16.png
resources/logisim/img/logisim-icon-16.png this is neither a PNG or
JNG image nor a MNG stream
ERROR: resources/logisim/img/logisim-icon-16.png
$ file resources/logisim/img/logisim-icon-16.png
resources/logisim/img/logisim-icon-16.png: GIF image data, version 89a, 16 x 16

desktop-file-validate:

debian/logisim.desktop: error: (will be fatal in the future): value
"logisim-icon-128.png" for key "Icon" in group "Desktop Entry" is an
icon name with an extension, but there should be no extension as
described in the Icon Theme Specification if the value is not an
absolute path

--
bye,
pabs

http://wiki.debian.org/PaulWise

[Vincent Cheng]

On Sat, May 12, 2012 at 2:36 AM, Paul Wise <pa...@debian.org> wrote:
> On Fri, May 11, 2012 at 8:48 AM, Vincent Cheng wrote:
>
>> I'm looking for a sponsor for my package "logisim".
>
> I don't intend to sponsor this but here is a review:
>
> src/com/cburch/logisim/file/ReaderInputStream.java is Apache 2.0
> licensed, not GPL. That isn't compatible with GPLv2 but since the rest
> of the code is GPLv2+ that seems to be Ok (GPLv3 is compatible), I
> wonder why it is licenced that way though, perhaps you could ask
> upstream.
>
> Please install resources/logisim/img/logisim-icon-*.png to
> /usr/share/icons/hicolor/*/apps/logisim.png and put Icon=logisim in
> the .desktop file.

Fixed.

> doc/search_lookup_*/ look like generated files, is it possible to
> build those on Debian? If not they should probably be removed.

I'm not sure about that, will have to ask upstream.

> A bunch of the icons and images mention they were created in the GIMP,
> I wonder if upstream has GIMP XCF files lying around. I also wonder
> about the fonts used.
>
> lintian complaints that are bugs in lintian should not get overridden.
> Since a bug is already filed, you should either ignore the warning and
> or send a patch to the lintian maintainers.

Ok. I've also added a quick patch to that bug report.

> There are a number of duplicate and triplicate files. Please see if it
> is possible for upstream to de-duplicate them or to use symlinks to
> de-duplicate them on Debian.
>
> Please send upstream a patch for the unwanted BOM. Wow,
> get-orig-source is ugly, it would be nice if upstream released sane
> source tarballs. Please contact them about that and also point them at
> our upstream guide (which has some Java-related links):
>
> http://wiki.debian.org/UpstreamGuide
>
> The packaging in general is pretty good, you may find a sponsor with
> pkg-electronics or perhaps debian-science:
>
> http://wiki.debian.org/PkgElectronics
> http://wiki.debian.org/Teams/DebianScience
> http://wiki.debian.org/DebianScience
> http://wiki.debian.org/DebianScience/Electronics

Thanks, I'll ask around!

> jlint finds a lot of issues, you might like to tell upstream about it.
>
> lintian:
>
> P: logisim: no-upstream-changelog
>
> pngcheck:
>
> $ pngcheck -q resources/logisim/img/logisim-icon-16.png
> resources/logisim/img/logisim-icon-16.png  this is neither a PNG or
> JNG image nor a MNG stream
> ERROR: resources/logisim/img/logisim-icon-16.png
> $ file resources/logisim/img/logisim-icon-16.png
> resources/logisim/img/logisim-icon-16.png: GIF image data, version 89a, 16 x 16
>
> desktop-file-validate:
>
> debian/logisim.desktop: error: (will be fatal in the future): value
> "logisim-icon-128.png" for key "Icon" in group "Desktop Entry" is an
> icon name with an extension, but there should be no extension as
> described in the Icon Theme Specification if the value is not an
> absolute path

Fixed.

Thanks for the review! It looks like I have a lot to talk about with upstream...

Regards,
Vincent

[Debian Bug Tracking System]

Your message dated Sat, 26 May 2012 17:25:26 +0000
with message-id <E1SYKk2-...@ravel.debian.org>
and subject line closing RFS: logisim/2.7.1~dfsg-1 [ITP] -- graphical tool for designing and simulating logic circuits
has caused the Debian Bug report #672430,
regarding RFS: logisim/2.7.1~dfsg-1 [ITP] -- graphical tool for designing and simulating logic circuits
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


--
672430: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=672430
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems