Bug#470090: libsoap-lite-perl: "Subroutine redefined" warnings

Adam D. Barratt

unread,

Mar 8, 2008, 9:00:25 PM3/8/08

to

Package: libsoap-lite-perl
Version: 0.71-1

Hi,

Since upgrading to 0.71-1 earlier today, all my calls to SOAP servers
(specifically the Debian BTS SOAP server) through libsoap-lite-perl
result in a couple of warnings:

Subroutine LWP::UserAgent::redirect_ok redefined at /usr/share/perl5/SOAP/Transport/HTTP.pm line 41.
Subroutine LWP::Protocol::collect redefined at /usr/share/perl5/SOAP/Transport/HTTP.pm line 59.

I'm assuming these are harmless as the calls still appear to operate
correctly.

Regards,

Adam

--
To UNSUBSCRIBE, email to debian-bugs-...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listm...@lists.debian.org

gregor herrmann

unread,

Apr 3, 2008, 11:30:20 AM4/3/08

to

tag 470090 + confirmed
severity 470090 minor
thanks

On Sun, 09 Mar 2008 01:54:43 +0000, Adam D. Barratt wrote:

> result in a couple of warnings:
>
> Subroutine LWP::UserAgent::redirect_ok redefined at /usr/share/perl5/SOAP/Transport/HTTP.pm line 41.
> Subroutine LWP::Protocol::collect redefined at /usr/share/perl5/SOAP/Transport/HTTP.pm line 59.

Right, I see them here too.

A diff on lib/SOAP/Transport/HTTP.pm against the previous version
shows:

#v+
@@ -34,9 +32,10 @@
# hack for HTTP connection that returns Keep-Alive
# miscommunication (?) between LWP::Protocol and LWP::Protocol::http
# dies after timeout, but seems like we could make it work
+my $_patched = 0;
sub patch {
+ return if $_patched;
BEGIN { local ($^W) = 0; }
- no warnings "redefine";
{
sub LWP::UserAgent::redirect_ok; *LWP::UserAgent::redirect_ok = sub {1}
}
#v-

Turning off the warnings again should be rather simple by re-adding
the deleted line; I just don't feel very comfortable about
suppressing warnings in general ...

Other comments?

Cheers,
gregor
--
.''`. http://info.comodo.priv.at/ | gpg key ID: 0x00F3CFE4
: :' : debian: the universal operating system - http://www.debian.org/
`. `' member of https://www.vibe.at/ | how to reply: http://got.to/quote/
`- NP: Nick Cave & The Bad Seeds: Easy Money

signature.asc

Damyan Ivanov

unread,

Apr 3, 2008, 3:20:13 PM4/3/08

to

-=| gregor herrmann, Thu, Apr 03, 2008 at 05:19:03PM +0200 |=-

> @@ -34,9 +32,10 @@
> # hack for HTTP connection that returns Keep-Alive
> # miscommunication (?) between LWP::Protocol and LWP::Protocol::http
> # dies after timeout, but seems like we could make it work
> +my $_patched = 0;
> sub patch {
> + return if $_patched;
> BEGIN { local ($^W) = 0; }
> - no warnings "redefine";
> {
> sub LWP::UserAgent::redirect_ok; *LWP::UserAgent::redirect_ok = sub {1}
> }
> #v-
>
> Turning off the warnings again should be rather simple by re-adding
> the deleted line; I just don't feel very comfortable about
> suppressing warnings in general ...
>
> Other comments?

How about moving the `no warnings "redefine";' *inside* the curly
brackets? That would limit its scope, while still avoiding the warning.

--
dam JabberID: d...@jabber.minus273.org

signature.asc

gregor herrmann

unread,

Apr 3, 2008, 4:50:10 PM4/3/08

to

On Thu, 03 Apr 2008 22:00:23 +0300, Damyan Ivanov wrote:

> > Turning off the warnings again should be rather simple by re-adding
> > the deleted line; I just don't feel very comfortable about
> > suppressing warnings in general ...

> How about moving the `no warnings "redefine";' *inside* the curly
> brackets? That would limit its scope, while still avoiding the warning.

Sounds like a plan.

I've committed a patch along these lines.

Cheers,
gregor

--
.''`. http://info.comodo.priv.at/ | gpg key ID: 0x00F3CFE4
: :' : debian: the universal operating system - http://www.debian.org/
`. `' member of https://www.vibe.at/ | how to reply: http://got.to/quote/

`- NP: Nick Drake: Ride

signature.asc