Bug#593336: New version breaks encfs in some ways in combination with pam_encfs
Mike Swanson
testing distribution after such a serious bug was already noted. I also
ended up with a system I could not log into; thank god for
snapshot.debian.org, I was able to get 2.8.1-1.2 back and fix the
regression.
--
To UNSUBSCRIBE, email to debian-bugs-...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listm...@lists.debian.org
Miklos Szeredi
> Confirming the bug. It's quite curious how this was allowed into the
> testing distribution after such a serious bug was already noted. I also
> ended up with a system I could not log into; thank god for
> snapshot.debian.org, I was able to get 2.8.1-1.2 back and fix the
> regression.
This is a serious matter. As upstream maintainer I'm very interested
why the new version breaks pam_encfs.
Could someone who can reproduce this please do a "strace -f" of the
login process to see where it hangs?
Thanks,
Miklos
Thomas Schwery
> login process to see where it hangs?
You will find attached a trace ('strace -o login_trace -f login') of the
login process for root (a normal user would fail with a "Operation not
permitted" error).
I had to interrupt the trace because after 10 minutes, nothing more
happened ... The last line printed during login by encfs / pam-encfs is :
(Interface.cpp:165) checking if nameio/block(3:0:1) implements
nameio/block(3:0:0)
I hope i did it right.
Bests,
Thomas
Miklos Szeredi
Thomas, thanks for the quick response.
It looks like --no-canonicalize isn't working 100% correctly in
mount(8). Here's a patch to fix it. Coud you please rebuild
util-linux with this patch to verify that it fixes the hang?
Karel, does this patch look OK?
Thanks,
Miklos
---
Subject: don't canonicalize "spec" with --no-canonicalize option
"Spec" was still canonicalized despite --no-canonicalize. This
resulted in a hang during login with pam_encfs (Debian Bug#593336).
Signed-off-by: Miklos Szeredi <msze...@suse.cz>
---
mount/devname.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: util-linux-ng/mount/devname.c
===================================================================
--- util-linux-ng.orig/mount/devname.c 2009-02-23 13:33:02.000000000 +0100
+++ util-linux-ng/mount/devname.c 2010-10-07 15:54:48.000000000 +0200
@@ -8,7 +8,7 @@ spec_to_devname(const char *spec)
{
if (!spec)
return NULL;
- if (is_pseudo_fs(spec))
+ if (nocanonicalize || is_pseudo_fs(spec))
return xstrdup(spec);
return fsprobe_get_devname_by_spec(spec);
Karel Zak
> On Thu, 07 Oct 2010, Thomas Schwery wrote:
> > > Could someone who can reproduce this please do a "strace -f" of the
> > > login process to see where it hangs?
> >
> > You will find attached a trace ('strace -o login_trace -f login') of the
> > login process for root (a normal user would fail with a "Operation not
> > permitted" error).
> >
> > I had to interrupt the trace because after 10 minutes, nothing more
> > happened ... The last line printed during login by encfs / pam-encfs is :
> > (Interface.cpp:165) checking if nameio/block(3:0:1) implements
> > nameio/block(3:0:0)
>
> Thomas, thanks for the quick response.
>
> It looks like --no-canonicalize isn't working 100% correctly in
This is my mistake, I forgot that we call canonicalize() also from
fsprobe_get_devname_by_spec().
> mount(8). Here's a patch to fix it. Coud you please rebuild
> util-linux with this patch to verify that it fixes the hang?
>
> Karel, does this patch look OK?
Yes. Applied, thanks!
Karel
--
Karel Zak <kz...@redhat.com>
http://karelzak.blogspot.com
Thomas Schwery
I applied the patch you sent on my system to try, everything works fine
now !
Thanks a lot !
Regards,
Thomas
Miklos Szeredi
retitle 593336 mount: missing nocanonicalize check breaks pam_encfs in combination with fuse-2.8.4
tags 593336 + patch
thanks
On Thu, 07 Oct 2010, Thomas Schwery wrote:
> I applied the patch you sent on my system to try, everything works
> fine now !
Great, thanks. Reassigning to util-linux.