Bug#622960: Freeplane package + JMapViewer dependency

[Felix Natter]

hi Laszlo, hi Willem, hi Andrew,

I am the Freeplane package maintainer. Freeplane 1.2.x for Debian will
soon be released (if I find a sponsor shortly after the 1.2.22/23
release is done), the source code is (temporarily) here if you need it
for the FreeMind package:
https://github.com/fnatter/freeplane-debian/
(you also need these:
http://anonscm.debian.org/gitweb/?p=pkg-java/simplyhtml.git
http://anonscm.debian.org/gitweb/?p=pkg-java/libjsyntaxpane-java.git)

I am not sure whether we need freemind additionally, but I don't mind
helping a possible maintainer (the packaging source code above should
help a potential packager). One reason could be the FreeMind 1.0.0
collaboration mode, this feature is work in progress for Freeplane.

For the upcoming 1.3.x Freeplane release (upstream in a few months) I
also need the JMapViewer dependency.

I saw this bug report regarding JMapViewer (which I cc:):
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=649226

Is someone taking care of JMapViewer for Debian?
(there is no activity since 2011:
http://anonscm.debian.org/gitweb/?p=pkg-osm/jmapviewer.git;a=summary)

Thanks and Best Regards,
--
Felix Natter


--
To UNSUBSCRIBE, email to debian-bugs-...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listm...@lists.debian.org

[Andrew Harvey]

On 15/03/13 04:29, Felix Natter wrote:
> For the upcoming 1.3.x Freeplane release (upstream in a few months) I
> also need the JMapViewer dependency.
>
> I saw this bug report regarding JMapViewer (which I cc:):
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=649226
>
> Is someone taking care of JMapViewer for Debian?
> (there is no activity since 2011:
> http://anonscm.debian.org/gitweb/?p=pkg-osm/jmapviewer.git;a=summary)

I've just pushed some updates to the packaging to clean it up and
updated to the latest upstream version.

I'm happy to maintain it (unless upstream makes big changes which make
harder to package). However a DD will need to sponsor it's upload if we
want it included in Debian.

Lastly, my apologies to Laszlo who offered to sponsor it's upload back
in August last year, but I never got around to fixing up the package.
Hopefully the latest updates I've made will mean it can be sponsored and
uploaded into Debian.

Thanks all for chasing up with me on this, hopefully my original
packaging effort will not have been in vain after all.

[Laszlo Boszormenyi (GCS)]

On Fri, 2013-03-15 at 21:13 +1100, Andrew Harvey wrote:
> I've just pushed some updates to the packaging to clean it up and
> updated to the latest upstream version.

Cool! I was beginning to think about hijacking it.

> I'm happy to maintain it (unless upstream makes big changes which make
> harder to package). However a DD will need to sponsor it's upload if we
> want it included in Debian.
>
> Lastly, my apologies to Laszlo who offered to sponsor it's upload back
> in August last year, but I never got around to fixing up the package.
> Hopefully the latest updates I've made will mean it can be sponsored and
> uploaded into Debian.

Sure, it looks OK. Still, there's some things to fix. Why do you use
Java 6? Java 7 is in Debian now, see the openjdk-7-jre package.
Copyright format is now official, please use its format line[1].
BSD-2 license text lines are too long, please use a 80 chars width one.
It would be nice to 'beautify' debian/rules . The second line can show
the file format if set to: '# -*- makefile -*-'. Override targets should
be listed in the '.PHONY: ...' line at the end.
The debian/watch is essentially empty, delete it or make use of it.
Worst is that JMapViewer_Demo.jar is empty, contains only MANIFEST.MF .
Is it an upstream build problem?

Cheers,
Laszlo/GCS
[1] http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

[Andrew Harvey]

On 16/03/13 02:32, Laszlo Boszormenyi (GCS) wrote:
> Sure, it looks OK. Still, there's some things to fix. Why do you use
> Java 6? Java 7 is in Debian now, see the openjdk-7-jre package.

Changed.

> Copyright format is now official, please use its format line[1].
> BSD-2 license text lines are too long, please use a 80 chars width one.

Changed.

> It would be nice to 'beautify' debian/rules . The second line can show
> the file format if set to: '# -*- makefile -*-'. Override targets should
> be listed in the '.PHONY: ...' line at the end.

Changed. GNU Make manual suggests this should be before the definition
though...[1]

> The debian/watch is essentially empty, delete it or make use of it.

If you don't have a debian/watch lintian will tell you to either add
one, or add one with just comments explaining the situation.

> Worst is that JMapViewer_Demo.jar is empty, contains only MANIFEST.MF .
> Is it an upstream build problem?

Yes I noticed that lintian warning. I'm pretty sure this is how upstream
does it. If this is a problem, in the Debian package we can ignore the
upstream JMapViewer_Demo.jar and simply change our /usr/bin/jmapviewer
script to

java -Djava.net.useSystemProxies=true -cp
/usr/share/java/jmapviewer.jar org.openstreetmap.gui.jmapviewer.Demo "$@"

Is this a better approach? It is a pretty easy change to make.

[1] https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html