Thank you for the bug report.
I have forwarded this problem to upstream author.
I will fix it in next upload. :-)
Kind regards
Wen-Yen Chuang (caleb)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkr2xt4ACgkQdEpXpumNYVk5MgCfS+foAPsmBU+fH3JsiCmQw2yW
W7QAn0fUSwfMAOxFIkL32moNwxvphNPD
=y/+S
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to debian-bugs-...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listm...@lists.debian.org
>> gcc `pkg-config --libs x11 xtst 2> /dev/null || echo -L/usr/X11R6/lib -L/usr/local/lib -lX11 -lXtst` xdo.o keynav.o -o keynav
>> /usr/bin/ld: keynav.o: in function drawgrid:keynav.c(.text+0xcf7): error: undefined reference to 'XShapeCombineRectangles'
>> /usr/bin/ld: keynav.o: in function drawgrid:keynav.c(.text+0xdf3): error: undefined reference to 'XShapeCombineRectangles'
Looks like you debian folks use XCB? If this is correct, you can fix
the build by adding another package name to all pkg-config 'xcb-shape'
- for example:
CFLAGS=`pkg-config --cflags xcb-shape x11 xtst 2> /dev/null || echo
-I/usr/X11R6/include -I/usr/local/include`
LDFLAGS=`pkg-config --libs xcb-shape x11 xtst 2> /dev/null || echo
-L/usr/X11R6/lib -L/usr/local/lib -lX11 -lXtst -lXinerama`
Let me know if this helps.
I can't test this as I don't use debian. I can confirm that the patch
doesn't appear to break it building for me on ubuntu.
I've checked in your patch.
Can someone give me some background on what changed to cause this
build failure? Some initial questions come to mind:
* Did the a debian build system change cause this?
* Did xorg change the way they package libraries?
* Did debian change the way they package xorg?
* What does 'no-add-needed' mean? Cursory googling mentions that it
was a recent gcc/ld patch, but doesn't really mention what it does or
why it exists.
-Jordan
Jordan Sissel wrote:
> Can someone give me some background on what changed to cause this
> build failure?
This bug is only for the new linker called "gold".
Debian still use the traditional linker "ld" as the default one,
so basically this bug is not a really problem for Debian.
"gold" is a new linker developed by Google and has been merged to
GNU binutils upstream.
You may think "gold" as another "ld" with differerent default behavior.
> * Did the a debian build system change cause this?
No. Only if users uses "gold" to link the binary will cause this.
> * Did xorg change the way they package libraries?
No.
> * Did debian change the way they package xorg?
No.
> * What does 'no-add-needed' mean? Cursory googling mentions that it
> was a recent gcc/ld patch, but doesn't really mention what it does or
> why it exists.
It reduces unnecessary libraries linking.
> I can't test this as I don't use debian. I can confirm that the patch
> doesn't appear to break it building for me on ubuntu.
I did not test it on Ubuntu but I believe it will work fine on it.
Kind regards
Wen-Yen Chuang (caleb)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkr33NEACgkQdEpXpumNYVkieACfWZ2NSQGUWGNwkusXmGraUkGZ
BO0An3KZBhaasAuDyvsEGT2tc/7A1oYZ
=WwA3
-----END PGP SIGNATURE-----