Bug#632601: weechat: please use smart filter for join/part/quit messages by default
Jonathan Nieder
Version: 0.3.5-1
Severity: wishlist
Hi,
Only today I found the following trick in the weechat FAQ:
With smart filter (keep join/part/quit from users who spoke
recently):
/set irc.look.smart_filter on
/filter add irc_smart * irc_smart_filter *
That sounds like an excellent behavior to me. :) Could this be made
the default for new users?
Barring that, I think it would be reasonable to put in a README.Debian
(or better yet, to provide the entire FAQ in /usr/share/doc/weechat).
Please feel free to clone this bug for the latter if it sounds
interesting.
Thanks for packaging weechat; I love it.
Jonathan
--
To UNSUBSCRIBE, email to debian-bugs-...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listm...@lists.debian.org
Sebastien Helleu
> Package: weechat-curses
> Version: 0.3.5-1
> Severity: wishlist
>
> Hi,
>
> Only today I found the following trick in the weechat FAQ:
>
> With smart filter (keep join/part/quit from users who spoke
> recently):
>
> /set irc.look.smart_filter on
> /filter add irc_smart * irc_smart_filter *
>
> That sounds like an excellent behavior to me. :) Could this be made
> the default for new users?
>
> Barring that, I think it would be reasonable to put in a README.Debian
> (or better yet, to provide the entire FAQ in /usr/share/doc/weechat).
> Please feel free to clone this bug for the latter if it sounds
> interesting.
>
> Thanks for packaging weechat; I love it.
> Jonathan
>
Hi Jonathan,
I think this smart filter should not be enabled by default, not all
people may want that (and maybe not on all buffers by default).
For FAQ, it's provided by package weechat-doc and is in directory
/usr/share/doc/weechat-doc/
--
Cordialement / Best regards
Sébastien.
web: flashtux.org / weechat.org mail: flas...@flashtux.org
irc: FlashCode @ irc.freenode.net xmpp: flas...@jabber.fr
Jonathan Nieder
retitle -1 weechat: please make FAQ and other docs more discoverable
quit
Hi Sebastien,
Sebastien Helleu wrote:
> I think this smart filter should not be enabled by default, not all
> people may want that (and maybe not on all buffers by default).
The beauty of defaults is that they can be overridden. :) But I
won't press the issue, since...
> For FAQ, it's provided by package weechat-doc and is in directory
> /usr/share/doc/weechat-doc/
... this part seems more important. Would it be possible to make
weechat-doc install its documentation under
/usr/share/doc/weechat/html, and to make weechat-curses et al Suggests
it? I had no idea that weechat-doc even existed.
See http://lists.debian.org/debian-devel/2011/01/msg00189.html for
the rationale re filesystem locations (one reason: on multi-user
installations, it's better if people don't have to guess which package
contains documentation in order to find it).
Thanks for a pointer.
Regards,
Jonathan
Emmanuel Bouthenot
On Mon, Jul 04, 2011 at 02:00:31AM -0500, Jonathan Nieder wrote:
[...]
> > For FAQ, it's provided by package weechat-doc and is in directory
> > /usr/share/doc/weechat-doc/
>
> ... this part seems more important. Would it be possible to make
> weechat-doc install its documentation under
> /usr/share/doc/weechat/html, and to make weechat-curses et al Suggests
> it? I had no idea that weechat-doc even existed.
>
> See http://lists.debian.org/debian-devel/2011/01/msg00189.html for
> the rationale re filesystem locations (one reason: on multi-user
> installations, it's better if people don't have to guess which package
> contains documentation in order to find it).
You're right, I will add the missing Suggests field in weechat-curses
and a symlink from /usr/share/doc/weechat/html to /usr/share/doc/weechat-doc/html
I will also move /usr/share/doc/weechat-doc/*.html files into
/usr/share/doc/weechat-doc/html
Regards,
M.
--
Emmanuel Bouthenot
mail: kolter@{openics,debian}.org gpg: 4096R/0x929D42C3
xmpp: kol...@im.openics.org irc: kolter@{freenode,oftc}
Emmanuel Bouthenot
thanks
Hi Jonathan,
On Mon, Jul 04, 2011 at 02:00:31AM -0500, Jonathan Nieder wrote:
[...]
> Sebastien Helleu wrote:
> > I think this smart filter should not be enabled by default, not all
> > people may want that (and maybe not on all buffers by default).
>
> The beauty of defaults is that they can be overridden. :) But I
> won't press the issue, since...
[...]
I tend to agree with Sebastien on this point and for now I don't plan to
override the default settings hence I'm tagging this bug “wontfix”.
The best way for you to get this bug fixed/closed will be either to
change your mind or to convince Sebastien :)
Regards,
--
Emmanuel Bouthenot
mail: kolter@{openics,debian}.org gpg: 4096R/0x929D42C3
xmpp: kol...@im.openics.org irc: kolter@{freenode,oftc}
Jonathan Nieder
> You're right, I will add the missing Suggests field in weechat-curses
> and a symlink from /usr/share/doc/weechat/html to /usr/share/doc/weechat-doc/html
>
> I will also move /usr/share/doc/weechat-doc/*.html files into
> /usr/share/doc/weechat-doc/html
How about this? Patches attached since the BTS seems to cope best
that way.
Notes from building:
src/core/wee-network.c: In function ‘network_init’:
src/core/wee-network.c:106:5: warning: ‘gnutls_certificate_client_set_retrieve_function’
is deprecated (declared at /usr/include/gnutls/compat.h:158) [-Wdeprecated-declarations]
dh_pysupport: This program is deprecated, you should use dh_python2 instead.
Migration guide: http://wiki.debian.org/Python/TransitionToDHPython2
dpkg-shlibdeps: warning: dependency on libcrypt.so.1 could be avoided if
"debian/weechat-plugins/usr/lib/weechat/plugins/perl.so" were not uselessly linked
against it (they use none of its symbols).
Jonathan Nieder (2):
Move docs from /usr/share/doc/weechat-doc/*.html to
.../doc/weechat/html/
Make weechat-doc more discoverable
debian/changelog | 10 ++++++++++
debian/control | 2 ++
debian/weechat-doc.doc-base.faq-de | 4 ++--
debian/weechat-doc.doc-base.faq-en | 4 ++--
debian/weechat-doc.doc-base.faq-fr | 4 ++--
debian/weechat-doc.doc-base.faq-it | 4 ++--
debian/weechat-doc.doc-base.faq-pl | 4 ++--
debian/weechat-doc.doc-base.plugin-en | 4 ++--
debian/weechat-doc.doc-base.plugin-fr | 4 ++--
debian/weechat-doc.doc-base.plugin-it | 4 ++--
debian/weechat-doc.doc-base.quickstart-de | 4 ++--
debian/weechat-doc.doc-base.quickstart-en | 4 ++--
debian/weechat-doc.doc-base.quickstart-fr | 4 ++--
debian/weechat-doc.doc-base.quickstart-it | 4 ++--
debian/weechat-doc.doc-base.quickstart-ja | 4 ++--
debian/weechat-doc.doc-base.quickstart-pl | 4 ++--
debian/weechat-doc.doc-base.quickstart-ru | 4 ++--
debian/weechat-doc.doc-base.scripting-de | 4 ++--
debian/weechat-doc.doc-base.scripting-en | 4 ++--
debian/weechat-doc.doc-base.scripting-fr | 4 ++--
debian/weechat-doc.doc-base.scripting-it | 4 ++--
debian/weechat-doc.doc-base.tester-de | 4 ++--
debian/weechat-doc.doc-base.tester-en | 4 ++--
debian/weechat-doc.doc-base.tester-fr | 4 ++--
debian/weechat-doc.doc-base.tester-it | 4 ++--
debian/weechat-doc.doc-base.tester-pl | 4 ++--
debian/weechat-doc.doc-base.user-de | 4 ++--
debian/weechat-doc.doc-base.user-en | 4 ++--
debian/weechat-doc.doc-base.user-fr | 4 ++--
debian/weechat-doc.doc-base.user-it | 4 ++--
debian/weechat-doc.install | 2 +-
debian/weechat-doc.links | 1 +
32 files changed, 70 insertions(+), 57 deletions(-)
create mode 100644 debian/weechat-doc.links
Emmanuel Bouthenot
Thanks for your involvement to improve weechat in Debian.
On Thu, Jul 07, 2011 at 02:21:13PM -0500, Jonathan Nieder wrote:
> Emmanuel Bouthenot wrote:
>
> > You're right, I will add the missing Suggests field in weechat-curses
> > and a symlink from /usr/share/doc/weechat/html to /usr/share/doc/weechat-doc/html
> >
> > I will also move /usr/share/doc/weechat-doc/*.html files into
> > /usr/share/doc/weechat-doc/html
>
> How about this? Patches attached since the BTS seems to cope best
> that way.
This is different from my proposal but why not. Nevertheless, I will be
glad if you could could expose the reasons of your choice. I mean why a
symlink from /usr/share/doc/weechat/html to /usr/share/doc/weechat-doc/html
is not sufficient for you?
> Notes from building:
>
> src/core/wee-network.c: In function ‘network_init’:
> src/core/wee-network.c:106:5: warning: ‘gnutls_certificate_client_set_retrieve_function’
> is deprecated (declared at /usr/include/gnutls/compat.h:158) [-Wdeprecated-declarations]
I will forward this to the upstream developer (but he has probably
already been noticed as he's subscribed to the BTS).
> dh_pysupport: This program is deprecated, you should use dh_python2 instead.
> Migration guide: http://wiki.debian.org/Python/TransitionToDHPython2
sounds to be a DH7 issue as dh_pysupport is not called directly (AFAIR,
there is nothing related to dh_pysupport nor dh_python2 in this
package).
> dpkg-shlibdeps: warning: dependency on libcrypt.so.1 could be avoided if
> "debian/weechat-plugins/usr/lib/weechat/plugins/perl.so" were not uselessly linked
> against it (they use none of its symbols).
IMO, not very important for this package.
[...]
> weechat-core suggests weechat-doc since the latter explains how to
> configure the plugins shipped by the former. Unfortunately most
> Debian package managers do not prominently list packages that
> automatically installed packages Suggest. To ensure people can find
> weechat-doc, let the user-visible packages (weechat-curses and the
> weechat metapackage) suggest it, too.
Good idea.
Jonathan Nieder
> On Thu, Jul 07, 2011 at 02:21:13PM -0500, Jonathan Nieder wrote:
>> How about this? Patches attached since the BTS seems to cope best
>> that way.
>
> This is different from my proposal but why not. Nevertheless, I will be
> glad if you could could expose the reasons of your choice. I mean why a
> symlink from /usr/share/doc/weechat/html to /usr/share/doc/weechat-doc/html
> is not sufficient for you?
Ah, no good reason; it's just what I had on disk. I don't mind if the
links go the other way.
>> dh_pysupport: This program is deprecated, you should use dh_python2 instead.
>> Migration guide: http://wiki.debian.org/Python/TransitionToDHPython2
>
> sounds to be a DH7 issue as dh_pysupport is not called directly (AFAIR,
> there is nothing related to dh_pysupport nor dh_python2 in this
> package).
From the debhelper changelog:
debhelper (7.0.8) unstable; urgency=low
[...]
* Moved python-support special case out of dh and into a python-support
sequence addon. --with=python-support is enabled by default to avoid
breaking backwards compatibility.
I am guessing adding --with=python2 to the "dh" command line would disable
that. Or one can switch to compatibility level 9. :)
debhelper (8.9.1) unstable; urgency=low
[...]
* dh: In v9, do not enable any python support commands. Closes: #634106
>> dpkg-shlibdeps: warning: dependency on libcrypt.so.1 could be avoided if
>> "debian/weechat-plugins/usr/lib/weechat/plugins/perl.so" were not uselessly linked
>> against it (they use none of its symbols).
>
> IMO, not very important for this package.
Yes, seems harmless given that libcrypt is bundled with glibc.
Thanks for your thoughtfulness.
Jonathan
Sebastien Helleu
> Notes from building:
>
> src/core/wee-network.c: In function ‘network_init’:
> src/core/wee-network.c:106:5: warning: ‘gnutls_certificate_client_set_retrieve_function’
> is deprecated (declared at /usr/include/gnutls/compat.h:158) [-Wdeprecated-declarations]
Hi Jonathan,
Could you please tell me which version of gnutls you are using?
With version 2.10.5-2 (from Debian Sid), I have no such warning.
Thank you.
--
Cordialement / Best regards
Sébastien.
web: flashtux.org / weechat.org mail: flas...@flashtux.org
irc: FlashCode @ irc.freenode.net xmpp: flas...@jabber.fr
--
Jonathan Nieder
Sebastien Helleu wrote:
> On Thu, Jul 07, 2011 at 02:21:13PM -0500, Jonathan Nieder wrote:
>> src/core/wee-network.c:106:5: warning: ‘gnutls_certificate_client_set_retrieve_function’
>> is deprecated (declared at /usr/include/gnutls/compat.h:158) [-Wdeprecated-declarations]
[...]
> Could you please tell me which version of gnutls you are using?
> With version 2.10.5-2 (from Debian Sid), I have no such warning.
I'm using version 2.12.7-2 from Debian experimental[*]. It seems the
function was deprecated by gnutls_2_11_3~303 (Deprecated the sign
callback, 2010-05-15) without a corresponding mention in the NEWS file
(oops).
The replacement "gnutls_certificate_set_retrieve_function" was
introduced around the same time. So I wouldn't worry about it unless
you want to try the new API on a separate branch or use ifdefs to make
use of it where available. I don't think the old function's actually
going away soon.
Regards,
Jonathan
[*] I have no clue when it will migrate to sid. :)
http://bugs.debian.org/630511
Sebastien Helleu
(...)
> function was deprecated by gnutls_2_11_3~303 (Deprecated the sign
> callback, 2010-05-15) without a corresponding mention in the NEWS file
> (oops).
>
> The replacement "gnutls_certificate_set_retrieve_function" was
> introduced around the same time. So I wouldn't worry about it unless
> you want to try the new API on a separate branch or use ifdefs to make
> use of it where available. I don't think the old function's actually
> going away soon.
>
> Regards,
> Jonathan
>
> [*] I have no clue when it will migrate to sid. :)
> http://bugs.debian.org/630511
>
Ok. So I think I'll fix that in WeeChat (usind ifdefs to check gnutls
version) when this new version will reach Sid. No urgency for me since
it's only a warning, and function should not be deleted immediately
from gnutls lib.
--
Cordialement / Best regards
Sébastien.
web: flashtux.org / weechat.org mail: flas...@flashtux.org
irc: FlashCode @ irc.freenode.net xmpp: flas...@jabber.fr
--
Sebastien Helleu
FYI, I commited fix to use the new gnutls function:
http://git.savannah.gnu.org/gitweb/?p=weechat.git;a=commitdiff;h=47ac88;hp=88c58c
Jonathan Nieder
> FYI, I commited fix to use the new gnutls function:
> http://git.savannah.gnu.org/gitweb/?p=weechat.git;a=commitdiff;h=47ac88;hp=88c58c
Thanks! Seems to work with gnutls 3.0.1-1 and without showing
warnings here, fwiw.