> I have updated our ticket description with a link to the LinBox
> ticket.

> Cheers,

> Michael

> On Aug 28, 10:31 am, mabshoff <Michael.Absh...@fsmath.mathematik.uni-
> dortmund.de> wrote:
>> This is actually an open ticket at the LinBox trac: seehttp://linalg.org/projects/linalg/ticket/3

>> I have updated our ticket description with a link to the LinBox
>> ticket.

>> Cheers,

>> Michael

> With the knowledge that I am about to become annoying (for posting too
> often), but I did a little more digging: The determinant of the 8x8
> matrix from LinBox's ticket #3 is now computed correctly. So that
> ticket can be closed. But with the new problem Matrix from Sage's
> ticket #498 valgrind tells me the following:

> ==30596== Invalid write of size 8
> ==30596==    at 0x1FCFAA6A: void
> LinBox::create_MatrixQadic<LinBox::PID_integer,
> LinBox::DenseMatrix<LinBox::PID_integer> >(LinBox::PID_intege
> r const&, LinBox::DenseMatrix<LinBox::PID_integer> const&, double*,
> unsigned long, Integer const&) (in /tmp/Work2/sage-2.8.1/sage-2.8.1/
> local/
> lib/liblinboxwrap.so.0.0.0)
> ==30596==    by 0x1FD00819:
> LinBox::BlasMatrixApplyDomain<LinBox::PID_integer,
> LinBox::DenseMatrix<LinBox::PID_integer> >::setup(Integer) (in
> /tmp/Work2/sage-2.8.1/sage-2.8.1/local/lib/liblinboxwrap.so.0.0.0)
> ==30596==    by 0x1FD01BA7:
> LinBox::LiftingContainerBase<LinBox::PID_integer,
> LinBox::DenseMatrix<LinBox::PID_integer> >::LiftingContainerBase
> <Integer, std::vector<Integer, std::allocator<Integer> >
>> (LinBox::PID_integer const&, LinBox::DenseMatrix<LinBox::PID_integer>
> const&, std::v
> ector<Integer, std::allocator<Integer> > const&, Integer const&) (in /
> tmp/Work2/sage-2.8.1/sage-2.8.1/local/lib/liblinboxwrap.so.0.0.0)
> ==30596==    by 0x1FD01F41:
> LinBox::DixonLiftingContainer<LinBox::PID_integer,
> LinBox::Modular<double>, LinBox::DenseMatrix<LinBox::PID_intege
> r>, LinBox::BlasBlackbox<LinBox::Modular<double> >
>> ::DixonLiftingContainer<Integer, std::vector<Integer,
> std::allocator<Integer> > >(LinBox::
> PID_integer const&, LinBox::Modular<double> const&,
> LinBox::DenseMatrix<LinBox::PID_integer> const&,
> LinBox::BlasBlackbox<LinBox::Modular<doub
> le> > const&, std::vector<Integer, std::allocator<Integer> > const&,
> Integer const&) (in /tmp/Work2/sage-2.8.1/sage-2.8.1/local/lib/
> liblinboxw
> rap.so.0.0.0)
> ==30596==    by 0x1FD0583B: LinBox::SolverReturnStatus
> LinBox::RationalSolver<LinBox::PID_integer, LinBox::Modular<double>,
> LinBox::RandomPrim
> eIterator,
> LinBox::DixonTraits>::solveNonsingular<LinBox::DenseMatrix<LinBox::PID_inte ger>,
> std::vector<Integer, std::allocator<Integer> >, st
> d::allocator<Integer> >(std::vector<Integer, std::allocator<Integer>
>> &, Integer&, LinBox::DenseMatrix<LinBox::PID_integer> const&,
> std::alloc
> ator<Integer> const&, bool, int) const (in /tmp/Work2/sage-2.8.1/
> sage-2.8.1/local/lib/liblinboxwrap.so.0.0.0)
> ==30596==    by 0x1FD05BE5: Integer&
> LinBox::LastInvariantFactor<LinBox::PID_integer,
> LinBox::RationalSolver<LinBox::PID_integer, LinBox::Modu
> lar<double>, LinBox::RandomPrimeIterator, LinBox::DixonTraits>
>> ::lastInvariantFactor1<LinBox::DenseMatrix<LinBox::PID_integer>,
> std::vector<I
> nteger, std::allocator<Integer> > >(std::vector<Integer,
> std::allocator<Integer> >, std::vector<Integer,
> std::allocator<Integer> >&, LinBox::D
> enseMatrix<LinBox::PID_integer> const&) const (in /tmp/Work2/
> sage-2.8.1/sage-2.8.1/local/lib/liblinboxwrap.so.0.0.0)
> ==30596==    by 0x1FD06494:
> _ZN6LinBox11lif_cra_detINS_11DenseMatrixINS_11PID_integerEEENS_15HybridSpec ifierEEERNT_5Field7ElementES8_RKS5_RKNS
> _14RingCategories10IntegerTagERKT0_ (in /tmp/Work2/sage-2.8.1/
> sage-2.8.1/local/lib/liblinboxwrap.so.0.0.0)
> ==30596==    by 0x1FD06DB5:
> _ZN6LinBox3detINS_11DenseMatrixINS_11PID_integerEEENS_15HybridSpecifierEEER NT_5Field7ElementES8_RKS5_RKNS_14RingCa
> tegories10IntegerTagERKT0_ (in /tmp/Work2/sage-2.8.1/sage-2.8.1/local/
> lib/liblinboxwrap.so.0.0.0)
> ==30596==    by 0x1FD06DEF:
> _ZN6LinBox3detINS_11DenseMatrixINS_11PID_integerEEENS_15HybridSpecifierEEER NT_5Field7ElementES8_RKS5_RKT0_
> (in /tm
> p/Work2/sage-2.8.1/sage-2.8.1/local/lib/liblinboxwrap.so.0.0.0)
> ==30596==    by 0x1FD06E1B:
> _ZN6LinBox3detINS_11DenseMatrixINS_11PID_integerEEEEERNT_5Field7ElementES7_ RKS4_
> (in /tmp/Work2/sage-2.8.1/sage-2.
> 8.1/local/lib/liblinboxwrap.so.0.0.0)
> ==30596==    by 0x1FC6FCD2: linbox_integer_dense_det (in /tmp/Work2/
> sage-2.8.1/sage-2.8.1/local/lib/liblinboxwrap.so.0.0.0)
> ==30596==    by 0x1F98FDAE:
> __pyx_f_6linbox_20Linbox_integer_dense_det(_object*, _object*,
> _object*) (linbox.cpp:1351)
> ==30596==  Address 0x27A9F6C8 is not stack'd, malloc'd or (recently)
> free'd

> So the problem is a different one than the once fixed.

> On another note: William, didn't you merge my valgrind support patch
> for Sage 2.8.2? A build from source complains about:

> [mabshoff@m940 sage-2.8.2]$ ./sage
> ----------------------------------------------------------------------
> | SAGE Version 2.8.2, Release Date: 2007-08-22                       |
> | Type notebook() for the GUI, and license() for information.        |
> ----------------------------------------------------------------------

> sage:
> Exiting SAGE (CPU time 0m0.00s, Wall time 0m1.01s).
> [mabshoff@m940 sage-2.8.2]$ ./sage -valgrind
> Unknown option: -valgrind
> usage: sage [options]
> Try 'sage -h' for more information.

> Cheers,

> Michael

> I propose the following patch to replace temporarily the rational-solver
> method by the classic chinese remaindering, so that the solution is not
> broken of SAGE and others.

> --- linbox/solutions/det.h      (revision 2798)
> +++ linbox/solutions/det.h      (working copy)
> @@ -572,7 +572,8 @@

>  } // end of LinBox namespace

> -#ifdef __LINBOX_HAVE_NTL
> +//#ifdef __LINBOX_HAVE_NTL
> +#if 0
>  # include "linbox/algorithms/hybrid-det.h"
>  # define SOLUTION_CRA_DET lif_cra_det
>  #else

> Pascal, I remember you were working on fixing this bug in our LinBox
> coding week in august and you had to leave before finishing.
> Can you help me with it if you have any hint ?

> Clement

> Hello,

> > Ok, since the bug comes from the rational-solver, and I am not familiar
> > with it neither, it may be longer than I expected.

> > I propose the following patch to replace temporarily the rational-solver
> > method by the classic chinese remaindering, so that the solution is not
> > broken of SAGE and others.

> > --- linbox/solutions/det.h      (revision 2798)
> > +++ linbox/solutions/det.h      (working copy)
> > @@ -572,7 +572,8 @@

> >  } // end of LinBox namespace

> > -#ifdef __LINBOX_HAVE_NTL
> > +//#ifdef __LINBOX_HAVE_NTL
> > +#if 0
> >  # include "linbox/algorithms/hybrid-det.h"
> >  # define SOLUTION_CRA_DET lif_cra_det
> >  #else

> > Pascal, I remember you were working on fixing this bug in our LinBox
> > coding week in august and you had to leave before finishing.
> > Can you help me with it if you have any hint ?

> > Clement

> with the patch applied I get something reasonable, so I would consider
> this fixed for the time being:

>  sage: M=Matrix(Integers(),20,20,L)
>  sage: M.det()
>  3951360
>  sage: M.rank()
>  20

> I am running a sage -testall to make sure that nothing else is
> negatively affected by the workaround. Thanks Clement for the quick
> fix.

> Cheers,

> Michael

> I hope this would be enough.
> I avoided Clement's patch under CVS and get back to the hybrid
> version.

> Cheers,
> Pascal.

> > I have comited another modification under CVS in order to get rid of
> > your determinant bug.
> > Right now it seems to compute correctly the determinant of your 20x20
> > matrix.

> > I hope this would be enough.
> > I avoided Clement's patch under CVS and get back to the hybrid
> > version.

> > Cheers,
> > Pascal.

> Hello Pascal,

> I assume that you mean Changeset 2803. I will apply that changeset to
> Sage's LinBox spkg and report back.

> Thanks a lot.

> Cheers,

> Michael

> dortmund.de> wrote:
> > On Sep 3, 6:14 pm, Pascal Giorgi <pascal.gio...@lirmm.fr> wrote:

> > > I have comited another modification under CVS in order to get rid of
> > > your determinant bug.
> > > Right now it seems to compute correctly the determinant of your 20x20
> > > matrix.

> > > I hope this would be enough.
> > > I avoided Clement's patch under CVS and get back to the hybrid
> > > version.

> > > Cheers,
> > > Pascal.

> > Hello Pascal,

> > I assume that you mean Changeset 2803. I will apply that changeset to
> > Sage's LinBox spkg and report back.

> > Thanks a lot.

> > Cheers,

> > Michael

> Ok, I applied ChangeSet 2803 and the result is the correct one:

> sage: M=Matrix(Integers(),20,20,L)
> sage: M.det()
> max bit= 32 32
> max value= 1662076505
> 3951360
> sage: M.rank()
> 20
> sage: M.det()
> 3951360

> The only oddity is the debug output about "max bit" and "max value",
> but that only shows up once and I can easily patch that out of our
> spkg.

> Once more thanks for your help,

> Michael

> Pascal.