jQuery deprecation question

39 views
Skip to first unread message

David Pollak

unread,
Jul 5, 2012, 5:18:59 PM7/5/12
to liftweb
Diego,

I see that you've deprecated the whole jqueryartifact system.... this is less than optimal.

The JavaScript artifact system does two different things:
  1. It serves versions of jQuery (something we want to stop doing)
  2. It creates a series of mappings between things Lift needs (e.g., how to make an Ajax call from the server to the browser) and generated JavaScript (something that Lift will break without)
Can you create a set of JSArtifacts that represent the right way to do things with given versions of the JavaScript libraries, but ones that do not serve the JavaScript libraries and update the deprecation messages to point people to the new JSArtifacts?

Thanks,

David

--
Telegram, Simply Beautiful CMS https://telegr.am
Lift, the simply functional web framework http://liftweb.net


Diego Medina

unread,
Jul 5, 2012, 6:33:51 PM7/5/12
to lif...@googlegroups.com
Yes, this morning Jeep also noticed this :(

Now, I thought that simply doing:

case object JQueryArtifacts extends JQueryArtifacts

and then use that in LiftRules was going to be enough, considering we
have been using the js actual functions from the trait JQueryArtifacts
, or have you seen any of those not working as expected?

Thanks

Diego
> --
> Lift, the simply functional web framework: http://liftweb.net
> Code: http://github.com/lift
> Discussion: http://groups.google.com/group/liftweb
> Stuck? Help us help you:
> https://www.assembla.com/wiki/show/liftweb/Posting_example_code



--
Diego Medina
Lift/Scala Developer
di...@fmpwizard.com
http://www.fmpwizard.com

Diego Medina

unread,
Jul 6, 2012, 5:29:12 PM7/6/12
to lif...@googlegroups.com
I was about to push the changes and after running the tests I realized
that I probably should not change the default in LiftRules now.

If I changed the default JQuery Artifact in LiftRules now, the default
jquery 1.3 would not be served, and while we can say that nobody will
use that one, a simple upgrade of a lift app from 2.4 to 2.5 would
force them to make changes to their Boot class, which does not sound
like a deprecating change, but more like a breaking change.

So, I added a

case object JQueryArtifacts extends JQueryArtifacts

in the jQueryArtifacts file that we can start using and I'll use that
setting on the new 2.5 template I'm working on (so new people will
start the right way).
I will also see what error messages I get if I change the liftRules
but do not provide my own version of jQuery, this would help people
googling for those errors (in case they are not as obvious as we would
hope)


ok, test passed so I'm pushing this to master and in about 3:30 hours
the new 2.5-snapshot should be on sonatype

Thanks

Diego
Reply all
Reply to author
Forward
0 new messages