Rev 4973 ready for testing

[Edward K. Ream]

Please report any problem immediately.

Here is the checkin log:

The last step before removing new_dicts and new_strokes switches.

Added *enabled* new_dicts code, moved several classes to leoKeys.py
and fixed pylint complaints.

Moved isStroke and isStrokeOrNone from leoGlobals.py to leoKeys.py.

Defined g.TypedDict and g.TypedDictOfLists classes in leoGlobals.py.

Did some unrelated (and preliminary) work to support the OpenWith menu
without a separate plugin.
The open with menu doesn't work yet.

Fixed some pylint complaints: those involving the @shadow logic were
serious.

Edward

[Edward K. Ream]

On Feb 8, 5:44 am, "Edward K. Ream" <edream...@gmail.com> wrote:
> Please report any problem immediately.

Rev 4974, completes the transition. All unit tests pass, pylint is
happy, and I am using the code without incident.

Please report any problems immediately.

BTW, I had to commit the cleaned version now so as to be able to
continue work revising Leo's key code.

The checking log is:

QQQ
The grand cleanup: removed new_dicts and new_strokes switches,
and all code the is disabled when these switches were False.
QQQ

Edward

[redla]

> Rev 4974, completes the transition. All unit tests pass, pylint is
> happy, and I am using the code without incident.
>
> Please report any problems immediately.

From my POW (i.e. latest Leo on Archlinux/Python3/Qt4), keys works as
expected.
Only the "End not going to the real end of a logical line (if that one
is long & wrapped)" problem remains.
KR,
Radim

[Edward K. Ream]

On Feb 9, 7:41 am, redla <radim.ha...@gmail.com> wrote:

> Only the "End not going to the real end of a logical line (if that one
> is long & wrapped)" problem remains.

Has this changed recently? I expect this is an unrelated bug.

Edward

[redla]

> > Only the "End not going to the real end of a logical line (if that one
> > is long & wrapped)" problem remains.
>
> Has this changed recently?  I expect this is an unrelated bug.

No/yes, that's indeed unrelated problem. You probably overlooked my
previous report on that
http://groups.google.com/group/leo-editor/browse_thread/thread/c933b28c27d3b9a7/8cb42f62bd10549f?show_docid=8cb42f62bd10549f
---
BTW: For some longer time (weeks/months) an "goto end line" handler
is
broken too. Having long enough line in the body (so it is wrapped
and
spans over multiple physical line), "Home" properly jumps at the
start
of the (logical) line, but "End" jumps only to the end of physical
line, i.e. into middle of the line itself. Cut that bug (or at least
non-symmetry) be fixed too, please?

[Edward K. Ream]

On Thu, Feb 9, 2012 at 12:07 PM, redla <radim...@gmail.com> wrote:
>> > Only the "End not going to the real end of a logical line (if that one
>> > is long & wrapped)" problem remains.

Fixed in the trunk at rev 5043. The fix was simply to bypass the Qt
cursor-moving logic when the request is to move the cursor to the end
of the line. All unit tests pass, as do some by-hand tests.

Edward

[redla]

> >> > Only the "End not going to the real end of a logical line (if that one
> >> > is long & wrapped)" problem remains.
>
> Fixed in the trunk at rev 5043.  The fix was simply to bypass the Qt
> cursor-moving logic when the request is to move the cursor to the end
> of the line.  All unit tests pass, as do some by-hand tests.

... and the End now works nicely for me too (tested using bzr:5044).
TX again for the fix!
Radim

[Edward K. Ream]

And once again, thanks for the confirmation. These confirmations are
important: they let me know that *all* the problematic issues have
been resolved.

Edward