Move ipy_leo.py into Leo's core?

0 views
Skip to first unread message

Edward K. Ream

unread,
Jan 2, 2009, 4:39:30 PM1/2/09
to leo-editor
Ville, how much of ipy_leo.py do you think should migrate to Leo's
core? My naive opinion is that it could all go into either
leoNodes.py or leoCommands.py. What do you think?

Would moving these methods into Leo's core make it possible to remove
them from ipy_leo.py?

Is this something that you would be willing to do?

Edward

Edward K. Ream

unread,
Jan 2, 2009, 4:41:20 PM1/2/09
to leo-editor


On Jan 2, 10:39 am, "Edward K. Ream" <edream...@gmail.com> wrote:

> My naive opinion is that it could all go into either
> leoNodes.py or leoCommands.py.

On second thought, it might be better to create something like
leoWorkBook.py.

Edward

Ville M. Vainio

unread,
Jan 2, 2009, 5:09:14 PM1/2/09
to leo-e...@googlegroups.com
On Fri, Jan 2, 2009 at 6:39 PM, Edward K. Ream <edre...@gmail.com> wrote:

> Ville, how much of ipy_leo.py do you think should migrate to Leo's
> core? My naive opinion is that it could all go into either
> leoNodes.py or leoCommands.py. What do you think?

Most critical parts are not ipython specific, so they could well go to leo core.

Regarding LeoNode class - most of the methods are probably too
"special" to actually add to position class. For now, I'd only add .h
and .b attributes.

> Would moving these methods into Leo's core make it possible to remove
> them from ipy_leo.py?

The parts that are moved, yes. I can make LeoNode a subclass of
position and make monkeypatch WorkBook to return those instead of
standard positions in ipy_leo, to provide for the "special"
functionality.

> Is this something that you would be willing to do?

Yes. That's something that has been on my mind for a while, since it
has appeared that ILeo tries to solve a problem that is not IPython
specific for most parts at all (ILeo and alt+I is just a more
convenient way to do ctrl+B, if you are looking it from Leo side).
Moving the stuff to Leo core just makes sense, and there is no reason
to require people to install IPython (and enable ipython.py plugin) to
access this functionality.


--
Ville M. Vainio
http://tinyurl.com/vainio

Reply all
Reply to author
Forward
0 new messages