Web Images Videos Maps News Shopping Gmail more »
Recently Visited Groups | Help | Sign in
Google Groups Home
coding style
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  7 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Fathi Boudra  
View profile  
 More options Jun 4, 2:53 pm
From: Fathi Boudra <fbou...@gmail.com>
Date: Thu, 4 Jun 2009 20:53:33 +0200
Local: Thurs, Jun 4 2009 2:53 pm
Subject: coding style
Hi,

any objections against passing astyle  to get uniform sources for Krusader ?
At the moment, we have _many_ different styles over the sources.

I would like to using kdelibs coding style as a script is already provided:
http://techbase.kde.org/Policies/Kdelibs_Coding_Style#Artistic_Style_...

As Csaba have committed his lister prototype ;), it could be a good timing to
do it right now.

thoughts ?

cheers,

Fathi


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Karai Csaba  
View profile  
 More options Jun 5, 12:56 am
From: Karai Csaba <cska...@freemail.hu>
Date: Fri, 05 Jun 2009 06:56:56 +0200
Local: Fri, Jun 5 2009 12:56 am
Subject: Re: [Krusader-devel] coding style

Hi,

I've created screenshots of my kdevelop settings (based on the artistic
style). Please let me know if they are OK. The best would be to
autoformat every code before committing.

Once we have consent on the coding style it would be useful to put it
onto the webpage.

Thanks,

    Csaba

Fathi Boudra írta:

  format1.png
121K Download

  format2.png
111K Download

  format3.png
125K Download

  format4.png
117K Download

    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Fathi Boudra  
View profile  
 More options Jun 5, 2:43 am
From: Fathi Boudra <fbou...@gmail.com>
Date: Fri, 5 Jun 2009 08:43:15 +0200
Local: Fri, Jun 5 2009 2:43 am
Subject: Re: [Krusader-devel] Re: coding style
Let's start from astyle kdelibs script (as it exists):

astyle \
--brackets=linux \
--convert-tabs \
--indent-labels \
--indent-preprocessor \
--indent=spaces=4
--one-line=keep-statements \
--pad=oper \
--unpad=paren \
`find -type f -name '*.cpp'` `find -type f -name '*.cc'` `find -type f -name '*.h'`

It can be added to ~/.astylerc

> I've created screenshots of my kdevelop settings (based on the artistic
> style). Please let me know if they are OK.

in "tab & brackets":
--indent=spaces=4 => use spaces: 4
--convert-tabs => check convert tabs
--brackets=linux => Linux style

in "indentation"
--indent-labels => check labels
--indent-preprocessor => check preprocessor

in "formatting"
--unpad=paren => check remove unnecessary spaces around parentheses
--pad=oper => check add spaces around operators
--one-line=keep-statements => check keep on-line statements

> The best would be to autoformat every code before committing.

if you use shell, you can script "astyle-krusader && svn commit".

> Once we have consent on the coding style it would be useful to put it
> onto the webpage.

right

cheers,

Fathi


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Rafi Yanai  
View profile  
 More options Jun 7, 4:18 am
From: Rafi Yanai <rafi.ya...@gmail.com>
Date: Sun, 7 Jun 2009 04:18:18 -0400
Local: Sun, Jun 7 2009 4:18 am
Subject: Re: [Krusader-devel] Re: coding style

--indent=spaces=4 => use spaces: 4

Please don't do that.... using spaces instead of tabs is sacrilege of the
highest order...


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Fathi Boudra  
View profile  
 More options Jun 8, 3:19 am
From: Fathi Boudra <fbou...@gmail.com>
Date: Mon, 8 Jun 2009 09:19:08 +0200
Local: Mon, Jun 8 2009 3:19 am
Subject: Re: [Krusader-devel] Re: coding style

> --indent=spaces=4 => use spaces: 4

> Please don't do that.... using spaces instead of tabs is sacrilege of the
> highest order...

I see it the other way, using tabs is awfull:
- difficult to read
- cannot indent parameters properly
- inconsistent with popular coding style (Qt, KDE, etc ...)

any other opinions on the spaces vs tabs indentations ?


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Rafi Yanai  
View profile  
 More options Jun 8, 3:36 am
From: Rafi Yanai <rafi.ya...@gmail.com>
Date: Mon, 8 Jun 2009 10:36:51 +0300
Local: Mon, Jun 8 2009 3:36 am
Subject: Re: [Krusader-devel] Re: coding style

It was a joke..
(Altough I personally am a TAB person)

Just try and google for "spaces vs tabs indentations" it's a fun read...
I personally believe in this one:
http://www.iovene.com/tabs-vs-spaces-the-end-of-the-debate/


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Fathi Boudra  
View profile  
 More options Jun 8, 4:16 am
From: Fathi Boudra <fbou...@gmail.com>
Date: Mon, 8 Jun 2009 10:16:47 +0200
Local: Mon, Jun 8 2009 4:16 am
Subject: Re: [Krusader-devel] Re: coding style

> It was a joke..
> (Altough I personally am a TAB person)

and was taken as you have intended, a joke :)

> Just try and google for "spaces vs tabs indentations" it's a fun read...

I've done it, right after reading your initial mail ;) yeah, very funny!
There's so much articles on the subject.
It's impossible to get a proper opinion as it's a taste question and
mostly a personal point of view.

nice one.
good point for people using tabs for indenting. alignment shoud use spaces.

    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2009 Google