msvc build fixes
Patrick Spendrin
I already committed some fixes to krusader into KDE svn, but here are
some patches where I am not sure so I'd like to ask you to review them
first:
1) there is a problem with the default argument in the function pointer
PREPARE_PROC_FUNC in checksumdlg.cpp - msvc doesn't support this. I
disabled it for now and it compiles, but I am not sure how important
this is.
2) in krusader/main.cpp and in krusader/Queue/queue_mgr.cpp there are
variable length static arrays used. This is also not supported by the
msvc compiler. Attached is a patch which fixes this.
3) in krArc/krarc.cpp there is a macro defined with a parameter followed
by three points - again an msvc problem. May I remove those (patch
attached)?
Can you please take a look at those patches, maybe if you have a better
option at hand (I know those changes are mostly ugly) just tell me?
regards,
Patrick
p.s.: I am subscribed to this mailing list now, so I can read your feedback.
Frank Schoolmeesters
Hi Patrick,
Thanks a lot for all the fixes !
Most of the Krusader developers are occupied but they will take care
these patches.
Kind regards,
Frank
Krusader Documentation & Marketing Coordinator
Frank Schoolmeesters
Added in the Sourceforge bugtracker, so that the patch doesn't get
lost in the krusader-devel mailinglist.
Sourceforge Bug ID: 2865231
http://sourceforge.net/tracker/?func=detail&aid=2865231&group_id=6488&atid=106488
Thank and bye,
Frank
sh...@anticoder.com
sorry the late response. i have tons of excuses :-(
generally speaking: if you're working on windows patches, better find
the time to build the project on linux afterwards and see that nothing
got broken.
-first patch-
not sure why msvc should have a problem with a default argument. in
any case, being a default argument, compilation would break if anyone
was actually using this argument, so i guess you're safe.
-second patch-
looks good.
-third patch-
if you'll note, there's a big #if 0 surrounding the definition, and in
fact, this macro is #defined to do nothing. it's probably safe to
comment it out along with relevant code using it (if at all)
thanks, and again, sorry for the late reply!
Shie
On Sep 23, 10:06 pm, Frank Schoolmeesters
>
> Thank and bye,
>
> Frank