Hello, I would like to introduce myself to the Krusader developers, and ask to become one too. I have been using Linux and KDE for some years now, but i started using Krusader only recently. Well now i can't imagine going back to Konqueror or Dolphin ;-)
Skills: c++ - good, qt/kde - ok i guess, will surely become better ;-)
On Mon, Oct 12, 2009 at 1:50 PM, Jan Lepper <jan_lep...@gmx.de> wrote:
> Hello, I would like to introduce myself to the Krusader developers, and ask to > become one too. > I have been using Linux and KDE for some years now, but i started using > Krusader only recently. Well now i can't imagine > going back to Konqueror or Dolphin ;-)
Good choice ;-)
> Skills: c++ - good, qt/kde - ok i guess, will surely become better ;-)
Great !
> I have already submitted two patches to Krusader:
> Hello, I would like to introduce myself to the Krusader developers, and ask > to become one too.
Hello Jan,
welcome in the team. You might have noticed, that the overall mail traffic is quite low here. Unfortunately (or fortunately - depending on the point of view) everybody is occupied with real life issues. I for example had a busy week and I am now working through one week of private emails :-)
I can not say anything about the patches you are mentioning. I worked mainly on the colors of the detailed view, the selection modes and FreeBSD port. I would say: just start with the patches. If you have a specific question: just ask. Please do not expect a quick answer. If you do not get an answer, just do what you think is correct. Currently there is no developement here, so it can't get worse. And as developement is svn based, everything can be reverted if it turns out, that something is broken, so don't be afraid to make changes.
If you have design questions (like: is this button better placed here or should do the following), better ask with a small screenshot, if possible. This triggers in my experience much more discussion :-)
There are also some technical design papers somewhere (I must seek). I guess, they were posted here a long time ago, but I am not sure. If you need them but can't find them, I will look for myself.
Sorry that I can't be of much help; I think we should have invited new developers earlier. Nevertheless I hope, that you have fun and time to work on krusader and that soon other developers will work with you on it as well.
hi Jan,
i'll start with apologizing for late reply - or for future late
replies :-)
As Heiner mentioned, most of the developers who worked on the project
(which will be 10 years old soon!) are otherwise preoccupied with
other things, so even as important as krusader :-)
As a founding father of the project, i have some knowledge is various
areas of the code - though not in all of them as the project was
developed in many directions and by many people over the years.
I will do my best to reply to any questions you (and other developers)
may have as my time permits, and i encourage other current/retired
krusader developers to do the same. Rafi, if you read this... :-)
I'd mostly follow heiner's advice and start poking around. It's better
to test before commiting code though :-)
thanks and good luck!
Shie
On Oct 18, 5:30 pm, Heiner <h.eichm...@gmx.de> wrote:
> > Hello, I would like to introduce myself to the Krusader developers, and ask
> > to become one too.
> Hello Jan,
> welcome in the team. You might have noticed, that the overall mail traffic is
> quite low here. Unfortunately (or fortunately - depending on the point of
> view) everybody is occupied with real life issues. I for example had a busy
> week and I am now working through one week of private emails :-)
> I can not say anything about the patches you are mentioning. I worked mainly
> on the colors of the detailed view, the selection modes and FreeBSD port. I
> would say: just start with the patches. If you have a specific question: just
> ask. Please do not expect a quick answer. If you do not get an answer, just
> do what you think is correct. Currently there is no developement here, so it
> can't get worse. And as developement is svn based, everything can be reverted
> if it turns out, that something is broken, so don't be afraid to make
> changes.
> If you have design questions (like: is this button better placed here or
> should do the following), better ask with a small screenshot, if possible.
> This triggers in my experience much more discussion :-)
> There are also some technical design papers somewhere (I must seek). I guess,
> they were posted here a long time ago, but I am not sure. If you need them
> but can't find them, I will look for myself.
> Sorry that I can't be of much help; I think we should have invited new
> developers earlier. Nevertheless I hope, that you have fun and time to work
> on krusader and that soon other developers will work with you on it as well.
Allright, I will start with small features / bugfixes. I guess i will need an svn account then ;-)
Things that come to my mind, I could work on in the future: icon-view, back/forward in history, undo for copy/move, make refresh of views faster (as fast as in 1.90 ;-) )
Am Dienstag 20 Oktober 2009 13:24:43 schrieb Jan Lepper:
> Hi everybody, and thanks for the welcome !
> Allright, I will start with small features / bugfixes. I guess i will need > an svn account then ;-)
> Things that come to my mind, I could work on in the future: > icon-view, back/forward in history, undo for copy/move, make refresh of > views faster (as fast as in 1.90 ;-) )
> Jan
Hi Jan,
since Krusader is developed in kde-extragear now, you have to apply for a KDE account. This url should get you started:
On Tue, Oct 20, 2009 at 1:50 PM, Dirk Eschler <esch...@gmail.com> wrote:
> Am Dienstag 20 Oktober 2009 13:24:43 schrieb Jan Lepper: >> Hi everybody, and thanks for the welcome !
>> Allright, I will start with small features / bugfixes. I guess i will need >> an svn account then ;-)
>> Things that come to my mind, I could work on in the future: >> icon-view, back/forward in history, undo for copy/move, make refresh of >> views faster (as fast as in 1.90 ;-) )
>> Jan
> Hi Jan,
> since Krusader is developed in kde-extragear now, you have to apply for a KDE > account. This url should get you started:
On Tue, Oct 20, 2009 at 1:24 PM, Jan Lepper <jan_lep...@gmx.de> wrote:
> Hi everybody, and thanks for the welcome !
> Allright, I will start with small features / bugfixes. I guess i will need an > svn account then ;-)
> Things that come to my mind, I could work on in the future: > icon-view, back/forward in history, undo for copy/move, make refresh of views > faster (as fast as in 1.90 ;-) )
I suppose it's a good startpoint for starting coding.
Please also create a Sourceforge account (if you don't have one yet, but I think you have already one ;) Please tell us what is your SF account name. Than we can you give rights to modify the status of the bugs and paches in the SF tracker.
When adding new features, fix a bug, change stuff, .... please update the "Changelog" http://websvn.kde.org/trunk/extragear/utils/krusader/ChangeLog?view=m... The Changelog usually contains a one line description what is been changed. If possible commit it together whith the change (but it's not a problem if it's updated later on if you are forgotten to do this).
Both the ChangeLog and SVNNEWS, will inform everyone about the changes, and allows me to write updates for the Krusader handbook. I don't have the time to play with all the new features and discover what a new feauture does do exactly. And even if I would have the time, I will probably not notice all changes, and so they stay would undocumented, what is bad.
I hope a few new developers whil show up so that you can discuss the code changes.
If you have any questions, just ask.
Usually (when I have some time ;) , I play and test Krusader-SVN and provide feedback for the developers.
btw. The next is obvious but I prefer to mention it, if you think the new code is not ok or if you don't understand fully what the new code does, please don't commit in SVN.
icon-view: won't be easy, the best is to check how Brief/Detailed views
work
back/forward in history:
easy to do, please take care, that every panel has different
history
undo for copy / move
not very difficult, just make sure, that it's implemented in
every place where file copy happens (copy dialog/clipboard
/queued copy?/...)
make refresh of views faster:
hard stuff
it was already optimized, but it can still be faster
it's possible to duplicate the speed of sorting
the Unicode->UTF8 conversion is not cached
so, if you have 10.000 files, then strings will be converted
to UTF8 100.000.000 times (localAwareCompare always calls
Unicode->UTF8 converter).
I didn't touch this part of the code to keep it nice.
I'm afraid, that drawing the data takes more time then
sorting.
> Allright, I will start with small features / bugfixes. I guess i will need an > svn account then ;-)
> Things that come to my mind, I could work on in the future:
> icon-view, back/forward in history, undo for copy/move, make refresh of views > faster (as fast as in 1.90 ;-) )
Looks like there is a bottleneck in the detailled view - if you activate the mime-type column the refresh beecomes much slower. Without it its quite fast actually ;-)
It's not a bottleneck. You can turn off the mimetype magic in
Konfigurator, and it'll be fast.
What does mimetype-magic do?
- determines the filetype from loading the first x bytes of the file
- if the file starts with RIFF, then it's a WAV file
- mimetype magic is able to detect a wav file if its name is
mywav.music
This is slow. Krusader loads only the visible files' mime type,
because it's time consuming.
In brief view it is slow (you can see 100 files), but in detailed view
only the scrolling will be slow
(Krusader loads the mime if needed).
Csaba
On Oct 21, 10:27 pm, Jan Lepper <jan_lep...@gmx.de> wrote:
> Looks like there is a bottleneck in the detailled view - if you activate the
> mime-type column the refresh beecomes much slower. Without it its quite fast
> actually ;-)
Could you add "jlepper" as a Krusader developer and add rights to the
patch tracker and bug tracker?
I can't find a button to add a developer or I have not sufficient
rights to do it.
I can change rights in the Krusader trackers but if the user is not a
added as developer I can't do nothing at all ... ;)
btw. Jan, I approved your KDE SVN account, when the KDE sysadmin adds
your account you will receive a mail.
Thanks and bye,
Frank
On 10/21/09, Jan Lepper <jan_lep...@gmx.de> wrote:
> On Tuesday 20 October 2009 17:11:14 Frank Schoolmeesters wrote:
>> Please also create a Sourceforge account (if you don't have one yet,
>> but I think you have already one ;)
> Could you add "jlepper" as a Krusader developer and add rights to the
> patch tracker and bug tracker?
> I can't find a button to add a developer or I have not sufficient
> rights to do it.
> I can change rights in the Krusader trackers but if the user is not a
> added as developer I can't do nothing at all ... ;)
> btw. Jan, I approved your KDE SVN account, when the KDE sysadmin adds
> your account you will receive a mail.
> Thanks and bye,
> Frank
> On 10/21/09, Jan Lepper <jan_lep...@gmx.de> wrote:
> > Hi Frank,
> > On Tuesday 20 October 2009 17:11:14 Frank Schoolmeesters wrote:
> >> Please also create a Sourceforge account (if you don't have one yet,
> >> but I think you have already one ;)
Am Donnerstag 22 Oktober 2009 16:58:51 schrieb Frank Schoolmeesters:
> Dirk, Shie or Rafi
> Could you add "jlepper" as a Krusader developer and add rights to the > patch tracker and bug tracker? > I can't find a button to add a developer or I have not sufficient > rights to do it. > I can change rights in the Krusader trackers but if the user is not a > added as developer I can't do nothing at all ... ;)
> btw. Jan, I approved your KDE SVN account, when the KDE sysadmin adds > your account you will receive a mail.
Hi,
i've made Jan a developer on SourceForge.
Jan, don't put to much effort in managing the bugs on SourceForge though (better try to resolve them :-P). The website is soon to be relaunced with trac being embedded as a bugtracker and moving the existing bugs to trac is one of the missing pieces. Once that is done there isn't actually much left we use on SourceForge, besides the download mirrors maybe.
I could use a hand in moving the bugs though. So maybe everyone who has a bit of time on his hands can check the SorceForge bugtracker for bugs that are still valid, and close those that can't be confirmed anymore. Later i can move the remaining bugs.
> I suppose it's a good startpoint for starting coding.
Jan,
You have now the rights to manage the bugs and patches in the Sourceforge tracker. So you can now e.g. close the bug reports and patches who are committed in SVN.