Documentation and other issues for Krusader
Burkhard Lück
The documentation for Krusader appears twice in khelcenters navigation tree,
as "Krusader" and "Krusader - root-mode". The second entry is superflous,
attached patch of krusader_root-mode.desktop does fix it.
"Krusader\nTwin-Panel File Manager for KDE" is untranslated on the about page,
attached a patch to fix this.
Help button on the first dialog "Search results / Searching for tools" triggers
no action, added one in the third patch (better than a non functional button).
Fourth patch with some string changes due to renaming in Systemsettings.
Category/Title/Tooltip/Description of user action are untranslated in
Konfigurator and in menu Useractions due to missing extraction from
useraction_examples.xml, no patch.
Documentation has no <!-- TRANS:CREDIT_FOR_TRANSLATORS -->, patch with some
more changes for master attached.
--
Burkhard Lück
Yuri Chornoivan
Hi,
Applied to git master. Thanks for this patch.
Krusader docs differs from other KDE docs by image placement (images
in /pics). Is it translation safe? I mean, will the localized
screenshots in l10n-kde4/xx/docs/extragear-utils/krusader/pics be
packaged and visible? Does it make sense to add custom CMakeLists.txt
for them?
Thanks in advance for the answer.
Best regards,
Yuri
Burkhard Lück
>
> Applied to git master. Thanks for this patch.
>
> Krusader docs differs from other KDE docs by image placement (images
> in /pics). Is it translation safe? I mean, will the localized
> screenshots in l10n-kde4/xx/docs/extragear-utils/krusader/pics be
> packaged and visible?
Yes.
> Does it make sense to add custom CMakeLists.txt
> for them?
>
Only to avoid this warning:
<quoting build log>
CMake Warning (dev) at docs/calligra/kformula/CMakeLists.txt:1
(add_subdirectory):
The source directory
/home/kdedev/svn/l10n-kde4/xx/docs/extragear-utils/krusader/pics
does not contain a CMakeLists.txt file.
CMake does not support this case but it used to work accidentally and is
being allowed for compatibility.
Policy CMP0014 is not set: Input directories must have CMakeLists.txt. Run
"cmake --help-policy CMP0014" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
This warning is for project developers. Use -Wno-dev to suppress it.
</quoting build log>
"used to work accidentally and is being allowed for compatibility" sounds
dangerous to me, what if this behavior of CMake changes (maybe silently) in
the future?
autogen.sh first deletes all CMakeLists.txt files in lang/docs and then
regenerates all of them thus overwriting any manual changes.
To work properly now and in the future for this case autogen.sh had to be
patched for subdirs with png files, but I doubt that it makes sense.
I'd move all pic/*png files into krusader/doc and do the same for the localized
screenshots.
--
Burkhard Lück
Burkhard Lück
> Hi Krusader devels,
>
> The documentation for Krusader appears twice in khelcenters navigation
> tree, as "Krusader" and "Krusader - root-mode". The second entry is
> superflous, attached patch of krusader_root-mode.desktop does fix it.
>
> "Krusader\nTwin-Panel File Manager for KDE" is untranslated on the about
> page, attached a patch to fix this.
>
> Help button on the first dialog "Search results / Searching for tools"
> triggers no action, added one in the third patch (better than a non
> functional button).
>
> Fourth patch with some string changes due to renaming in Systemsettings.
>
Release schedule?
Frank Schoolmeesters
> Am Donnerstag, 14. Juli 2011, um 18:14:13 schrieb Burkhard Lück:
>> Hi Krusader devels,
>>
>> The documentation for Krusader appears twice in khelcenters navigation
>> tree, as "Krusader" and "Krusader - root-mode". The second entry is
>> superflous, attached patch of krusader_root-mode.desktop does fix it.
>>
>> "Krusader\nTwin-Panel File Manager for KDE" is untranslated on the about
>> page, attached a patch to fix this.
>>
>> Help button on the first dialog "Search results / Searching for tools"
>> triggers no action, added one in the third patch (better than a non
>> functional button).
>>
>> Fourth patch with some string changes due to renaming in Systemsettings.
>>
> Any objections to commit?
> Release schedule?
>
Hi,
Feel free to commit everything what fixes issues in the Krusader documentation.
We don't have a release schedule. ;)
I suppose we will release at least a new beta before releasing a stable.
Jan should reply this question, but you have enough time, don't worry.
I propose when the second beta is out to make a release schedule for
KDE (basically "the stable will not be release before foo date").
Basically the GUI is already frozen, and will probably not change
(except maybe to fix a i10n bug).
Thanks a lot and bye,
Frank
Burkhard Lück
> Am Donnerstag, 14. Juli 2011, um 18:14:13 schrieb Burkhard Lück:
> > Hi Krusader devels,
> >
> > The documentation for Krusader appears twice in khelcenters navigation
> > tree, as "Krusader" and "Krusader - root-mode". The second entry is
> > superflous, attached patch of krusader_root-mode.desktop does fix it.
> >
> > "Krusader\nTwin-Panel File Manager for KDE" is untranslated on the about
> > page, attached a patch to fix this.
> >
Fix commited.
> > Help button on the first dialog "Search results / Searching for tools"
> > triggers no action, added one in the third patch (better than a non
> > functional button).
> >
Fix commited.
> > Fourth patch with some string changes due to renaming in Systemsettings.
>
Fix commited.
> Any objections to commit?
> Release schedule?
>
> > Category/Title/Tooltip/Description of user action are untranslated in
> > Konfigurator and in menu Useractions due to missing extraction from
> > useraction_examples.xml, no patch.
> >
Should I file a BR?
> > Documentation has no <!-- TRANS:CREDIT_FOR_TRANSLATORS -->, patch with
> > some more changes for master attached.
Fix commited by our famous Yuri ;-)
--
Burkhard Lück
Frank Schoolmeesters
> Am Dienstag, 26. Juli 2011, 18:25:36 schrieb Burkhard Lück:
>> Am Donnerstag, 14. Juli 2011, um 18:14:13 schrieb Burkhard Lück:
>> > Hi Krusader devels,
>> >
>> > The documentation for Krusader appears twice in khelcenters navigation
>> > tree, as "Krusader" and "Krusader - root-mode". The second entry is
>> > superflous, attached patch of krusader_root-mode.desktop does fix it.
>> >
> Fix commited.
>
>> > "Krusader\nTwin-Panel File Manager for KDE" is untranslated on the about
>> > page, attached a patch to fix this.
>> >
> Fix commited.
>
>> > Help button on the first dialog "Search results / Searching for tools"
>> > triggers no action, added one in the third patch (better than a non
>> > functional button).
>> >
> Fix commited.
>
>> > Fourth patch with some string changes due to renaming in Systemsettings.
>>
> Fix commited.
>
>> Any objections to commit?
>> Release schedule?
>>
>> > Category/Title/Tooltip/Description of user action are untranslated in
>> > Konfigurator and in menu Useractions due to missing extraction from
>> > useraction_examples.xml, no patch.
>> >
> Should I file a BR?
>
Please file a bug report, otherwise it will be probably forgotten.
Thanks for all fixes!
Frank